feat(skills,pipelines): ask the user at the two points being wrong is cheap, and stop paying for reviews the diff does not need
The `default` 8-node pipeline walked past its own intake: the node declared `agenthub stage intake`, a stage report with no work attached, so "intake" was a label the run passed through without ever asking a question. It now declares `/superpowers:brainstorming` (and detects it — that rule moves off `plan`), and both driving skills make the brainstorm mandatory, asked with AskUserQuestion and waited on rather than answered on the user's behalf. Three stops replace three silent slides: - After the plan is written and adversarially challenged, it goes to the USER for approval. Implementation does not start without it, and work that turns out to need a different approach comes back for a fresh one. - Review picks its reviewers from `git diff --name-only`: Claude Code's own `code-review` always, a domain reviewer only for a layer the diff actually touched, and — new — only once the change is big enough to have seams. Three agents re-reading twenty lines buys one opinion at three times the tokens, on every fix-loop lap. Review is also a loop now: it ends on a clean pass over the current diff, not on one pass having happened. - The gate asks the user to accept before anything is claimed done (and in the lane pipeline, before the PR is published — publishing is outward-facing). A NO-GO re-enters by SIZE: a defect goes back to implement, a wrong approach back to plan. Nothing carries a NO-GO forward with a note about it. Also here, from a real stall seen on a lane: `ship-feature` had no waiting rule at all, and a session at the gate invented one with `ScheduleWakeup` — a /loop-only primitive that paces nothing here and is refused outright when `auto` mode cannot reach its safety classifier. The rule the lane skill already had now exists in both. Cost, measured in what each agent is actually for: the suite run leaves its agent (nothing is judged, so nothing is delegated — an agent there buys a second model's tokens to read output the session can read for free), and `backend-reviewer` drops from opus to sonnet like its frontend twin; both read a scoped diff against a fixed checklist, and the senior gate above them is still opus. Skill bugs found in the same sweep: doc-map told agents not to recreate the removed translations and then, three lines later, to mirror every README change into them; the docs mapping still carried `+VN+CN` and the punctuation left by their removal; Procedure jumped 2 → 6; Verify required `scripts/doc-coverage.sh`, which does not exist in this repo.
This commit is contained in:
@@ -157,6 +157,18 @@ describe("per-node driver command", () => {
|
||||
// `agenthub lanes node <id>` runnable for every node in the template.
|
||||
assert.equal(byId.done, "agenthub stage done");
|
||||
assert.equal(byId["e2e-feature-passed"], "agenthub stage e2e-feature-passed");
|
||||
|
||||
// The 8-node `default` template drives the same way. `intake` in particular
|
||||
// runs the brainstorm — it used to declare only `agenthub stage intake`,
|
||||
// which made "intake" a label the pipeline walked past without ever asking
|
||||
// the user a question.
|
||||
const def = getPipeline("default");
|
||||
const defById = Object.fromEntries(def.nodes.map((n) => [n.id, n.command]));
|
||||
assert.equal(defById.intake, "/superpowers:brainstorming");
|
||||
assert.equal(defById.plan, "/superpowers:writing-plans");
|
||||
assert.equal(defById.implement, "/superpowers:test-driven-development");
|
||||
assert.equal(defById.gate, "/superpowers:verification-before-completion");
|
||||
assert.equal(defById.done, "agenthub stage done");
|
||||
});
|
||||
|
||||
it("defaults a template node that declares no command to the empty string", () => {
|
||||
|
||||
@@ -571,12 +571,12 @@ describe("pruneRetiredPluginRoots", () => {
|
||||
fs.writeFileSync(path.join(pluginsDir, "installed_plugins.json"), "{}");
|
||||
});
|
||||
|
||||
it("keeps the current build and the two newest retired ones", () => {
|
||||
it("keeps the current build and the single newest retired one", () => {
|
||||
const removed = boot.pruneRetiredPluginRoots(RT, dir("current"));
|
||||
assert.equal(removed, 3); // v1 v2 v3 go; v4 v5 are the cushion
|
||||
assert.equal(removed, 4); // v1..v4 go; v5 is the whole cushion
|
||||
assert.ok(fs.existsSync(dir("current")));
|
||||
assert.ok(fs.existsSync(dir("v5")));
|
||||
assert.ok(fs.existsSync(dir("v4")));
|
||||
assert.ok(!fs.existsSync(dir("v4")));
|
||||
assert.ok(!fs.existsSync(dir("v1")));
|
||||
});
|
||||
|
||||
|
||||
@@ -176,7 +176,8 @@ test("detects stage through the real default pipeline template, end-to-end via g
|
||||
test("every shipped default.json rule fires end-to-end via getPipeline", () => {
|
||||
const pipeline = getPipeline("default");
|
||||
const cases = [
|
||||
["plan", "Skill", { skill: "brainstorming" }],
|
||||
// The brainstorm is intake's own work now, so it paints intake, not plan.
|
||||
["intake", "Skill", { skill: "brainstorming" }],
|
||||
["plan", "Skill", { skill: "writing-plans" }],
|
||||
["implement", "Edit", { file_path: "server/lib/app.js" }],
|
||||
["implement", "Write", { file_path: "server/lib/app.js" }],
|
||||
|
||||
@@ -8,7 +8,7 @@
|
||||
"label": "Intake",
|
||||
"icon": "📝",
|
||||
"gate": false,
|
||||
"command": "agenthub stage intake",
|
||||
"command": "/superpowers:brainstorming",
|
||||
"aliases": [
|
||||
"assigned",
|
||||
"claimed",
|
||||
@@ -18,6 +18,10 @@
|
||||
{
|
||||
"tool": "Agent",
|
||||
"match": "^Explore$"
|
||||
},
|
||||
{
|
||||
"tool": "Skill",
|
||||
"match": "brainstorming"
|
||||
}
|
||||
]
|
||||
},
|
||||
@@ -35,7 +39,7 @@
|
||||
"detect": [
|
||||
{
|
||||
"tool": "Skill",
|
||||
"match": "brainstorming|writing-plans"
|
||||
"match": "writing-plans"
|
||||
},
|
||||
{
|
||||
"tool": "Write",
|
||||
|
||||
Reference in New Issue
Block a user