feat(lanes): give every pipeline node its own driver command
A pipeline template named ONE command for the whole run (`skill`), so the only way to know what actually moves a given node was to read that node's `detect` regexes. Each node now carries its own `command`: a slash command (`/superpowers:writing-plans`) or a shell one (`ccam lanes hook ci-gate`), whichever its detect rules already watch for. The values are derived from each node's own detect rules, not invented — every `ccam …` string was checked against bin/ccam.js and every `/superpowers:*` against the installed plugin. Nodes reaching which is a declaration rather than an action (`done`, `merged`, `reported`, `e2e-feature-passed`, `qc-plan`) are deliberately left empty. `pipelines.js` normalizes a missing or non-string value to "", so a custom template written before this field keeps loading rather than rendering "undefined". `nodeStates()` and GET /api/lanes/pipeline-stats pass it through. Never executed by the dashboard — display text, the same contract `skill` already had. Surfaced where each view has room for it: the Workflows pass-rate panel shows it under the node label and copies it on click; PipelineMap folds it into the node tooltip, because a 16-node pipeline has to fit across one card and there is no width for a second line. `command?: string` is optional in the client type only to spare four unrelated test fixtures — the server always sends the key, and the UI has to branch on the empty string regardless. Verified: npm run test:server (1373, +3), npm run test:client (459, +2), tsc --noEmit, prettier and check-headers clean. docs/LANES.md § Custom template format documents the field. openapi.yaml needs no change: the lane payload and pipeline-stats were never schematized there.
This commit is contained in:
@@ -126,6 +126,72 @@ describe("pipelines", () => {
|
||||
const lanes = require("../lib/lanes");
|
||||
const features = require("../lib/lane-features");
|
||||
|
||||
describe("per-node driver command", () => {
|
||||
it("gives every built-in template's nodes a command field, and carries it into the render states", () => {
|
||||
for (const pipeline of listPipelines()) {
|
||||
for (const node of pipeline.nodes) {
|
||||
assert.equal(
|
||||
typeof node.command,
|
||||
"string",
|
||||
`${pipeline.id}/${node.id} must declare a command string`
|
||||
);
|
||||
}
|
||||
const states = nodeStates(pipeline, { stage: pipeline.nodes[0].id, stages: {} });
|
||||
assert.deepEqual(
|
||||
states.map((n) => n.command),
|
||||
pipeline.nodes.map((n) => n.command),
|
||||
`${pipeline.id}: nodeStates must pass each node's command through`
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
it("names a real driver for the stages an agent actually drives", () => {
|
||||
const ship = getPipeline("ship-feature");
|
||||
const byId = Object.fromEntries(ship.nodes.map((n) => [n.id, n.command]));
|
||||
|
||||
assert.equal(byId.intake, "/superpowers:brainstorming");
|
||||
assert.equal(byId.implementing, "/superpowers:test-driven-development");
|
||||
assert.equal(byId.gates, "ccam lanes hook ci-gate");
|
||||
// A terminal node has no driver of its own: reaching `done` is a
|
||||
// declaration, not something a command performs.
|
||||
assert.equal(byId.done, "");
|
||||
});
|
||||
|
||||
it("defaults a template node that declares no command to the empty string", () => {
|
||||
// A custom template written before this field existed must keep loading -
|
||||
// an undefined command would render as "undefined" in the UI.
|
||||
const fs = require("node:fs");
|
||||
const dir = fs.mkdtempSync(pathMod.join(os.tmpdir(), "pipelines-nocmd-"));
|
||||
fs.writeFileSync(
|
||||
pathMod.join(dir, "legacy.json"),
|
||||
JSON.stringify({
|
||||
id: "legacy-nocmd",
|
||||
name: "Legacy",
|
||||
nodes: [
|
||||
{ id: "start", label: "Start" },
|
||||
{ id: "done", command: 42 },
|
||||
],
|
||||
})
|
||||
);
|
||||
const prev = process.env.DASHBOARD_PIPELINES_DIR;
|
||||
process.env.DASHBOARD_PIPELINES_DIR = dir;
|
||||
const { reload } = require("../lib/pipelines");
|
||||
reload();
|
||||
try {
|
||||
const p = getPipeline("legacy-nocmd");
|
||||
assert.deepEqual(
|
||||
p.nodes.map((n) => n.command),
|
||||
["", ""],
|
||||
"a missing or non-string command must normalize to empty, never leak through"
|
||||
);
|
||||
} finally {
|
||||
if (prev === undefined) delete process.env.DASHBOARD_PIPELINES_DIR;
|
||||
else process.env.DASHBOARD_PIPELINES_DIR = prev;
|
||||
reload();
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
describe("lanes lib", () => {
|
||||
it("creates, lists, updates and deletes a lane", () => {
|
||||
const l = lanes.createLane({ title: "Feature A", cwd: "/tmp/wt/a", branch: "feat/a" });
|
||||
|
||||
@@ -25,6 +25,7 @@
|
||||
"label": "Plan",
|
||||
"icon": "🧭",
|
||||
"gate": false,
|
||||
"command": "/superpowers:writing-plans",
|
||||
"aliases": [
|
||||
"planning",
|
||||
"brainstorm",
|
||||
@@ -53,6 +54,7 @@
|
||||
"label": "Implement",
|
||||
"icon": "🛠",
|
||||
"gate": false,
|
||||
"command": "/superpowers:test-driven-development",
|
||||
"aliases": [
|
||||
"implementing",
|
||||
"coding",
|
||||
@@ -77,6 +79,7 @@
|
||||
"label": "Tests",
|
||||
"icon": "🧪",
|
||||
"gate": true,
|
||||
"command": "npm test",
|
||||
"aliases": [
|
||||
"testing",
|
||||
"unit",
|
||||
@@ -99,6 +102,7 @@
|
||||
"label": "Review",
|
||||
"icon": "👀",
|
||||
"gate": true,
|
||||
"command": "/superpowers:requesting-code-review",
|
||||
"aliases": [
|
||||
"reviewing",
|
||||
"code-review",
|
||||
@@ -124,6 +128,7 @@
|
||||
"label": "Gate",
|
||||
"icon": "🚦",
|
||||
"gate": true,
|
||||
"command": "/superpowers:verification-before-completion",
|
||||
"aliases": [
|
||||
"verify",
|
||||
"verification",
|
||||
@@ -146,6 +151,7 @@
|
||||
"label": "Ship",
|
||||
"icon": "🔀",
|
||||
"gate": false,
|
||||
"command": "/superpowers:finishing-a-development-branch",
|
||||
"aliases": [
|
||||
"pr",
|
||||
"pr-open",
|
||||
|
||||
@@ -8,6 +8,7 @@
|
||||
"label": "Intake",
|
||||
"icon": "📝",
|
||||
"gate": false,
|
||||
"command": "/superpowers:brainstorming",
|
||||
"aliases": [
|
||||
"assigned",
|
||||
"claimed",
|
||||
@@ -34,6 +35,7 @@
|
||||
"label": "Plan",
|
||||
"icon": "🧭",
|
||||
"gate": false,
|
||||
"command": "/superpowers:writing-plans",
|
||||
"aliases": [
|
||||
"planning",
|
||||
"brainstorm",
|
||||
@@ -62,6 +64,7 @@
|
||||
"label": "Implement (TDD)",
|
||||
"icon": "🛠",
|
||||
"gate": false,
|
||||
"command": "/superpowers:test-driven-development",
|
||||
"aliases": [
|
||||
"implement",
|
||||
"coding",
|
||||
@@ -87,6 +90,7 @@
|
||||
"label": "CI gates + preflight",
|
||||
"icon": "🧪",
|
||||
"gate": true,
|
||||
"command": "ccam lanes hook ci-gate",
|
||||
"aliases": [
|
||||
"pre-push-gate",
|
||||
"tests",
|
||||
@@ -109,6 +113,7 @@
|
||||
"label": "E2e on feature branch",
|
||||
"icon": "🧪",
|
||||
"gate": false,
|
||||
"command": "ccam lanes up --qc",
|
||||
"aliases": [
|
||||
"e2e",
|
||||
"e2e-scoped",
|
||||
@@ -136,6 +141,7 @@
|
||||
"label": "Code review",
|
||||
"icon": "👀",
|
||||
"gate": true,
|
||||
"command": "/superpowers:requesting-code-review",
|
||||
"aliases": [
|
||||
"reviewing",
|
||||
"code-review",
|
||||
@@ -164,6 +170,7 @@
|
||||
"label": "Browser QC",
|
||||
"icon": "🔍",
|
||||
"gate": true,
|
||||
"command": "ccam lanes proof-link",
|
||||
"aliases": [],
|
||||
"detect": [
|
||||
{
|
||||
@@ -181,6 +188,7 @@
|
||||
"label": "Senior GO/NO-GO gate",
|
||||
"icon": "🚦",
|
||||
"gate": true,
|
||||
"command": "/superpowers:verification-before-completion",
|
||||
"aliases": [
|
||||
"sr-gate",
|
||||
"verify",
|
||||
@@ -203,6 +211,7 @@
|
||||
"label": "Publish PR",
|
||||
"icon": "🔀",
|
||||
"gate": false,
|
||||
"command": "/superpowers:finishing-a-development-branch",
|
||||
"aliases": [
|
||||
"push"
|
||||
],
|
||||
@@ -222,6 +231,7 @@
|
||||
"label": "PR open",
|
||||
"icon": "🔀",
|
||||
"gate": false,
|
||||
"command": "gh pr create --base development",
|
||||
"aliases": [
|
||||
"ship",
|
||||
"pr",
|
||||
@@ -247,6 +257,7 @@
|
||||
"label": "Watching PR",
|
||||
"icon": "👁",
|
||||
"gate": false,
|
||||
"command": "ccam lanes ci status",
|
||||
"aliases": [
|
||||
"pr-comment-fix"
|
||||
],
|
||||
|
||||
+11
-1
@@ -40,6 +40,16 @@ function loadAll() {
|
||||
label: n.label || n.id,
|
||||
icon: n.icon || "",
|
||||
gate: !!n.gate,
|
||||
// The one command that drives THIS node — a slash command
|
||||
// (`/superpowers:writing-plans`) or a shell one (`ccam lanes hook
|
||||
// ci-gate`), mirroring whatever the node's own `detect` rules watch
|
||||
// for. `doc.skill` above names the driver for the whole pipeline;
|
||||
// this narrows it to the step, so a reader of the pipeline map can
|
||||
// see what actually moves each node instead of inferring it from a
|
||||
// regex. Empty for a node with no single driver (`done`, or a gate
|
||||
// another agent declares). Never executed by the dashboard — it is
|
||||
// display text, same contract as `doc.skill`.
|
||||
command: typeof n.command === "string" ? n.command : "",
|
||||
aliases: Array.isArray(n.aliases) ? n.aliases : [],
|
||||
detect: Array.isArray(n.detect) ? n.detect : [],
|
||||
}));
|
||||
@@ -122,7 +132,7 @@ function nodeStates(pipeline, lane) {
|
||||
else if (rec) state = rec.evidence ? "done" : "passed-no-evidence";
|
||||
else if (cur > -1 && i < cur) state = "passed-no-evidence";
|
||||
else state = "pending";
|
||||
return { id: n.id, label: n.label, icon: n.icon, gate: n.gate, state };
|
||||
return { id: n.id, label: n.label, icon: n.icon, gate: n.gate, command: n.command, state };
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
@@ -192,6 +192,7 @@ router.get("/pipeline-stats", (req, res) => {
|
||||
label: n.label,
|
||||
icon: n.icon,
|
||||
gate: n.gate,
|
||||
command: n.command,
|
||||
entered: 0,
|
||||
passed: 0,
|
||||
withEvidence: 0,
|
||||
|
||||
Reference in New Issue
Block a user