refactor: finish the AgentHub rename and drop the MCP server

Two leftovers from the rebrand, done together because they touch the same docs and manifests. **Data directory.** `agent-dashboard` could not simply be renamed in the source: it names a real directory holding the live SQLite database. Startup now moves it once, via `migrateLegacyDataDir()` in `server/lib/claude-home.js` — a same-filesystem rename, so it is instant even at multiple gigabytes and cannot leave two divergent copies. `getDataDir()` stays PURE and resolves to the legacy path until the move happens; the first version of this put the rename inside the getter, which meant `npm run test:server` relocated the developer's real database as a side effect. The call sits behind `require.main === module` and ahead of the router requires, because those pull in db.js, which opens SQLite at module load. A failed rename is silent and the old directory keeps being used: an unfashionable directory name beats a blank database beside an unreachable one. Same treatment for the port-discovery file (`.agent-dashboard.json` → `.agenthub.json`, old one dropped on write). Not renamed on purpose: the Sagi localStorage keys (renaming silently resets everyone's prefs) and the PWA manifest `id` (changing it orphans an installed app). **MCP server.** 4 tool calls in 46 days across 577,132 events, against 4,556 lines of TypeScript, a 2 MB committed build artifact, and a pre-commit guard that had already blocked commits twice. Deleted: `mcp/`, the maintainer skills and `mcp-reviewer` agent, the build check, `plugins/agenthub/.mcp.json`, `docs/MCP.md`, 12 npm scripts, 5 Makefile targets, and every doc section describing it. Kept, because they are unrelated things sharing the name: the Config Explorer's MCP tab and its API, per-lane Playwright MCP, the agenthub-config plugin's MCP audit, and the historical `mcp__plugin_agenthub_*` events that analytics must keep attributing. Verified: server 1432/1432, client 459/459, tsc clean, prettier clean. Both directions of the migration proven — a sandbox-HOME test run leaves the legacy directory untouched, and a real boot moves it with its contents intact.
2026-09-08 09:48:40 +07:00
parent 11dcc04ac4
commit c7dbaf2d9f
210 changed files with 405 additions and 59408 deletions
@@ -1,21 +0,0 @@
---
-name: mcp-maintainer
-description: Operate and maintain the local MCP server for this repository. Use for MCP tool updates, policy-guard changes, host configuration, and MCP runtime troubleshooting.
---
-
-# MCP Maintainer Skill
-
-## Workflow
- Confirm dashboard API availability (`/api/health`).
- Inspect affected MCP domain modules under `mcp/src/tools/domains/`.
- Preserve safety gates in `mcp/src/policy/tool-guards.ts`.
- Validate with `npm run mcp:typecheck` and `npm run mcp:build`.
-
-## Safety rules
- Keep loopback-only target checks enabled.
- Keep mutating and destructive tools behind explicit flags.
- Do not log protocol data to stdout.
-
-## References
- `references/tool-domain-map.md`
- `references/operations-runbook.md`
@@ -1,4 +0,0 @@
-interface:
-  display_name: "MCP Maintainer"
-  short_description: "Maintain MCP tools, policy gates, and host integration."
-  default_prompt: "Use mcp-maintainer to update MCP tooling safely and verify runtime integrity."
@@ -1,14 +0,0 @@
-# MCP Operations Runbook
-
-## Modes
- Read-only:
-  - `MCP_DASHBOARD_ALLOW_MUTATIONS=false`
-  - `MCP_DASHBOARD_ALLOW_DESTRUCTIVE=false`
- Admin:
-  - Set mutations true for controlled maintenance operations.
- Destructive:
-  - Set both true and require `confirmation_token = CLEAR_ALL_DATA`.
-
-## Verification
- `npm run mcp:typecheck`
- `npm run mcp:build`
@@ -1,8 +0,0 @@
-# MCP Tool Domain Map
-
- `observability-tools.ts`: health, stats, analytics, snapshots, export.
- `session-tools.ts`: list/get/create/update sessions.
- `agent-tools.ts`: list/get/create/update agents.
- `event-tools.ts`: event listing and hook ingestion.
- `pricing-tools.ts`: pricing CRUD and cost calculations.
- `maintenance-tools.ts`: cleanup, reimport, reinstall hooks, destructive clear.
@@ -14,7 +14,6 @@ description: Run release-readiness checks for this repository. Use when validati
 ## Focus areas
 - Hook flow and failure behavior.
 - Session/agent lifecycle semantics.
- MCP safety gates and host setup instructions.
 - Troubleshooting accuracy.

 ## References
@@ -1,7 +1,7 @@
 # Release Checklist

 - Commands in docs exist in root `package.json`.
- Validation steps are documented for backend, frontend, and MCP.
+- Validation steps are documented for backend and frontend.
 - Behavior-changing diffs mention migration/compatibility impacts.
 - Safety-sensitive operations remain guarded by explicit flags.
 - Troubleshooting sections reflect the current architecture.
@@ -7,14 +7,13 @@ description: Understand this repository quickly before making changes. Use for a

 ## Workflow
 - Read `AGENTS.md`, `README.md`, and `ARCHITECTURE.md`.
- Determine target layer: `server/`, `client/`, `mcp/`, or docs.
+- Determine target layer: `server/`, `client/`, or docs.
 - Identify the minimal file set needed for the task.
 - Select verification commands before editing.

 ## Verification defaults
 - Backend: `npm run test:server`
 - Frontend: `npm run test:client`
- MCP: `npm run mcp:typecheck` and `npm run mcp:build`

 ## References
 - `references/module-map.md`
@@ -6,4 +6,3 @@
 - `server/websocket.js`: live update broadcast path.
 - `client/src/pages/`: route-level UI.
 - `client/src/components/`: reusable UI primitives.
- `mcp/src/tools/domains/`: MCP tool families.
@@ -4,8 +4,5 @@
  - `npm run test:server`
 - Frontend changes:
  - `npm run test:client`
- MCP changes:
-  - `npm run mcp:typecheck`
-  - `npm run mcp:build`
 - Docs-only changes:
  - validate command consistency against root `package.json`