refactor: finish the AgentHub rename and drop the MCP server

Two leftovers from the rebrand, done together because they touch the same
docs and manifests.

**Data directory.** `agent-dashboard` could not simply be renamed in the
source: it names a real directory holding the live SQLite database. Startup
now moves it once, via `migrateLegacyDataDir()` in `server/lib/claude-home.js`
— a same-filesystem rename, so it is instant even at multiple gigabytes and
cannot leave two divergent copies. `getDataDir()` stays PURE and resolves to
the legacy path until the move happens; the first version of this put the
rename inside the getter, which meant `npm run test:server` relocated the
developer's real database as a side effect. The call sits behind
`require.main === module` and ahead of the router requires, because those pull
in db.js, which opens SQLite at module load. A failed rename is silent and the
old directory keeps being used: an unfashionable directory name beats a blank
database beside an unreachable one. Same treatment for the port-discovery file
(`.agent-dashboard.json` → `.agenthub.json`, old one dropped on write).

Not renamed on purpose: the Sagi localStorage keys (renaming silently resets
everyone's prefs) and the PWA manifest `id` (changing it orphans an installed
app).

**MCP server.** 4 tool calls in 46 days across 577,132 events, against 4,556
lines of TypeScript, a 2 MB committed build artifact, and a pre-commit guard
that had already blocked commits twice. Deleted: `mcp/`, the maintainer skills
and `mcp-reviewer` agent, the build check, `plugins/agenthub/.mcp.json`,
`docs/MCP.md`, 12 npm scripts, 5 Makefile targets, and every doc section
describing it.

Kept, because they are unrelated things sharing the name: the Config
Explorer's MCP tab and its API, per-lane Playwright MCP, the agenthub-config
plugin's MCP audit, and the historical `mcp__plugin_agenthub_*` events that
analytics must keep attributing.

Verified: server 1432/1432, client 459/459, tsc clean, prettier clean. Both
directions of the migration proven — a sandbox-HOME test run leaves the legacy
directory untouched, and a real boot moves it with its contents intact.

scripts/check-mcp-build.js

@@ -1,107 +0,0 @@
-#!/usr/bin/env node
-/**
- * @file check-mcp-build.js
- * @description `mcp/build/` is committed so a plugin install has a working MCP
- * server the instant the session opens — Claude Code starts plugin MCP servers
- * immediately and offers no "not ready yet" retry, so an async bootstrap cannot
- * win that race. The cost is that the artifact can drift from `mcp/src`.
- *
- * Freshness is tracked by hashing the CONTENT of `mcp/src` (plus the manifests
- * and tsconfig) into `mcp/build/.srchash`. Modification times are useless here:
- * a fresh clone or checkout stamps every file with the same time in arbitrary
- * order.
- *
- * Run by the pre-commit hook and by `/agenthub-doctor`.
- * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
- */
-
-const fs = require("fs");
-const path = require("path");
-const crypto = require("crypto");
-
-const HASH_FILE = ".srchash";
-
-/** Every file whose content the build depends on, in a stable order. */
-function sourceFiles(mcpDir) {
-  const files = [];
-  const walk = (dir) => {
-    let entries;
-    try {
-      entries = fs
-        .readdirSync(dir, { withFileTypes: true })
-        .sort((a, b) => (a.name < b.name ? -1 : 1));
-    } catch {
-      return;
-    }
-    for (const e of entries) {
-      const full = path.join(dir, e.name);
-      if (e.isDirectory()) walk(full);
-      else files.push(full);
-    }
-  };
-  walk(path.join(mcpDir, "src"));
-  for (const f of ["package.json", "package-lock.json", "tsconfig.json"]) {
-    const full = path.join(mcpDir, f);
-    if (fs.existsSync(full)) files.push(full);
-  }
-  return files;
-}
-
-function sourceHash(root = path.resolve(__dirname, "..")) {
-  const mcpDir = path.join(root, "mcp");
-  const h = crypto.createHash("sha256");
-  for (const f of sourceFiles(mcpDir)) {
-    h.update(path.relative(mcpDir, f).replace(/\\/g, "/"));
-    h.update(fs.readFileSync(f));
-  }
-  return h.digest("hex");
-}
-
-/**
- * @returns {{ok:boolean, reason:string, expected:string, recorded:string|null}}
- */
-function mcpBuildStatus(root = path.resolve(__dirname, "..")) {
-  const buildDir = path.join(root, "mcp", "build");
-  const expected = sourceHash(root);
-  if (!fs.existsSync(path.join(buildDir, "index.js"))) {
-    return { ok: false, reason: "mcp/build/index.js is missing", expected, recorded: null };
-  }
-  let recorded = null;
-  try {
-    recorded = fs.readFileSync(path.join(buildDir, HASH_FILE), "utf8").trim();
-  } catch {
-    return { ok: false, reason: "mcp/build has no recorded source hash", expected, recorded: null };
-  }
-  return recorded === expected
-    ? { ok: true, reason: "up to date", expected, recorded }
-    : {
-        ok: false,
-        reason: "mcp/build is stale — mcp/src has changed since it was built",
-        expected,
-        recorded,
-      };
-}
-
-/** Stamp the current source hash into the build directory. */
-function writeHash(root = path.resolve(__dirname, "..")) {
-  const buildDir = path.join(root, "mcp", "build");
-  fs.mkdirSync(buildDir, { recursive: true });
-  fs.writeFileSync(path.join(buildDir, HASH_FILE), sourceHash(root) + "\n", "utf8");
-}
-
-if (require.main === module) {
-  if (process.argv.includes("--write")) {
-    writeHash();
-    console.log("mcp/build/.srchash updated");
-  } else {
-    const status = mcpBuildStatus();
-    if (status.ok) {
-      console.log("mcp/build is up to date");
-    } else {
-      console.error(`${status.reason}\nRun: npm run mcp:build`);
-      process.exitCode = 1;
-    }
-  }
-}
-
-module.exports = { sourceHash, mcpBuildStatus, writeHash };

scripts/expand-ts-module-docs.py

@@ -2,7 +2,7 @@
 """
 expand-ts-module-docs.py — append rich TSDoc blocks to TypeScript modules (comments only).
 
-Used to deepen in-file documentation for client, MCP, and desktop packages without
+Used to deepen in-file documentation for the client and desktop packages without
 changing runtime behavior. Idempotent: skips files that already contain MODULE_GUIDE.
 
 @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
@@ -53,11 +53,6 @@ def topic_blurb(path: Path) -> str:
             "Route-level screen mounted by `App.tsx`; fetches scoped REST data, subscribes "
             "to WebSocket deltas via `eventBus`, and renders inside `Layout`."
         )
-    if path.parts[0:2] == ("mcp", "src"):
-        hints.append(
-            "Part of the local MCP server (`npm run mcp:start`) that exposes dashboard "
-            "operations as MCP tools for Claude Code and other hosts."
-        )
     if path.parts[0:2] == ("desktop", "src"):
         hints.append(
             "Electron main/preload process code for the packaged desktop app — embeds the "
@@ -99,7 +94,7 @@ def topic_blurb(path: Path) -> str:
         )
     if not hints:
         hints.append(
-            "Dashboard module consumed by the React client, MCP tools, or desktop shell "
+            "Dashboard module consumed by the React client or the desktop shell "
             "depending on deployment mode."
         )
     return " ".join(hints)
@@ -170,7 +165,6 @@ def build_guide(path: Path, source: str) -> str:
             " * ## Testing pointers",
             " * - Prefer colocated `__tests__` with Vitest + Testing Library for UI.",
             " * - Server contract changes require `npm run test:server` and OpenAPI sync.",
-            " * - MCP edits: `npm run mcp:typecheck` and `npm run mcp:build`.",
             " *",
             " * ## Related docs",
             " * - `ARCHITECTURE.md` — hooks → API → SQLite → WebSocket → UI pipeline.",

scripts/plugin-bootstrap.js

@@ -13,7 +13,7 @@
  * reboots without Claude Code being opened first; otherwise a detached spawn
  * scoped to this session, same as before.
  *
- * Everything writable lives under `~/.claude/agent-dashboard/runtime/` — NOT in
+ * Everything writable lives under `~/.claude/agenthub/runtime/` — NOT in
  * the plugin cache, which Claude Code garbage-collects and replaces wholesale
  * on every plugin update.
  * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
@@ -416,7 +416,7 @@ function log(rt, line) {
  * clone on every session. `/agenthub-update` (`--force`) retries.
  *
  * Best-effort throughout. Nothing here may throw or block: the dashboard,
- * hooks, CLI and MCP all work without these plugins.
+ * hooks and CLI all work without these plugins.
  *
  * @returns {"off"|"nothing-missing"|"installed"|"failed"|"error"} or the previously
  *   recorded outcome when this run had nothing to settle.
@@ -499,10 +499,7 @@ function bootstrap(rt = runtimeDir(), { force = false } = {}) {
       logPath: path.join(rt, "client-build.log"),
     });
     if (uiResult === "failed") {
-      log(
-        rt,
-        "dashboard UI build failed — API and MCP tools still work; run /agenthub-open to retry"
-      );
+      log(rt, "dashboard UI build failed — the API still works; run /agenthub-open to retry");
     } else if (uiResult === "built") {
       log(rt, "built the dashboard UI bundle");
     }

scripts/plugin-doctor.js

@@ -4,8 +4,7 @@
  * @description Reports the health of a plugin-installed AgentHub: Node version,
  * bootstrap state, runtime dependencies, server liveness, duplicate hook
  * entries (the one failure that silently doubles every token and cost figure),
- * the `agenthub` CLI launcher and its PATH, whether the committed MCP build still
- * matches `mcp/src`, and whether the slash commands the pipeline templates name
+ * the `agenthub` CLI launcher and its PATH, and whether the slash commands the pipeline templates name
  * as node drivers are actually resolvable (the `superpowers` plugin, today).
  * Read-only — it diagnoses, it never repairs.
  * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
@@ -17,7 +16,6 @@ const path = require("path");
 
 const boot = require("./plugin-bootstrap");
 const { getSettingsPath, getDataDir } = require("../server/lib/claude-home");
-const { mcpBuildStatus } = require("./check-mcp-build");
 
 const PLUGIN_ROOT = path.resolve(__dirname, "..");
 
@@ -85,13 +83,6 @@ function diagnose() {
   add(...cliStatus());
   add(...skillPluginStatus());
 
-  const mcp = mcpBuildStatus(PLUGIN_ROOT);
-  add(
-    mcp.ok ? "ok" : "fail",
-    "MCP build",
-    mcp.ok ? "matches mcp/src" : `${mcp.reason} — run npm run mcp:build`
-  );
-
   const dist = process.env.DASHBOARD_CLIENT_DIST || path.join(rt, "client-dist");
   add(
     fs.existsSync(path.join(dist, "index.html")) ? "ok" : "warn",
@@ -104,7 +95,7 @@ function diagnose() {
 
 /**
  * WARN (never FAIL) when a plugin the pipelines depend on cannot be resolved:
- * the dashboard, hooks, CLI and MCP all work without it — only the pipeline
+ * the dashboard, hooks and CLI all work without it — only the pipeline
  * skills that drive it stop partway, so this must not fail a doctor run.
  *
  * The requirement derivation and the missing/satisfied rules live in

scripts/plugin-open.js

@@ -4,7 +4,7 @@
  * @description Builds the dashboard UI bundle for a plugin install and prints
  * the dashboard URL. `scripts/plugin-bootstrap.js` calls `buildClient` eagerly
  * on session start, so client-only routes (e.g. `/run`) work the moment
- * `claude` is started, not just the API and MCP tools. `/agenthub-open` re-runs
+ * `claude` is started, not just the API. `/agenthub-open` re-runs
  * this standalone — a no-op when the bundle already matches — as a fallback
  * for `--force` rebuilds or a first build that failed during bootstrap, and it
  * re-runs bootstrap first when the live server belongs to a retired plugin root
@@ -92,7 +92,7 @@ if (require.main === module) {
 
   const result = buildClient({ force: process.argv.includes("--force") });
   if (result === "failed") {
-    console.error("Client build failed — the API and MCP tools still work.");
+    console.error("Client build failed — the API still works.");
     process.exitCode = 1;
   } else {
     if (result === "built") console.log("Dashboard UI built.");

scripts/postinstall.js

@@ -5,9 +5,9 @@
  * root, install the React client's dependencies too, so a single root install
  * yields a buildable/runnable tree (the client's fonts and build deps live in
  * `client/package.json`). The step is a safe no-op when the `client/` workspace
- * is absent — production/Docker stages that copy only the root manifest, the
- * MCP image's `file:..` link, and the published tarball all install without a
- * client checkout, and must not fail here. Skipped entirely under
+ * is absent — production/Docker stages that copy only the root manifest and
+ * the published tarball both install without a client checkout, and must not
+ * fail here. Skipped entirely under
  * `npm install --ignore-scripts` (run `cd client && npm install` manually then).
  * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
  */
@@ -19,7 +19,7 @@ const path = require("path");
 const clientDir = path.join(__dirname, "..", "client");
 const clientManifest = path.join(clientDir, "package.json");
 
-// No client checkout in this context (Docker server/MCP stages, packed tarball,
+// No client checkout in this context (Docker server stages, packed tarball,
 // server-only installs). Nothing to do — succeed quietly so the parent install
 // is not broken.
 if (!fs.existsSync(clientManifest)) {