diff --git a/client/src/components/UpdateNotifier.tsx b/client/src/components/UpdateNotifier.tsx index ed4908cf..fe39819e 100644 --- a/client/src/components/UpdateNotifier.tsx +++ b/client/src/components/UpdateNotifier.tsx @@ -260,9 +260,8 @@ export function UpdateNotifier() { // poll that reloads the page keep running, and a failure re-opens it. const closeForNow = useCallback(() => { if (!dismissKey) return; - if (applying || restarting) toast.info(t("backgroundNote")); setClosedKey(dismissKey); - }, [applying, restarting, dismissKey, t]); + }, [dismissKey]); const dismiss = useCallback(() => { if (busy || !dismissKey) return; diff --git a/client/src/components/settings/GitIdentitySettings.tsx b/client/src/components/settings/GitIdentitySettings.tsx index 6dd208ba..4337bf54 100644 --- a/client/src/components/settings/GitIdentitySettings.tsx +++ b/client/src/components/settings/GitIdentitySettings.tsx @@ -79,14 +79,6 @@ function Step({ n, children }: { n: number; children: ReactNode }) { ); } -function Code({ children }: { children: ReactNode }) { - return ( - - {children} - - ); -} - type Key = NonNullable[number]; type SshUser = NonNullable[number]; @@ -642,10 +634,6 @@ export function GitIdentitySettings() { onRemove={() => removeKey("ed25519")} > {t("gitIdentity.gitHubStepAdd")} - - {t("gitIdentity.gitHubStepClone")} - git clone git@github.com:<org>/<repo>.git - {namedOf("ed25519").map((k) => { const rows = rowsOf(otherRows, k); @@ -668,11 +656,6 @@ export function GitIdentitySettings() { {id.writable && rows.length === 0 && ( saveGitHost(host, k)} /> )} - {rows.map((r) => ( - - git clone ssh://{r.alias ?? r.host}/<org>/<repo>.git - - ))} ); @@ -720,16 +703,6 @@ export function GitIdentitySettings() { )} - {rows.length > 0 && ( -
- {t("gitIdentity.awsReady")} - {rows.map((r) => ( - - git clone ssh://{r.alias ?? r.host}/v1/repos/<repo> - - ))} -
- )} ); })} diff --git a/client/src/components/settings/__tests__/GitIdentitySettings.test.tsx b/client/src/components/settings/__tests__/GitIdentitySettings.test.tsx index bf961e58..e5c7dbd9 100644 --- a/client/src/components/settings/__tests__/GitIdentitySettings.test.tsx +++ b/client/src/components/settings/__tests__/GitIdentitySettings.test.tsx @@ -156,7 +156,6 @@ describe("GitIdentitySettings", () => { await userEvent.click(within(aws).getByRole("button", { name: "Save" })); expect(api.gitIdentity.setSshUser).toHaveBeenCalledWith({ host: H, user: "APKA1" }); expect(await within(aws).findByText("eu-west-1 · APKA1 · Any key")).toBeInTheDocument(); - expect(within(aws).getByText(`git clone ssh://${H}/v1/repos/`)).toBeInTheDocument(); // A CodeCommit host never shows up again under "other hosts". expect(screen.queryByText(`APKA1@${H}`)).toBeNull(); await userEvent.click(within(aws).getByRole("button", { name: `Delete ${H}` })); @@ -260,7 +259,6 @@ describe("GitIdentitySettings", () => { expect( await within(prod).findByText("aws-2 · ap-southeast-1 · APKA2 · aws-2") ).toBeInTheDocument(); - expect(within(prod).getByText("git clone ssh://aws-2/v1/repos/")).toBeInTheDocument(); // The default key's card does not list the named key's login. const def = screen.getByRole("region", { name: "AWS CodeCommit" }); expect(within(def).queryByText(/APKA2/)).toBeNull(); @@ -301,7 +299,7 @@ describe("GitIdentitySettings", () => { key: "id_ed25519_git-2", }); expect( - await within(work).findByText("git clone ssh://git-2//.git") + await within(work).findByText("ssh://git-2/ → git@github.com") ).toBeInTheDocument(); }); }); diff --git a/client/src/i18n/locales/en/settings.json b/client/src/i18n/locales/en/settings.json index 54c81377..d6e7cbea 100644 --- a/client/src/i18n/locales/en/settings.json +++ b/client/src/i18n/locales/en/settings.json @@ -884,7 +884,6 @@ "gitHubTitle": "GitHub · GitLab · Gitea · Bitbucket", "gitHubSub": "ED25519 key — the git@… SSH address", "gitHubStepAdd": "Add it to your account on the host: GitHub → Settings → SSH and GPG keys → New SSH key. GitLab: Preferences → SSH Keys. Paste the whole line.", - "gitHubStepClone": "Clone with the SSH address the repository page shows:", "awsTitle": "AWS CodeCommit", "awsSub": "RSA 4096 key — AWS accepts only RSA", "stepCopy": "Copy the public key.", @@ -894,7 +893,6 @@ "awsRegion": "Region", "awsSave": "Save", "awsSaved": "SSH key ID saved for {{region}}", - "awsReady": "Ready. Clone with the plain address CodeCommit shows — in a terminal or in Add workspace → Clone:", "otherTitle": "Other SSH hosts (advanced)", "otherHint": "Only for a host that logs you in with a user name other than git. Then a plain ssh:///… address logs in as that user.", "otherHost": "Host", diff --git a/client/src/i18n/locales/en/updates.json b/client/src/i18n/locales/en/updates.json index dc91979e..9ae81d35 100644 --- a/client/src/i18n/locales/en/updates.json +++ b/client/src/i18n/locales/en/updates.json @@ -36,7 +36,6 @@ "autoFixHint": "Open a Claude Code session in the install folder with this error, so an AI agent fixes it and finishes the update.", "autoFixWorkspace": "AgentHub update", "autoFixError": "Could not start the Auto fix session", - "backgroundNote": "The update keeps running in the background — the page reloads itself when the new version is up.", "chipTitle": "Updating to {{version}}…", "chipHint": "The update runs in the background — click to show it", "pluginStep.marketplace_update": "Step {{index}}/{{total}}: refreshing the marketplace", diff --git a/client/src/i18n/locales/vi/settings.json b/client/src/i18n/locales/vi/settings.json index 04e4d005..af7db481 100644 --- a/client/src/i18n/locales/vi/settings.json +++ b/client/src/i18n/locales/vi/settings.json @@ -872,7 +872,6 @@ "gitHubTitle": "GitHub · GitLab · Gitea · Bitbucket", "gitHubSub": "Key ED25519 — địa chỉ SSH dạng git@…", "gitHubStepAdd": "Thêm vào tài khoản trên host: GitHub → Settings → SSH and GPG keys → New SSH key. GitLab: Preferences → SSH Keys. Dán nguyên dòng.", - "gitHubStepClone": "Clone bằng địa chỉ SSH mà trang repository hiển thị:", "awsTitle": "AWS CodeCommit", "awsSub": "Key RSA 4096 — AWS chỉ nhận RSA", "stepCopy": "Copy public key.", @@ -882,7 +881,6 @@ "awsRegion": "Region", "awsSave": "Lưu", "awsSaved": "Đã lưu SSH key ID cho {{region}}", - "awsReady": "Sẵn sàng. Clone bằng địa chỉ trơn mà CodeCommit hiển thị — trong terminal hoặc Add workspace → Clone:", "otherTitle": "Host SSH khác (nâng cao)", "otherHint": "Chỉ dùng cho host đăng nhập bằng tên user khác git. Sau khi lưu, địa chỉ ssh:///… trơn sẽ đăng nhập bằng user đó.", "otherHost": "Host", diff --git a/client/src/i18n/locales/vi/updates.json b/client/src/i18n/locales/vi/updates.json index 65394c0f..1f14806f 100644 --- a/client/src/i18n/locales/vi/updates.json +++ b/client/src/i18n/locales/vi/updates.json @@ -36,7 +36,6 @@ "autoFixHint": "Mở một phiên Claude Code trong thư mục cài đặt kèm lỗi này, để AI agent sửa và hoàn tất cập nhật.", "autoFixWorkspace": "Cập nhật AgentHub", "autoFixError": "Không mở được phiên Tự sửa", - "backgroundNote": "Bản cập nhật vẫn chạy ngầm — trang sẽ tự tải lại khi phiên bản mới sẵn sàng.", "chipTitle": "Đang cập nhật lên {{version}}…", "chipHint": "Bản cập nhật đang chạy ngầm — bấm để xem", "pluginStep.marketplace_update": "Bước {{index}}/{{total}}: làm mới marketplace",