feat(skills): run every judging stage in a fresh-context subagent
The session that writes the code is the worst judge of it: it believes the code is correct and remembers the reasoning its tests are meant to challenge. Split the pipelines along a judge/do boundary — the driving session implements, runs the mechanical gates, publishes and applies fixes; every stage whose job is to judge the work is dispatched to a subagent with an EMPTY context. ship-feature-lane: - New hard rule: plan debate (0b), unit tests (1b), e2e (3), code review (4), browser QC (6) and the senior gate (7) run in fresh-context agents. `subagent_type: fork` is forbidden for these — a fork inherits the implementing session's context, which is the bias being escaped. - New Stage 1b: an independent agent writes the unit tests the implementation is missing (test files only, no weakening existing tests) and returns UNIT-TESTS: PASS/FAIL. A FAIL is fixed in the source, never in the test. - Stage 3 delegates the e2e run + triage (the poll/timeout discipline moves into the agent's brief); Stage 4 delegates the code-review skill run. - Stages 6/7 keep their agents but may no longer be primed with the driving session's context, conclusions or known-issue list. - Stage 10: CI still red on the same job after a fix goes to a fresh agent — calling your own failure a flake twice pushes a real defect past the gate. - Fix-loop: a re-entry touching non-test source re-runs Stage 1b first. ship-feature: same boundary for the plan, tests, review and gate phases. docs/LANES.md updated to match.
This commit is contained in:
+4
-2
@@ -1070,7 +1070,9 @@ The lane card shows a lock badge when the lane **holds** a named lock (its `lane
|
||||
|
||||
## The ship-feature-lane skill (E1)
|
||||
|
||||
The **ship-feature-lane** skill is the ported Shipyard driving skill for autonomous end-to-end feature pipelines in a single CCAM lane. It coordinates the entire development flow: implementation (TDD) → pre-push CI gates + dev preflight → e2e testing → code review → local QC → senior gate authorization → PR push and publication → CI watch → final report.
|
||||
The **ship-feature-lane** skill is the ported Shipyard driving skill for autonomous end-to-end feature pipelines in a single CCAM lane. It coordinates the entire development flow: implementation (TDD) → independent unit tests → pre-push CI gates + dev preflight → e2e testing → code review → local QC → senior gate authorization → PR push and publication → CI watch → final report.
|
||||
|
||||
**Every stage whose job is to judge the work runs in a fresh-context subagent, never in the driving session.** The plan debate (Stage 0b), unit tests (Stage 1b), the e2e run and its triage (Stage 3), code review (Stage 4), browser QC (Stage 6), the senior gate (Stage 7), and a re-triage of CI that stayed red after a fix (Stage 10) are each dispatched with the Agent tool to a subagent that starts with an empty context and receives only artifacts it can verify itself — working directory, lane spec, diff range, commands, and the other agents' reports verbatim, never the driving session's paraphrase of why a finding was fine. The stages the driving session keeps are the ones that *do* rather than judge: intake, implementation, the mechanical gates, publishing, the CI/PR watch, and applying every fix the judges ask for. `subagent_type: fork` is explicitly forbidden for these: a fork inherits the implementing session's context, so it inherits the belief that the code is already correct. The driving session implements and applies fixes; it never grades its own work. Stages 1b/3/4 use the generic `general-purpose`/`Code Reviewer` types (nothing to install); Stages 6/7 use the lane-installed `qc-local`/`senior-gate-reviewer` agents.
|
||||
|
||||
### Installing the skill (once per machine)
|
||||
|
||||
@@ -1094,7 +1096,7 @@ The skill frontloads all clarifying questions once, then runs unattended. The on
|
||||
### Current status: stages 0–8, 10–12, 14 work; stages 9, 13 deferred; stages 6–7 agent-gated
|
||||
|
||||
**Stages implemented now:**
|
||||
- **0-8**: Intake & frontloaded Q&A → plan → implementation → gates+preflight → e2e on feature branch → code review → QC plan → publish PR
|
||||
- **0-8**: Intake & frontloaded Q&A → plan → implementation → independent unit tests (1b) → gates+preflight → e2e on feature branch → code review → QC plan → QC → senior gate → publish PR
|
||||
- **10-12**: CI watch on the PR → report → watch PR until merge (gated fix-loop re-entries on review feedback)
|
||||
- **14**: Done
|
||||
|
||||
|
||||
Reference in New Issue
Block a user