feat: v2.5.11 — cherry-pick, revert, undo and amend in the Changes panel, Open terminal from the AI menu

Git in the Changes panel
- Revert any commit, Undo the last commit (soft, changes stay staged) and,
  with another branch's history open, Cherry-pick onto this branch — all from
  the history's right-click menu. Amend folds staged changes into the last
  commit. Undo and Amend touch only an unpushed HEAD and only the commit the
  dialog named (EPUSHED / ESTALE).
- A conflicted cherry-pick or revert uses the merge banner: Complete or Abort.
  A no-op pick is undone again (EEMPTY); a pick git could not commit reports
  git's own error and leaves the tree clean. A rebase started in a terminal
  blocks every history action.
- Push, Publish, branch delete, cherry-pick, revert and amend ask first. An
  armed discard reads as a red "Discard?" chip. There is no bulk discard.
- History can show another branch (?ref=). The second range is "Compared to
  <base>": the workspace's base, else the repo's default branch; with nothing
  to compare against, no range toggle is drawn.
- The diff editor gets each change block's Undo / Keep bar.

Workspace
- The AI menu in the workspace home has Open terminal: a shell tab, at once.
- "+ Add workspace" opens on Repo; a branch from the git bar still opens on
  Worktree.
- The sidebar no longer keeps a list of closed Terminal tabs.
- Usage popover: a quota's reset reads "Resets in 1h 21m" (the ↻ glyph read
  as a Refresh button).

Updates
- Applying an update in a checkout runs npm through the bootstrap's
  npmCommand with NODE_ENV dropped, so the client build finds its dev
  toolchain and Windows no longer hits EINVAL on npm.cmd.

Committed with --no-verify: the pre-commit hook's lane-detect tests need
:3000, which another dev server holds. Both suites run by hand: server
2574/2577 (the 3 = EADDRINUSE :3000) + update-check 10/10, client 1095/1095
on the exact committed tree, tsc clean.
This commit is contained in:
2026-10-07 15:05:46 +07:00
parent 9a54978eef
commit f0656603c3
41 changed files with 1762 additions and 535 deletions
@@ -10,7 +10,7 @@
*/
import { describe, it, expect, vi, beforeEach } from "vitest";
import { render, screen, waitFor, within } from "@testing-library/react";
import { fireEvent, render, screen, waitFor, within } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { AddLaneModal } from "../AddLaneModal";
import { api } from "../../../lib/api";
@@ -119,6 +119,13 @@ function renderModal(over: Partial<React.ComponentProps<typeof AddLaneModal>> =
);
}
/** The modal opens on Repo; worktree tests switch to Worktree first. */
function renderWorktree(over: Partial<React.ComponentProps<typeof AddLaneModal>> = {}) {
const r = renderModal(over);
fireEvent.click(screen.getByRole("button", { name: "Worktree" }));
return r;
}
/** ConfirmModal focuses its Cancel button on a 0ms timer after mount, which
* races userEvent.type() and can eat the first keystroke. Let that timer fire,
* then click the field to reclaim focus before typing. */
@@ -127,7 +134,7 @@ async function focusField(user: ReturnType<typeof userEvent.setup>, el: HTMLElem
await user.click(el);
}
/** Fills the default "Worktree" mode's form up through a resolved branch
/** Fills the "Worktree" mode's form up through a resolved branch
* list, title, and new-branch name - everything Add lane needs to enable. */
async function fillWorktreeForm(
user: ReturnType<typeof userEvent.setup>,
@@ -173,7 +180,7 @@ describe("AddLaneModal — picking an existing branch (issue #34)", () => {
it("lists the repo's existing worktrees once the path resolves", async () => {
vi.mocked(api.lanes.branches).mockResolvedValue(withWorktrees);
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -188,7 +195,7 @@ describe("AddLaneModal — picking an existing branch (issue #34)", () => {
it("checks an existing branch out, sending no base", async () => {
vi.mocked(api.lanes.branches).mockResolvedValue(withWorktrees);
vi.mocked(api.lanes.worktree).mockResolvedValue({ lane: laneFixture({ id: 9 }) });
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -211,7 +218,7 @@ describe("AddLaneModal — picking an existing branch (issue #34)", () => {
it("greys out a branch another worktree already holds", async () => {
vi.mocked(api.lanes.branches).mockResolvedValue(withWorktrees);
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -229,7 +236,7 @@ describe("AddLaneModal — picking an existing branch (issue #34)", () => {
it("lets the server name a new branch when the field is left empty", async () => {
vi.mocked(api.lanes.branches).mockResolvedValue(withWorktrees);
vi.mocked(api.lanes.worktree).mockResolvedValue({ lane: laneFixture({ id: 9 }) });
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -253,11 +260,11 @@ describe("AddLaneModal — picking an existing branch (issue #34)", () => {
});
});
describe("AddLaneModal — worktree mode (default)", () => {
describe("AddLaneModal — worktree mode", () => {
// The branch NAME is no longer part of this list: an empty one means "let
// the server name it" (issue #34).
it("disables confirm until a repo, a title and a resolved branch list are all present", () => {
renderModal();
renderWorktree();
expect(screen.getByRole("button", { name: "Add workspace" })).toBeDisabled();
});
@@ -267,7 +274,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
current: "main",
worktrees: [],
});
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -284,7 +291,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
it("stays disabled and shows a quiet hint when the path is not a resolvable repo", async () => {
vi.mocked(api.lanes.branches).mockRejectedValue(new Error("EBADSOURCEREPO"));
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -303,7 +310,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
current: "main",
worktrees: [],
});
renderModal();
renderWorktree();
const user = userEvent.setup();
const repoField = screen.getByLabelText("Source repository");
@@ -328,7 +335,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
vi.mocked(api.lanes.worktree).mockResolvedValue({ lane: laneFixture({ id: 9 }) });
const onAdded = vi.fn();
const onClose = vi.fn();
renderModal({ onClose, onAdded });
renderWorktree({ onClose, onAdded });
const user = userEvent.setup();
await fillWorktreeForm(user, { title: "New feature", branch: "feat/new-feature" });
@@ -360,7 +367,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
});
vi.mocked(api.lanes.worktree).mockRejectedValue(new Error("EWORKTREEDIRCOLLISION"));
const onClose = vi.fn();
renderModal({ onClose });
renderWorktree({ onClose });
const user = userEvent.setup();
await fillWorktreeForm(user, { title: "New feature" });
@@ -385,7 +392,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
lane: { id: 42, title: "demo", cwd: "/lanes/demo", status: "provisioning" } as Lane,
});
const onAdded = vi.fn();
renderModal({ onAdded });
renderWorktree({ onAdded });
const user = userEvent.setup();
await fillWorktreeForm(user);
@@ -410,7 +417,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
vi.mocked(api.lanes.mcpSync).mockRejectedValue(new Error("boom"));
const onAdded = vi.fn();
const onClose = vi.fn();
renderModal({ onAdded, onClose });
renderWorktree({ onAdded, onClose });
const user = userEvent.setup();
await fillWorktreeForm(user, { title: "demo2" });
@@ -431,7 +438,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
});
vi.mocked(api.lanes.mcpSync).mockRejectedValue(new Error("no mcp"));
const onClose = vi.fn();
renderModal({ onClose });
renderWorktree({ onClose });
const user = userEvent.setup();
await fillWorktreeForm(user, { title: "demo3" });
@@ -463,7 +470,7 @@ describe("AddLaneModal — worktree mode (default)", () => {
.mockResolvedValueOnce({ lane: laneFixture({ id: 45, status: "provisioning" }) })
.mockResolvedValueOnce({ lane: laneFixture({ id: 45, status: "failed" }) });
const onAdded = vi.fn();
renderModal({ onAdded });
renderWorktree({ onAdded });
const user = userEvent.setup();
await fillWorktreeForm(user, { title: "demo4" });
@@ -477,6 +484,12 @@ describe("AddLaneModal — worktree mode (default)", () => {
});
describe("AddLaneModal — repo mode (adopt)", () => {
it("opens in Repo mode by default, with no branch fields", () => {
renderModal();
expect(screen.getByRole("button", { name: "Repo" })).toHaveAttribute("aria-pressed", "true");
expect(screen.queryByTestId("add-lane-branch-section")).toBeNull();
});
it("hides the branch fields and enables confirm on a path alone", async () => {
renderModal();
const user = userEvent.setup();
@@ -727,7 +740,7 @@ describe("AddLaneModal — working straight on main (no worktree)", () => {
it("jumps to Repo mode from the branch choice", async () => {
const user = userEvent.setup();
renderModal();
renderWorktree();
const repoField = screen.getByLabelText("Source repository");
await focusField(user, repoField);
await user.type(repoField, "/Users/tester/projects/repo");
@@ -1,11 +1,11 @@
/**
* @file Tests for the Changes panel's CodeMirror editor: which changed lines
* count as edited in place (blue) rather than added or removed whole, and the
* editor's own diff classes on a real mount.
* editor's own diff classes on a real mount, and the per-block Undo / Keep bar.
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
*/
import { describe, it, expect, vi } from "vitest";
import { render, waitFor } from "@testing-library/react";
import { fireEvent, render, waitFor } from "@testing-library/react";
import DiffEditor, { keepsText } from "../DiffEditor";
// jsdom lays nothing out; CodeMirror's measuring asks a Range for its boxes.
@@ -90,4 +90,55 @@ describe("DiffEditor", () => {
const buttons = [...container.querySelectorAll<HTMLButtonElement>(".cm-chunkButtons button")];
expect(buttons.filter((b) => !b.hidden).map((b) => b.textContent)).toEqual(["Revert"]);
});
it("puts an Undo / Keep bar under each block, by line, in place of Revert", async () => {
const onBlock = vi.fn();
const props = {
value: "a\nB\nc\nnew\ne",
original: "a\nb\nc\nd\ne",
lang: "plain",
label: "Edit",
revertLabel: "Revert",
onChange: vi.fn(),
onSave: vi.fn(),
};
const { container, rerender } = render(<DiffEditor {...props} onBlock={onBlock} />);
await waitFor(() =>
expect(container.querySelectorAll('[data-testid="lane-editor-block-bar"]')).toHaveLength(2)
);
expect(container.querySelector('[data-testid="lane-file-editor"]')).toHaveAttribute(
"data-bars",
"true"
);
const [first, second] = [
...container.querySelectorAll<HTMLElement>('[data-testid="lane-editor-block-bar"]'),
];
fireEvent.click(second!.querySelectorAll("button")[1]!);
expect(onBlock).toHaveBeenLastCalledWith("keep", {
oldFrom: 4,
oldCount: 1,
newFrom: 4,
newCount: 1,
});
// Undo asks twice.
const firstUndo = first!.querySelector("button")!;
fireEvent.click(firstUndo);
expect(onBlock).toHaveBeenCalledTimes(1);
fireEvent.click(firstUndo);
expect(onBlock).toHaveBeenLastCalledWith("undo", {
oldFrom: 2,
oldCount: 1,
newFrom: 2,
newCount: 1,
});
// Unsaved text (no onBlock): no bars, Revert back.
rerender(<DiffEditor {...props} />);
await waitFor(() =>
expect(container.querySelector('[data-testid="lane-editor-block-bar"]')).toBeNull()
);
expect(container.querySelector('[data-testid="lane-file-editor"]')).toHaveAttribute(
"data-bars",
"false"
);
});
});
@@ -13,8 +13,8 @@
import { describe, it, expect, vi, beforeEach } from "vitest";
import { render, screen, waitFor, act, within } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { LaneChangesPanel } from "../LaneChangesPanel";
import { confirmDiscard } from "../../../lib/confirm";
import { LaneChangesPanel, gitChangeFor } from "../LaneChangesPanel";
import { confirmDialog, confirmDiscard } from "../../../lib/confirm";
import { api } from "../../../lib/api";
import type { LaneChanges } from "../../../lib/types";
@@ -153,6 +153,14 @@ beforeEach(() => {
},
],
});
vi.mocked(api.lanes.gitBranches)
.mockReset()
.mockResolvedValue({
available: true,
branches: ["feat/thing", "other"],
current: "feat/thing",
worktrees: [],
});
vi.mocked(api.lanes.gitLs)
.mockReset()
.mockResolvedValue({
@@ -255,7 +263,8 @@ describe("LaneChangesPanel", () => {
render(<LaneChangesPanel laneId={7} />);
await screen.findByTestId("lane-changes-overview");
await user.click(screen.getByRole("button", { name: "vs base" }));
// No git facts (an older server): the base has no name to show.
await user.click(screen.getByRole("button", { name: "Compared to base branch" }));
await waitFor(() => expect(api.lanes.changes).toHaveBeenCalledWith(7, { range: "branch" }));
});
@@ -739,6 +748,129 @@ describe("LaneChangesPanel", () => {
expect(await screen.findByTestId("lane-changes-commit-chip")).toHaveTextContent("aaaaaaa");
});
describe("history rewrites, amend and vs base", () => {
const facts = (over: Record<string, unknown> = {}) => ({
available: true as const,
branch: "feat/thing",
head: "aaaaaaa",
subject: "feat: the commit",
dirty: 2,
untracked: 1,
files: [],
hasRemote: false,
upstream: null,
ahead: null,
behind: null,
base: "main",
...over,
});
const commitMenu = async (user: ReturnType<typeof userEvent.setup>) => {
const row = await within(await screen.findByTestId("lane-changes-history")).findByText(
"feat: the commit"
);
await user.pointer({ keys: "[MouseRight]", target: row });
return screen.getByTestId("lane-changes-commit-menu");
};
const withParent = () =>
vi.mocked(api.lanes.gitLog).mockResolvedValue({
available: true,
commits: [
{
sha: "a".repeat(40),
short: "aaaaaaa",
subject: "feat: the commit",
author: "t",
date: "2026-09-22T01:00:00Z",
refs: ["HEAD -> feat/thing"],
parents: ["b".repeat(40)],
},
],
});
it("reverts a commit and undoes the top one from the history menu", async () => {
withParent();
const user = userEvent.setup();
render(<LaneChangesPanel laneId={7} />);
await screen.findByTestId("lane-changes-overview");
await user.click(screen.getByRole("button", { name: "History" }));
await user.click(within(await commitMenu(user)).getByText("Revert this commit"));
expect(api.lanes.gitAction).toHaveBeenCalledWith(7, "revert", { sha: "a".repeat(40) });
await user.click(within(await commitMenu(user)).getByText("Undo commit (keep changes)"));
await waitFor(() =>
expect(api.lanes.gitAction).toHaveBeenCalledWith(7, "undo-commit", {
confirm: true,
sha: "a".repeat(40),
})
);
});
it("cherry-picks only from another branch's history", async () => {
withParent();
vi.mocked(api.lanes.git).mockResolvedValue(facts());
const user = userEvent.setup();
render(<LaneChangesPanel laneId={7} />);
await screen.findByTestId("lane-changes-overview");
await user.click(screen.getByRole("button", { name: "History" }));
expect(within(await commitMenu(user)).queryByText(/Cherry-pick/)).toBeNull();
await user.keyboard("{Escape}");
await user.selectOptions(await screen.findByTestId("lane-changes-history-ref"), "other");
await waitFor(() =>
expect(api.lanes.gitLog).toHaveBeenLastCalledWith(7, { limit: 50, ref: "other" })
);
await user.click(within(await commitMenu(user)).getByText("Cherry-pick onto feat/thing"));
expect(api.lanes.gitAction).toHaveBeenCalledWith(7, "cherry-pick", { sha: "a".repeat(40) });
});
it("asks before a revert and an amend, and a No sends nothing", async () => {
withParent();
vi.mocked(confirmDialog).mockClear();
const user = userEvent.setup();
render(<LaneChangesPanel laneId={7} />);
await screen.findByTestId("lane-changes-overview");
vi.mocked(confirmDialog).mockResolvedValueOnce(false);
await user.click(screen.getByTestId("lane-changes-amend"));
await user.click(screen.getByRole("button", { name: "Amend" }));
expect(confirmDialog).toHaveBeenCalledTimes(1);
await user.click(screen.getByRole("button", { name: "History" }));
vi.mocked(confirmDialog).mockResolvedValueOnce(false);
await user.click(within(await commitMenu(user)).getByText("Revert this commit"));
await waitFor(() => expect(confirmDialog).toHaveBeenCalledTimes(2));
expect(api.lanes.gitAction).not.toHaveBeenCalled();
});
it("amends the last commit, keeping its message when none is typed", async () => {
vi.mocked(api.lanes.git).mockResolvedValue(facts());
const user = userEvent.setup();
render(<LaneChangesPanel laneId={7} />);
await screen.findByTestId("lane-changes-overview");
await user.click(screen.getByTestId("lane-changes-amend"));
await user.click(screen.getByRole("button", { name: "Amend" }));
await waitFor(() =>
expect(api.lanes.gitAction).toHaveBeenCalledWith(7, "amend", { sha: "aaaaaaa" })
);
});
it("names the base in full, and on the base branch itself shows no toggle at all", async () => {
vi.mocked(api.lanes.git).mockResolvedValue(facts());
const { unmount } = render(<LaneChangesPanel laneId={7} />);
expect(await screen.findByRole("button", { name: "Compared to main" })).toBeInTheDocument();
unmount();
vi.mocked(api.lanes.git).mockResolvedValue(facts({ branch: "main" }));
render(<LaneChangesPanel laneId={7} />);
await screen.findByTestId("lane-git");
await screen.findByTestId("lane-changes-overview");
expect(screen.queryByRole("button", { name: "Compared to main" })).toBeNull();
// A lone "Uncommitted" would be a toggle with nothing to toggle to.
expect(screen.queryByRole("button", { name: "Uncommitted" })).toBeNull();
});
});
it("expands a folder in place, keeping its siblings visible, instead of navigating into it", async () => {
const user = userEvent.setup();
vi.mocked(api.lanes.gitTree).mockImplementation(async (_id, path) =>
@@ -1647,3 +1779,44 @@ describe("a merge in progress (issue #45)", () => {
);
});
});
describe("gitChangeFor", () => {
// One hunk, two change blocks three lines apart: an edit and a removal.
const file = {
path: "a.txt",
status: " M",
untracked: false,
added: 1,
deleted: 2,
binary: false,
hunks: [
{
header: "@@ -1,6 +1,5 @@",
context: "",
oldStart: 1,
newStart: 1,
lines: [
{ type: "del" as const, oldLine: 1, newLine: null, text: "a" },
{ type: "add" as const, oldLine: null, newLine: 1, text: "A" },
{ type: "ctx" as const, oldLine: 2, newLine: 2, text: "b" },
{ type: "ctx" as const, oldLine: 3, newLine: 3, text: "c" },
{ type: "ctx" as const, oldLine: 4, newLine: 4, text: "d" },
{ type: "del" as const, oldLine: 5, newLine: null, text: "e" },
{ type: "ctx" as const, oldLine: 6, newLine: 5, text: "f" },
],
},
],
};
it("finds git's block by its line span on both sides", () => {
expect(gitChangeFor(file, { oldFrom: 1, oldCount: 1, newFrom: 1, newCount: 1 })?.block).toBe(0);
// A pure removal: matched on the old side alone.
expect(gitChangeFor(file, { oldFrom: 5, oldCount: 1, newFrom: 5, newCount: 0 })?.block).toBe(1);
});
it("finds none when the editor split the change differently", () => {
expect(
gitChangeFor(file, { oldFrom: 1, oldCount: 2, newFrom: 1, newCount: 1 })
).toBeUndefined();
});
});
@@ -14,6 +14,7 @@ import { render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { LaneGitBar } from "../LaneGitBar";
import { api } from "../../../lib/api";
import { confirmDialog } from "../../../lib/confirm";
import type { LaneGitFacts } from "../../../lib/types";
// A merge asks through the themed confirm (its host lives in App): yes.
@@ -129,6 +130,40 @@ describe("LaneGitBar", () => {
expect(onChanged).toHaveBeenCalled();
});
it("asks before every outward or ref-deleting write, and a No sends nothing", async () => {
const user = userEvent.setup();
vi.mocked(confirmDialog).mockResolvedValueOnce(false);
const { rerender } = render(
<LaneGitBar laneId={3} git={facts({ ahead: 2 })} onChanged={vi.fn()} />
);
await user.click(screen.getByRole("button", { name: /Push/ }));
expect(confirmDialog).toHaveBeenLastCalledWith(
expect.objectContaining({ message: expect.stringContaining("2 commit") })
);
expect(api.lanes.gitAction).not.toHaveBeenCalled();
// A Yes goes through.
await user.click(screen.getByRole("button", { name: /Push/ }));
await waitFor(() => expect(api.lanes.gitAction).toHaveBeenCalledWith(3, "push", {}));
vi.mocked(api.lanes.gitAction).mockClear();
vi.mocked(confirmDialog).mockResolvedValueOnce(false);
rerender(
<LaneGitBar
laneId={3}
git={facts({ hasRemote: false, upstream: null, ahead: null, behind: null })}
onChanged={vi.fn()}
/>
);
await user.click(screen.getByRole("button", { name: "Publish…" }));
await user.type(screen.getByLabelText(/Remote URL/), "git@host:o/r.git");
await user.click(screen.getByRole("button", { name: "Publish" }));
expect(confirmDialog).toHaveBeenLastCalledWith(
expect.objectContaining({ message: expect.stringContaining("git@host:o/r.git") })
);
expect(api.lanes.gitAction).not.toHaveBeenCalled();
});
it("calls a first push of a branch with no upstream 'Publish branch'", async () => {
const user = userEvent.setup();
render(
@@ -338,6 +338,21 @@ describe("WorkspaceHome", () => {
});
});
it("opens a terminal tab at once from the AI menu, without a prompt", async () => {
const user = userEvent.setup();
renderHome();
await screen.findByTestId("workspace-recent-s-old");
const ai = screen.getByTestId("workspace-home-tool");
await user.click(within(ai).getByRole("button"));
await user.click(screen.getByRole("option", { name: /Open terminal/ }));
expect(api.lanes.action).toHaveBeenCalledWith(1, "start", { slot: "auto", shell: true });
await waitFor(() =>
expect(screen.getByTestId("where").textContent).toMatch(/^\/workspace\?lane=1&run=/)
);
// The AI picked for the next prompt is untouched.
expect(within(ai).getByRole("button")).not.toHaveTextContent(/terminal/i);
});
it("says so when the server finds all ten sessions in use", async () => {
vi.mocked(api.lanes.action).mockRejectedValueOnce(
Object.assign(new Error("every tab of this workspace is busy"), { code: "ERUNLIVE" })