03f1673fce
- Workspace, SettingsHub, SessionDetail and the Workflow sub-tab are lazy (main bundle 2,166 kB -> ~920 kB), wrapped in RouteErrorBoundary: a stale chunk after a self-update reloads once (vite:preloadError too), any other error shows a Reload panel instead of a blank page. - Live refresh: lib/throttle.ts + hooks/useLiveRefresh.ts replace trailing debounces that froze under a steady event stream; refresh skips hidden tabs and refetches after a WebSocket reconnect. Monitor loads only while shown, with one batched GET /api/agents?session_ids= instead of N+1; a failing endpoint is an inline error, not a blank Dashboard. - NeedsYouStrip on Monitor and above Analytics. Tabs, filters, page, sort and search live in the URL (Dashboard, Sessions, Activity, SessionDetail). - Sessions: tool / workspace / date-range filters, CSV/JSON export (formula-neutralised), focusable row links, Open in workspace (the dead /run links are gone), stale responses dropped, error + Retry. - Fixes: "NaNs" durations, 30/7-day charts skipping idle days, weekday labels west of UTC (now averages), cache hit rate denominator, billable tokens vs cache reads, exact tool-call counts, "To" date = end of day, invalid ?from= no longer throws, recent list no longer shrinks to 15, stable message keys, transcript switch races. - Light-theme-unreadable bg-black code panels and dark-only DAG fills use tokens; status configs and chart colours use theme tokens; Health tab and other literals translated. - Server (additive): GET /api/agents?session_ids=, GET /api/sessions awaiting=1&from=&to=, stats tool_call_count/distinct_tool_count, event rows carry session/agent labels.
368 lines
13 KiB
TypeScript
368 lines
13 KiB
TypeScript
/**
|
|
* @file AgentCard.test.tsx
|
|
* @description Unit tests for the AgentCard component, which displays information about an agent in the application. The tests cover rendering of agent details such as name, status, subagent type, task, and current tool, as well as interaction handling like click events. The tests use React Testing Library and Vitest for assertions and mocking.
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
import { describe, it, expect, vi } from "vitest";
|
|
import { render, screen, fireEvent, within } from "@testing-library/react";
|
|
// render is used inside renderCard helper
|
|
import { MemoryRouter, Route, Routes, useLocation } from "react-router-dom";
|
|
import userEvent from "@testing-library/user-event";
|
|
import { AgentCard } from "../AgentCard";
|
|
import type { Agent } from "../../lib/types";
|
|
import { formatModelName, fmtCost } from "../../lib/format";
|
|
|
|
function renderCard(element: JSX.Element) {
|
|
return render(<MemoryRouter>{element}</MemoryRouter>);
|
|
}
|
|
|
|
function makeAgent(overrides: Partial<Agent> = {}): Agent {
|
|
return {
|
|
id: "agent-1",
|
|
session_id: "sess-1",
|
|
name: "Main Agent",
|
|
type: "main",
|
|
subagent_type: null,
|
|
status: "working",
|
|
task: null,
|
|
current_tool: null,
|
|
started_at: "2026-03-05T10:00:00.000Z",
|
|
ended_at: null,
|
|
updated_at: "2026-03-05T10:00:00.000Z",
|
|
parent_agent_id: null,
|
|
metadata: null,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("AgentCard", () => {
|
|
it("should render agent name", () => {
|
|
renderCard(<AgentCard agent={makeAgent({ name: "Test Agent" })} />);
|
|
expect(screen.getByText("Test Agent")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should render status badge", () => {
|
|
renderCard(<AgentCard agent={makeAgent({ status: "working" })} />);
|
|
expect(screen.getByText("Working")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should render subagent_type when present", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
type: "subagent",
|
|
subagent_type: "Explore",
|
|
})}
|
|
/>
|
|
);
|
|
expect(screen.getByText("Explore")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should show the subagent's own model from metadata, not the session model (issue #185)", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
type: "subagent",
|
|
subagent_type: "qa",
|
|
metadata: JSON.stringify({ model: "claude-haiku-4-5-20251001" }),
|
|
})}
|
|
// Session is Opus, but the subagent card must read Haiku from metadata.
|
|
session={
|
|
{
|
|
id: "sess-1",
|
|
name: "S",
|
|
status: "active",
|
|
cwd: "/x",
|
|
model: "claude-opus-4-8",
|
|
} as never
|
|
}
|
|
/>
|
|
);
|
|
// Subtitle is the subagent type + project (cwd); the model badge shows the
|
|
// subagent's OWN model.
|
|
expect(screen.getByText("qa · x")).toBeInTheDocument();
|
|
expect(screen.getByText(formatModelName("claude-haiku-4-5-20251001")!)).toBeInTheDocument();
|
|
// The Opus session model must NOT appear on a subagent card.
|
|
expect(screen.queryByText(formatModelName("claude-opus-4-8")!)).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("main agent subtitle shows project + subagent count, with the model only once (#185)", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "main", name: "Main" })}
|
|
session={
|
|
{
|
|
id: "s",
|
|
name: "S",
|
|
status: "active",
|
|
cwd: "/Users/dev/proj",
|
|
model: "claude-opus-4-8",
|
|
agent_count: 4,
|
|
metadata: JSON.stringify({ turn_count: 12 }),
|
|
} as never
|
|
}
|
|
/>
|
|
);
|
|
// Subtitle: project basename + SUBAGENT count + turn count (model excluded).
|
|
// agent_count includes the main agent itself, so 4 agents => 3 subagents.
|
|
// Showing subagents (not agents) reconciles the card with the "Active
|
|
// Subagents" dashboard stat, which excludes main agents.
|
|
expect(screen.getByText("proj · 3 subagents · 12 turns")).toBeInTheDocument();
|
|
// The model appears exactly once — in the footer badge, not duplicated in
|
|
// the subtitle the way main cards used to.
|
|
expect(screen.getAllByText(formatModelName("claude-opus-4-8")!)).toHaveLength(1);
|
|
});
|
|
|
|
it("shows a subagent's OWN cost, not the session total (avoids misleading spend)", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "subagent", subagent_type: "qa", cost: 3.5 })}
|
|
session={
|
|
{
|
|
id: "s",
|
|
name: "S",
|
|
status: "active",
|
|
cwd: "/x",
|
|
model: "claude-opus-4-8",
|
|
cost: 646.5,
|
|
} as never
|
|
}
|
|
/>
|
|
);
|
|
expect(screen.getByText(fmtCost(3.5))).toBeInTheDocument();
|
|
// The session total must NOT appear on a subagent card.
|
|
expect(screen.queryByText(fmtCost(646.5))).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("shows the session total on a main-agent card", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "main" })}
|
|
session={
|
|
{
|
|
id: "s",
|
|
name: "S",
|
|
status: "active",
|
|
cwd: "/x",
|
|
model: "claude-opus-4-8",
|
|
cost: 646.5,
|
|
} as never
|
|
}
|
|
/>
|
|
);
|
|
expect(screen.getByText(fmtCost(646.5))).toBeInTheDocument();
|
|
});
|
|
|
|
it("shows no cost on a subagent card with no recorded usage", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "subagent", subagent_type: "qa" })}
|
|
session={{ id: "s", name: "S", status: "active", cwd: "/x", cost: 646.5 } as never}
|
|
/>
|
|
);
|
|
expect(screen.queryByText(fmtCost(646.5))).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("swaps the real session title into the hook-style placeholder (Session <id8>)", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "main", name: "Main Agent - Session 329c4d24" })}
|
|
session={{ id: "s", name: "Resumable runs UI", status: "active" } as never}
|
|
/>
|
|
);
|
|
expect(screen.getByText("Main Agent - Resumable runs UI")).toBeInTheDocument();
|
|
});
|
|
|
|
it("swaps the real session title into the import-style placeholder (<folder> - <id8>)", () => {
|
|
// Regression: imported / background-synced main agents are named
|
|
// "Main Agent - <cwd-folder> - <id8>", which the old Session-only regex
|
|
// could not rewrite, so they kept showing "work - e3f8e613" forever even
|
|
// though the session title was known.
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "main", name: "Main Agent - work - e3f8e613" })}
|
|
session={
|
|
{ id: "s", name: "Implement in-process libdocs MCP server", status: "active" } as never
|
|
}
|
|
/>
|
|
);
|
|
expect(
|
|
screen.getByText("Main Agent - Implement in-process libdocs MCP server")
|
|
).toBeInTheDocument();
|
|
expect(screen.queryByText("Main Agent - work - e3f8e613")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("keeps the placeholder when the session name is still auto-generated", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({ type: "main", name: "Main Agent - work - e3f8e613" })}
|
|
session={{ id: "s", name: "Session e3f8e613", status: "active" } as never}
|
|
/>
|
|
);
|
|
// "Session <id8>" is suppressed as a non-name, so nothing to swap in.
|
|
expect(screen.getByText("Main Agent - work - e3f8e613")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should not render subagent_type when null", () => {
|
|
const { container } = renderCard(<AgentCard agent={makeAgent({ subagent_type: null })} />);
|
|
// Only the name should be in the name container, no subagent type
|
|
expect(container.querySelectorAll(".text-\\[11px\\].text-fg-muted.truncate")).toHaveLength(0);
|
|
});
|
|
|
|
it("should render task when present", () => {
|
|
renderCard(<AgentCard agent={makeAgent({ task: "Searching for patterns" })} />);
|
|
expect(screen.getByText("Searching for patterns")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should not render task when null", () => {
|
|
renderCard(<AgentCard agent={makeAgent({ task: null })} />);
|
|
expect(screen.queryByText("Searching for patterns")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("should render current_tool when present", () => {
|
|
renderCard(<AgentCard agent={makeAgent({ current_tool: "Bash", status: "working" })} />);
|
|
expect(screen.getByText("Bash")).toBeInTheDocument();
|
|
});
|
|
|
|
it("should not render current_tool when null", () => {
|
|
renderCard(<AgentCard agent={makeAgent({ current_tool: null })} />);
|
|
expect(screen.queryByText("Bash")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("should apply active border for working agents", () => {
|
|
const { container } = renderCard(<AgentCard agent={makeAgent({ status: "working" })} />);
|
|
const card = container.querySelector(".card-hover");
|
|
expect(card?.className).toContain("border-l-2");
|
|
});
|
|
|
|
it("should apply yellow border for waiting agents even without awaiting_input_since", () => {
|
|
const { container } = renderCard(<AgentCard agent={makeAgent({ status: "waiting" })} />);
|
|
const card = container.querySelector(".card-hover");
|
|
expect(card?.className).toContain("border-l-2");
|
|
expect(card?.className).toContain("border-l-status-warning/60");
|
|
});
|
|
|
|
it("should not apply active border for completed agents", () => {
|
|
const { container } = renderCard(<AgentCard agent={makeAgent({ status: "completed" })} />);
|
|
const card = container.querySelector(".card-hover");
|
|
expect(card?.className).not.toContain("border-l-2");
|
|
});
|
|
|
|
it("should call onClick when clicked", () => {
|
|
const onClick = vi.fn();
|
|
renderCard(<AgentCard agent={makeAgent()} onClick={onClick} />);
|
|
fireEvent.click(screen.getByText("Main Agent"));
|
|
expect(onClick).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("renders waiting badge and yellow accent when awaiting_input_since is set", () => {
|
|
const { container } = renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
status: "waiting",
|
|
awaiting_input_since: "2026-03-05T10:01:00.000Z",
|
|
})}
|
|
/>
|
|
);
|
|
expect(screen.getByText("Waiting")).toBeInTheDocument();
|
|
const card = container.querySelector(".card-hover");
|
|
expect(card?.className).toContain("border-l-status-warning/60");
|
|
});
|
|
|
|
it("keeps the card badge compact: reason is tooltip-only, no inline chip", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
status: "waiting",
|
|
awaiting_input_since: "2026-03-05T10:01:00.000Z",
|
|
awaiting_reason: "notification",
|
|
})}
|
|
/>
|
|
);
|
|
expect(screen.getByText("Waiting")).toBeInTheDocument();
|
|
// Cards are narrow — the inline chip would squeeze the title, so the
|
|
// reason must NOT render inline here (hover tooltip only).
|
|
expect(screen.queryByText("Needs input")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("degrades to a plain Waiting badge on an unknown awaiting_reason", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
status: "waiting",
|
|
awaiting_input_since: "2026-03-05T10:01:00.000Z",
|
|
awaiting_reason: "some_future_reason",
|
|
})}
|
|
/>
|
|
);
|
|
expect(screen.getByText("Waiting")).toBeInTheDocument();
|
|
expect(screen.queryByText("Needs input")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("ignores awaiting_input_since once the agent has completed", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
status: "completed",
|
|
awaiting_input_since: "2026-03-05T10:01:00.000Z",
|
|
ended_at: "2026-03-05T10:02:00.000Z",
|
|
})}
|
|
/>
|
|
);
|
|
expect(screen.getByText("Completed")).toBeInTheDocument();
|
|
expect(screen.queryByText("Waiting")).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("should show duration for completed agents with ended_at", () => {
|
|
renderCard(
|
|
<AgentCard
|
|
agent={makeAgent({
|
|
status: "completed",
|
|
started_at: "2026-03-05T10:00:00.000Z",
|
|
ended_at: "2026-03-05T10:05:30.000Z",
|
|
})}
|
|
/>
|
|
);
|
|
expect(screen.getByText(/ran 5m 30s/)).toBeInTheDocument();
|
|
});
|
|
|
|
it("right-click opens the session menu; its items act without clicking the card", async () => {
|
|
function Where() {
|
|
const loc = useLocation();
|
|
return <span data-testid="where">{loc.pathname + loc.search}</span>;
|
|
}
|
|
const onClick = vi.fn();
|
|
render(
|
|
<MemoryRouter initialEntries={["/"]}>
|
|
<Routes>
|
|
<Route
|
|
path="*"
|
|
element={
|
|
<>
|
|
<AgentCard
|
|
agent={makeAgent()}
|
|
session={{ id: "sess-1", lane_id: 4, cwd: "/r/app" } as never}
|
|
onClick={onClick}
|
|
/>
|
|
<Where />
|
|
</>
|
|
}
|
|
/>
|
|
</Routes>
|
|
</MemoryRouter>
|
|
);
|
|
const user = userEvent.setup();
|
|
await user.pointer({ keys: "[MouseRight]", target: screen.getByText("Main Agent") });
|
|
const menu = screen.getByTestId("session-row-menu-sess-1");
|
|
await user.click(within(menu).getByText("Copy folder path"));
|
|
expect(await navigator.clipboard.readText()).toBe("/r/app");
|
|
expect(onClick).not.toHaveBeenCalled();
|
|
|
|
await user.pointer({ keys: "[MouseRight]", target: screen.getByText("Main Agent") });
|
|
await user.click(screen.getByText("Open in its workspace"));
|
|
expect(screen.getByTestId("where")).toHaveTextContent("/workspace?lane=4&session=sess-1");
|
|
expect(onClick).not.toHaveBeenCalled();
|
|
});
|
|
});
|