e109d2804c
A codex session emits no hooks and rarely calls `ccam stage` on its own, so its card sat at `idle` forever while the amber "detected" badge was the only thing that ever moved. `codex-ingest.js` now advances the declared `stage` from its own written detection — the one place in CCAM where an inference moves the blue `current` ring, and only for `codex` lanes. It stays honest: gated on `recordDetection` having written (so forward-only, declared-wins and the detection TTL are inherited unchanged), passes NO evidence (the node renders `passed-no-evidence` amber, never `done`), and no template's last node carries detect rules, so a lane can never be auto-declared `done`. `setStage` grows a `keepDetection` option — its sole caller — so the detection columns survive the advance and the card keeps showing which command moved it instead of looking like an agent's own claim. Two levers then get the evidence auto-advance cannot supply: - `codex-nudge.js` now nudges on a stage held 2+ min with no evidence, instead of on a detection sitting ahead of the declared stage — after auto-advance the old condition can never fire, since the two now match. - `ccam lanes agents install` on a codex lane writes the marker-delimited `<!-- ccam:stage:start -->` block into the lane's own AGENTS.md — the one instruction channel Codex reads — instead of copying agent templates into `.claude/agents/`, which it never loads. Appended, user prose preserved, reinstall replaces exactly that block. Verified with a real `codex exec` run: stage moved to `watching-pr` with `evidence: null` and the detection signal intact. 1364 server tests pass.
143 lines
4.9 KiB
JavaScript
143 lines
4.9 KiB
JavaScript
/**
|
|
* @file Unit tests for the codex evidence safety net: nudges a live codex pane
|
|
* to run `ccam stage --evidence` when the lane has sat at an inferred (
|
|
* evidence-less) stage past the delay, without ever writing stage itself.
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
const os = require("node:os");
|
|
const path = require("node:path");
|
|
|
|
const SUITE_DB_PATH = path.join(
|
|
os.tmpdir(),
|
|
`dashboard-codex-nudge-${Date.now()}-${process.pid}.db`
|
|
);
|
|
process.env.DASHBOARD_DB_PATH = SUITE_DB_PATH;
|
|
|
|
const { describe, it, beforeEach, afterEach } = require("node:test");
|
|
const assert = require("node:assert/strict");
|
|
|
|
const { db } = require("../db");
|
|
const lanes = require("../lib/lanes");
|
|
const tmux = require("../lib/tmux");
|
|
const nudge = require("../lib/codex-nudge");
|
|
|
|
/** Backdate the current stage's enteredAt so it looks `minutes` old. */
|
|
function backdateStage(laneId, minutes) {
|
|
const lane = lanes.getLane(laneId);
|
|
const stages = { ...lane.stages };
|
|
stages[lane.stage] = {
|
|
...stages[lane.stage],
|
|
enteredAt: new Date(Date.now() - minutes * 60_000).toISOString(),
|
|
};
|
|
db.prepare("UPDATE lanes SET stages = ? WHERE id = ?").run(JSON.stringify(stages), laneId);
|
|
}
|
|
|
|
describe("codex-nudge sweep", () => {
|
|
let calls;
|
|
|
|
beforeEach(() => {
|
|
calls = [];
|
|
tmux.__setExecImpl((args) => {
|
|
calls.push(args);
|
|
if (args[0] === "display-message") return "codex"; // pane running the codex CLI
|
|
return "";
|
|
});
|
|
nudge.__resetNudgeState();
|
|
});
|
|
|
|
afterEach(() => {
|
|
tmux.__reset();
|
|
});
|
|
|
|
function makeCodexLane({ cwd, stage = "tests", evidence }) {
|
|
const lane = lanes.createLane({ title: "cx", cwd, tool: "codex" });
|
|
lanes.updateLane(lane.id, { run_id: `ccam-lane-${lane.id}` });
|
|
lanes.setStage(lane.id, { stage, evidence });
|
|
return lane;
|
|
}
|
|
|
|
it("nudges once the lane has held an evidence-less stage past the delay", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = makeCodexLane({ cwd: `${cwd}/nudge-a` });
|
|
backdateStage(lane.id, 3); // older than the 2 min delay
|
|
|
|
assert.equal(nudge.sweepCodexNudges(), 1);
|
|
const sendKeys = calls.filter((a) => a[0] === "send-keys" && a[3] === "-l");
|
|
assert.equal(sendKeys.length, 1);
|
|
assert.match(sendKeys[0][4], /ccam stage tests --tool codex --evidence/);
|
|
|
|
// A second pass for the same still-unevidenced stage must not repeat it.
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("never nudges before the delay has elapsed", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = makeCodexLane({ cwd: `${cwd}/nudge-b` });
|
|
// enteredAt is "now" — setStage just wrote it.
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("never nudges a stage the session already backed with evidence", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = makeCodexLane({ cwd: `${cwd}/nudge-c`, evidence: "12 tests green" });
|
|
backdateStage(lane.id, 10);
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("never nudges a lane that has not entered a pipeline node", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = lanes.createLane({ title: "cx", cwd: `${cwd}/nudge-h`, tool: "codex" });
|
|
lanes.updateLane(lane.id, { run_id: `ccam-lane-${lane.id}` });
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("never nudges a claude lane", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = lanes.createLane({ title: "cc", cwd: `${cwd}/nudge-d`, tool: "claude" });
|
|
lanes.updateLane(lane.id, { run_id: `ccam-lane-${lane.id}` });
|
|
lanes.setStage(lane.id, { stage: "tests" });
|
|
backdateStage(lane.id, 3);
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("never nudges a lane with no live run", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = lanes.createLane({ title: "cx", cwd: `${cwd}/nudge-e`, tool: "codex" });
|
|
lanes.setStage(lane.id, { stage: "tests" });
|
|
backdateStage(lane.id, 3);
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("never types into a pane sitting at a bare shell prompt", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = makeCodexLane({ cwd: `${cwd}/nudge-f` });
|
|
backdateStage(lane.id, 3);
|
|
tmux.__setExecImpl((args) => {
|
|
calls.push(args);
|
|
if (args[0] === "display-message") return "bash";
|
|
return "";
|
|
});
|
|
assert.equal(nudge.sweepCodexNudges(), 0);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
|
|
it("nudges again once the lane moves to another evidence-less stage", () => {
|
|
const cwd = os.tmpdir();
|
|
const lane = makeCodexLane({ cwd: `${cwd}/nudge-g` });
|
|
backdateStage(lane.id, 3);
|
|
assert.equal(nudge.sweepCodexNudges(), 1);
|
|
|
|
lanes.setStage(lane.id, { stage: "review" });
|
|
backdateStage(lane.id, 3);
|
|
assert.equal(nudge.sweepCodexNudges(), 1);
|
|
lanes.deleteLane(lane.id);
|
|
});
|
|
});
|