nntrivi2001
64017c6ca5
Run console:
- Picking a pipeline no longer pre-writes anything into the prompt box
(`promptPrefill` in `LaneConsolePane.tsx` is gone — it wrote the driving
slash command on a claude lane and a stage checklist on a codex one).
Whatever sits in that box is sent as a real prompt the moment the run
starts, so the box is the user's alone now.
- Resuming a session sends NO prompt at all (`handleStart` in `RunSetup.tsx`):
the resumed session carries its own transcript, and leftover text in the box
fired an extra turn into it.
Notifications:
- `client/src/lib/notify.ts` is now the ONE sender, used by both
`useNotifications` and Settings' test button, and it reports where the
notification landed: `POST /api/push/send` answering `{native:false,pushed:0}`
means it went NOWHERE, so the client falls back to a local notification
instead of counting the 200 as delivered.
- A notification carries the lane that raised it (`/workspace?lane=<id>`), and
Workspace selects that lane on arrival.
Profiles:
- `server/lib/cc-profiles.js` reads and writes the macOS login Keychain item
`Claude Code-credentials`, where the `claude` CLI actually keeps
`claudeAiOauth` on darwin — a switch used to rewrite a file nothing reads.
The file stays the fallback, is kept in step only when it already exists, and
`AGENTHUB_CC_KEYCHAIN=0` pins it (tests set it).
Tests: npm run test:server (1820 pass), client vitest (553 pass).
58 lines
2.1 KiB
TypeScript
58 lines
2.1 KiB
TypeScript
/**
|
|
* @file Browser-notification preferences — the single definition of the shape,
|
|
* the defaults, and the `localStorage` read/write. Settings (which edits them)
|
|
* and `useNotifications` (which obeys them) both import from here; they used to
|
|
* carry private copies, so adding a notification type meant editing the same
|
|
* literal twice and a miss went unnoticed until a toggle did nothing.
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
export const NOTIF_KEY = "agent-monitor-notifications";
|
|
|
|
export interface NotifPrefs {
|
|
/** Master switch; when false no notification fires, whatever the flags say. */
|
|
enabled: boolean;
|
|
onNewSession: boolean;
|
|
onSessionError: boolean;
|
|
/** Claude is BLOCKED on the user — a permission prompt or a question. */
|
|
onAwaitingInput: boolean;
|
|
/** Claude finished its turn and is waiting for the next prompt (`Stop`). */
|
|
onTurnComplete: boolean;
|
|
/** The whole session closed (`SessionEnd`), not just one turn. */
|
|
onSessionComplete: boolean;
|
|
onSubagentSpawn: boolean;
|
|
}
|
|
|
|
// The two "Claude is waiting for you" types default ON: they are the reason
|
|
// notifications exist (issue #29 — the user walks away during a long run and
|
|
// needs to know when they are the blocker). The rest stay as they were.
|
|
export const defaultNotifPrefs: NotifPrefs = {
|
|
enabled: false,
|
|
onNewSession: false,
|
|
onSessionError: true,
|
|
onAwaitingInput: true,
|
|
onTurnComplete: true,
|
|
onSessionComplete: false,
|
|
onSubagentSpawn: false,
|
|
};
|
|
|
|
/** Reads prefs, merged over the defaults so a stored blob written by an older
|
|
* build (missing the newer flags) still yields a complete object. */
|
|
export function loadNotifPrefs(): NotifPrefs {
|
|
try {
|
|
const raw = localStorage.getItem(NOTIF_KEY);
|
|
if (!raw) return { ...defaultNotifPrefs };
|
|
return { ...defaultNotifPrefs, ...(JSON.parse(raw) as Partial<NotifPrefs>) };
|
|
} catch {
|
|
return { ...defaultNotifPrefs };
|
|
}
|
|
}
|
|
|
|
export function saveNotifPrefs(prefs: NotifPrefs) {
|
|
try {
|
|
localStorage.setItem(NOTIF_KEY, JSON.stringify(prefs));
|
|
} catch {
|
|
/* private mode / quota — the toggle still applies for this tab */
|
|
}
|
|
}
|