ca821008e2
Measured on a copy of a real 1.2 GB / 253K-event database, 10 simulated browsers + 10 hooks/s for 90 s: event-loop delay p99 1239 ms → 32 ms (max 2.0 s → 94 ms), 266 failed requests → 0, 74 → 111 requests/s served, server RSS 633 → 346 MB. Entry bundle 975 KB raw → 394 KB (106 KB brotli). Server - /api/analytics: the events-table scans run in the read worker (scoped-stats eventAggregates, read-pool job analyticsEvents); runRead takes maxAgeMs — analytics 10 s, /api/workflows 30 s — keyed by the args - /api/workflows/skill-usage: +event_type and a tool_name range instead of LIKE, so it uses idx_events_tool (784 ms → a few ms) - idx_events_session_type_tool (session_id, event_type, tool_name, created_at) replaces idx_events_session_type: covering reads for session stats, the hook dedupes and the import resume point (1.2 s → 20 ms); 64 MB cache_size and 256 MB mmap_size on both connections - WAL: the server sets wal_autocheckpoint = 0 and checkpoints PASSIVE every DASHBOARD_WAL_CHECKPOINT_MS (5 s) from the read worker's own writable connection; a failed checkpoint restores the automatic one (hook COMMIT p95 109 ms → 15 ms at 100 hooks/s) - tmux: one list-sessions answers a whole GET /api/lanes and the heal beat (liveSessions), shared for 1 s and cleared by this process's new/kill — GET /api/run's sync spawns had blocked 60 s of a 90 s run; the heal beat skips tmux when nothing runs; attach options chained into 2 spawns - hooks: TurnDuration/APIError deduped against one read per hook instead of a query per transcript entry (23 ms/hook on a 763-turn session); one lane scan per hook; hourly upserts skip rows that did not grow; frames are sent after the transaction commits (and after the pane binding); new_event carries its row id; a split pane's (slot 1–9) hooks no longer rebind the lane's session_id - watchdog liveness probe runs ps asynchronously; transcript newline scan via indexOf; startup subagent backfill fingerprints the files it already checked - pty attach: backpressure (pause past 1 MB unsent, resume under 256 KB) - static: hashed assets served from their pre-compressed .br/.gz sibling Client - hidden tabs neither refetch on WS events nor poll (useLiveRefresh, panes, lane cards, git header, changes panel, settings); no per-tab hourly /updates/check (the server already checks) - refetch storms throttled (workspace tree/session list 3 s, /api/run only on a run-key change, notification pane lookup only when shown); WS reconnect jitter; terminal retry backoff 1.5 → 30 s, stops on 1008 - heavier throttles for aggregates (15 s) and detail views; Monitor keepIfSame; GET in-flight dedupe in request() - lazy Dashboard/History, xterm (with the first terminal), lane modals, Sagi (only while enabled); only the active locale loads; Workspace chunk prefetched on a /workspace deep link - Sagi: no work while disabled, pupil via CSS variables, memo avatar - build: .br/.gz siblings, sourcemap hidden; service worker no longer caches /assets/ (cache v3 drops the old one) Tests: scripts/test-server.js drops the GIT_DIR-family variables a hook exports, so a suite run from a linked worktree's pre-commit can no longer commit into the real repository or set core.bare. Docs: ARCHITECTURE, DATABASE, API, DEPLOYMENT, client README, docs/plans/perf/README.md (audit, checklist, results).
110 lines
4.2 KiB
JavaScript
110 lines
4.2 KiB
JavaScript
/**
|
|
* @file Tests server/lib/read-pool.js: a read job runs in the worker on its own
|
|
* connection, identical calls in flight share one run, a job over the timeout
|
|
* is refused with EREADTIMEOUT and the next one gets a fresh worker,
|
|
* AGENTHUB_READ_WORKER=0 runs the job inline, `maxAgeMs` reuses a young result,
|
|
* the analytics events job matches the main connection, and the WAL checkpoint
|
|
* runs on the worker's writable connection.
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
const { describe, it, before, after, afterEach } = require("node:test");
|
|
const assert = require("node:assert/strict");
|
|
const fs = require("fs");
|
|
const os = require("os");
|
|
const path = require("path");
|
|
|
|
const TEST_DB = path.join(os.tmpdir(), `dashboard-readpool-test-${Date.now()}-${process.pid}.db`);
|
|
process.env.DASHBOARD_DB_PATH = TEST_DB;
|
|
|
|
const { db } = require("../db");
|
|
const { runRead } = require("../lib/read-pool");
|
|
|
|
before(() => {
|
|
db.prepare("INSERT INTO sessions (id, status) VALUES ('rp-1', 'completed')").run();
|
|
const ins = db.prepare(
|
|
"INSERT INTO events (session_id, event_type, tool_name) VALUES ('rp-1', 'PreToolUse', ?)"
|
|
);
|
|
for (const t of ["Read", "Edit", "Read", "Edit"]) ins.run(t);
|
|
});
|
|
|
|
afterEach(() => {
|
|
delete process.env.AGENTHUB_READ_TIMEOUT_MS;
|
|
delete process.env.AGENTHUB_READ_WORKER;
|
|
});
|
|
|
|
after(() => {
|
|
try {
|
|
db.close();
|
|
} catch {}
|
|
for (const s of ["", "-wal", "-shm"]) fs.rmSync(TEST_DB + s, { force: true });
|
|
});
|
|
|
|
describe("read-pool", () => {
|
|
it("runs a job in the worker and sees the main connection's committed rows", async () => {
|
|
const data = await runRead("workflows", { sections: ["toolFlow"] });
|
|
assert.deepEqual(data.toolFlow.transitions.map((t) => [t.source, t.target, t.value]).sort(), [
|
|
["Edit", "Read", 1],
|
|
["Read", "Edit", 2],
|
|
]);
|
|
});
|
|
|
|
it("shares one run between identical calls in flight", async () => {
|
|
const a = runRead("workflows", { sections: ["stats"] });
|
|
const b = runRead("workflows", { sections: ["stats"] });
|
|
assert.equal(a, b);
|
|
assert.notEqual(a, runRead("workflows", { sections: ["toolFlow"] }));
|
|
await Promise.all([a, b]);
|
|
});
|
|
|
|
it("refuses a job over the timeout, then recovers with a fresh worker", async () => {
|
|
process.env.AGENTHUB_READ_TIMEOUT_MS = "1";
|
|
await assert.rejects(runRead("workflows", { tag: "slow" }), { code: "EREADTIMEOUT" });
|
|
delete process.env.AGENTHUB_READ_TIMEOUT_MS;
|
|
const data = await runRead("workflows", { sections: ["stats"] });
|
|
assert.equal(data.stats.totalSessions, 1);
|
|
});
|
|
|
|
it("reuses a result younger than maxAgeMs, and only for the same args", async () => {
|
|
const first = await runRead(
|
|
"workflows",
|
|
{ sections: ["stats"], tag: "memo" },
|
|
{ maxAgeMs: 60_000 }
|
|
);
|
|
db.prepare("INSERT INTO sessions (id, status) VALUES ('rp-2', 'completed')").run();
|
|
const again = await runRead(
|
|
"workflows",
|
|
{ sections: ["stats"], tag: "memo" },
|
|
{ maxAgeMs: 60_000 }
|
|
);
|
|
assert.equal(again, first); // the cached object, not a new run
|
|
const fresh = await runRead("workflows", { sections: ["stats"], tag: "memo" });
|
|
assert.equal(fresh.stats.totalSessions, first.stats.totalSessions + 1);
|
|
db.prepare("DELETE FROM sessions WHERE id = 'rp-2'").run();
|
|
});
|
|
|
|
it("computes the analytics events numbers in the worker like the main connection", async () => {
|
|
const { eventAggregates } = require("../lib/scoped-stats");
|
|
const args = { scope: null, range: null, tzModifier: "+0 minutes" };
|
|
const inWorker = await runRead("analyticsEvents", args);
|
|
assert.deepEqual(inWorker, eventAggregates(db, null, null, "+0 minutes"));
|
|
assert.deepEqual(inWorker.toolUsage.map((r) => [r.tool_name, r.count]).sort(), [
|
|
["Edit", 2],
|
|
["Read", 2],
|
|
]);
|
|
});
|
|
|
|
it("checkpoints the WAL from the worker", async () => {
|
|
const [row] = await runRead("walCheckpoint");
|
|
assert.equal(row.busy, 0);
|
|
assert.ok(row.log >= row.checkpointed);
|
|
});
|
|
|
|
it("runs inline with AGENTHUB_READ_WORKER=0, and rejects an unknown job", async () => {
|
|
process.env.AGENTHUB_READ_WORKER = "0";
|
|
const data = await runRead("workflows", { sections: ["stats"], tag: "inline" });
|
|
assert.equal(data.stats.topFlow.source, "Read");
|
|
await assert.rejects(runRead("nope"), { code: "EBADJOB" });
|
|
});
|
|
});
|