84e2a9f0ac
Server mode can now run each account as its own Linux user (ah-<name>) when `agenthub server install-system` has set S3 up. The dashboard reaches a member only through sudo -u / write-as / pane-launch, reads a member's files only through owner- and type-checked opens, and hooks are authenticated by peer uid. Local mode and server mode without S3 are unchanged. EXPERIMENTAL: tested with fake sudo and fake accounts only. It has not yet been verified on a real install with real member accounts, sudo or a real Codex login. Do not offer it to real users yet. - S3 core: provisioning, per-member tmux servers, the proxy key gateway, shared tools in /opt, dropped capabilities for children (P0–P5) - P4: plan and quota per member home - P6: ~/.claude.json seed; opt-in plugin baseline installed as the member; managed-settings spike script (not run) - P7: Codex account pool (`agenthub accounts add --tool codex`) - Roles merged with main's admin / analyst / developer: analysts write only their own rows, under S3 as well - Per-account prefs: one implementation (Chat UI + onboarding) - Security reviews F1–F49 (five rounds), each fix with a regression test: symlink/TOCTOU-safe member reads, no host writes in a member home, credentials and the data dir never served, owner and folder account must agree, pane tokens bound to the pane's uid, bounded sudo/tmux/git calls and member reads (no hang or crash from a member), async route rejections answer 500 instead of exiting - Docs: docs/SERVER-MODE.md (S3 model, accepted ceilings, operator runbook), docs/plans/server-mode/S3-PLAN.md, CLAUDE.md S3 rules Tests: server 2838/2841 (3 need 127.0.0.1:3000, held on this box); client 1162/1162; tsc clean; headers check passes. Co-Authored-By: Claude <noreply@anthropic.com>
79 lines
3.2 KiB
JavaScript
79 lines
3.2 KiB
JavaScript
/**
|
|
* @file Saves one text file in a lane's working tree, for the Changes panel's
|
|
* single-file editor. The one filesystem WRITE of the lane file surface, kept
|
|
* out of git-ops.js on purpose: that module only ever touches paths `git
|
|
* status` reports as changed, and an editor may save any file.
|
|
*
|
|
* The guards are the READ path's own (git-diff.js), so the editor can never
|
|
* write where the viewer could not read: a lexical `lanePath`, a realpath
|
|
* confined to the lane (no `..`, no symlink out), and no `settings.local.json`
|
|
* — where a lane's proxy key once lived — at any depth or through any symlink. On top:
|
|
* only an EXISTING, textual file within the viewer's size cap, and only over
|
|
* the exact bytes the editor loaded (`baseSha`, from `readFileAt`), so a save
|
|
* never silently overwrites what the agent wrote in the meantime (ESTALE).
|
|
* The file keeps its CRLF line endings and its final newline.
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
const fs = require("node:fs");
|
|
const {
|
|
contentSha,
|
|
isSecretOnDisk,
|
|
lanePath,
|
|
looksBinary,
|
|
resolveInLane,
|
|
MAX_FILE_VIEW_BYTES,
|
|
} = require("./git-diff");
|
|
|
|
function bad(code, message) {
|
|
return Object.assign(new Error(message), { code });
|
|
}
|
|
|
|
/**
|
|
* Overwrite `requested` in lane `dir` with `content`. Throws EBADPATH,
|
|
* ESECRET, ENOFILE, EBADCONTENT, ETOOBIG, EBINARY or ESTALE.
|
|
*/
|
|
async function writeLaneFile(dir, requested, content, baseSha) {
|
|
const file = lanePath(requested);
|
|
if (await isSecretOnDisk(dir, file)) {
|
|
throw bad("ESECRET", "that file holds secrets and is not writable here");
|
|
}
|
|
if (typeof content !== "string") throw bad("EBADCONTENT", "content must be a string");
|
|
if (typeof baseSha !== "string" || !/^[0-9a-f]{40}$/.test(baseSha)) {
|
|
throw bad("EBADCONTENT", "baseSha is required");
|
|
}
|
|
if (Buffer.byteLength(content) > MAX_FILE_VIEW_BYTES) {
|
|
throw bad("ETOOBIG", "file is too large to edit here");
|
|
}
|
|
const abs = await resolveInLane(dir, file);
|
|
|
|
let current;
|
|
try {
|
|
const stat = await fs.promises.stat(abs);
|
|
if (!stat.isFile()) throw bad("ENOFILE", "no such file in the working tree");
|
|
if (stat.size > MAX_FILE_VIEW_BYTES) throw bad("ETOOBIG", "file is too large to edit here");
|
|
current = await require("./run-as").readFileSafeAsync(abs);
|
|
} catch (err) {
|
|
if (err.code === "ETOOBIG" || err.code === "ENOFILE") throw err;
|
|
throw bad("ENOFILE", "no such file in the working tree");
|
|
}
|
|
if (looksBinary(current)) throw bad("EBINARY", "binary files are not editable here");
|
|
if (contentSha(current) !== baseSha) {
|
|
throw bad("ESTALE", "the file changed on disk since it was opened — reload it first");
|
|
}
|
|
|
|
// A browser textarea hands back LF only, and the viewer drops the final
|
|
// newline: put back what the file had, so a one-word fix is a one-line diff.
|
|
const text = current.toString("utf8");
|
|
const eol = text.includes("\r\n") ? "\r\n" : "\n";
|
|
let out = content.replace(/\r\n/g, "\n");
|
|
if (eol === "\r\n") out = out.replace(/\n/g, "\r\n");
|
|
if (text.endsWith("\n") && out && !out.endsWith(eol)) out += eol;
|
|
|
|
// As the folder's member under S3 (the dashboard reads, never writes, there).
|
|
require("./run-as").writeFileAs(abs, out);
|
|
return { path: file };
|
|
}
|
|
|
|
module.exports = { writeLaneFile };
|