84e2a9f0ac
Server mode can now run each account as its own Linux user (ah-<name>) when `agenthub server install-system` has set S3 up. The dashboard reaches a member only through sudo -u / write-as / pane-launch, reads a member's files only through owner- and type-checked opens, and hooks are authenticated by peer uid. Local mode and server mode without S3 are unchanged. EXPERIMENTAL: tested with fake sudo and fake accounts only. It has not yet been verified on a real install with real member accounts, sudo or a real Codex login. Do not offer it to real users yet. - S3 core: provisioning, per-member tmux servers, the proxy key gateway, shared tools in /opt, dropped capabilities for children (P0–P5) - P4: plan and quota per member home - P6: ~/.claude.json seed; opt-in plugin baseline installed as the member; managed-settings spike script (not run) - P7: Codex account pool (`agenthub accounts add --tool codex`) - Roles merged with main's admin / analyst / developer: analysts write only their own rows, under S3 as well - Per-account prefs: one implementation (Chat UI + onboarding) - Security reviews F1–F49 (five rounds), each fix with a regression test: symlink/TOCTOU-safe member reads, no host writes in a member home, credentials and the data dir never served, owner and folder account must agree, pane tokens bound to the pane's uid, bounded sudo/tmux/git calls and member reads (no hang or crash from a member), async route rejections answer 500 instead of exiting - Docs: docs/SERVER-MODE.md (S3 model, accepted ceilings, operator runbook), docs/plans/server-mode/S3-PLAN.md, CLAUDE.md S3 rules Tests: server 2838/2841 (3 need 127.0.0.1:3000, held on this box); client 1162/1162; tsc clean; headers check passes. Co-Authored-By: Claude <noreply@anthropic.com>
138 lines
4.5 KiB
JavaScript
138 lines
4.5 KiB
JavaScript
/**
|
|
* @file linux-accounts.js
|
|
* @description Server mode, one Linux user per account (S3 plan, P2). Each
|
|
* AgentHub user `alice` maps to the Linux user `ah-alice`, whose home is
|
|
* `<USERS_ROOT>/alice` — the same folder `scope.folderAllowed` keeps her
|
|
* workspaces in.
|
|
*
|
|
* S3 is ON when server mode is on AND `/etc/agenthub/server.conf` exists
|
|
* (written by `sudo agenthub server install-system`, root-owned). Without it
|
|
* everything here is a no-op and server mode behaves as in S2.
|
|
*
|
|
* `provision` is the dashboard's only way to create, disable or enable a Linux
|
|
* account: `sudo -n /opt/agenthub/sbin/agenthub-provision <action> <name>`,
|
|
* the one root command sudoers lets the host run. Only an action from a fixed
|
|
* set and a name that passed `LINUX_NAME_RE` ever reach its argv.
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
const fs = require("node:fs");
|
|
const path = require("node:path");
|
|
const { execFileSync } = require("node:child_process");
|
|
|
|
/** Lower case, a letter first, ≤ 29 so `ah-<name>` fits Linux's 32. */
|
|
const LINUX_NAME_RE = /^[a-z][a-z0-9_-]{0,28}$/;
|
|
const PROVISION = "/opt/agenthub/sbin/agenthub-provision";
|
|
const ACTIONS = new Set(["create", "disable", "enable"]);
|
|
|
|
const confPath = () => process.env.AGENTHUB_SERVER_CONF || "/etc/agenthub/server.conf";
|
|
|
|
// server.conf is read on every tmux call's account lookup — keep it 5 s.
|
|
let confCache = { at: 0, path: null, value: null };
|
|
|
|
/** `{hostUser, hostUid, usersRoot, port, bins}` from server.conf, or null. */
|
|
function serverConf() {
|
|
const file = confPath();
|
|
if (confCache.path === file && Date.now() - confCache.at < 5000) return confCache.value;
|
|
confCache = { at: Date.now(), path: file, value: readConf(file) };
|
|
return confCache.value;
|
|
}
|
|
|
|
function readConf(file) {
|
|
let text;
|
|
try {
|
|
text = fs.readFileSync(file, "utf8");
|
|
} catch {
|
|
return null;
|
|
}
|
|
const get = (k) => new RegExp(`^${k}=(.*)$`, "m").exec(text)?.[1]?.trim() || "";
|
|
const usersRoot = get("USERS_ROOT");
|
|
if (!path.isAbsolute(usersRoot)) return null;
|
|
return {
|
|
hostUser: get("HOST_USER"),
|
|
hostUid: Number(get("HOST_UID")),
|
|
usersRoot,
|
|
port: Number(get("PORT")) || null,
|
|
// The absolute paths sudoers lists (sudo would resolve a bare name on its
|
|
// own secure_path, which may not be them).
|
|
bins: Object.fromEntries(
|
|
[
|
|
["tmux", get("TMUX_BIN")],
|
|
["git", get("GIT_BIN")],
|
|
["gh", get("GH_BIN")],
|
|
].filter(([, v]) => path.isAbsolute(v))
|
|
),
|
|
};
|
|
}
|
|
|
|
/** Is S3 on: server mode plus an installed system layout. */
|
|
function s3Enabled() {
|
|
return require("./auth").isServerMode() && serverConf() !== null;
|
|
}
|
|
|
|
const loginFor = (username) => `ah-${username}`;
|
|
|
|
/** The Linux side of an AgentHub user, or null outside S3. */
|
|
function accountFor(username) {
|
|
const conf = s3Enabled() ? serverConf() : null;
|
|
if (!conf || !LINUX_NAME_RE.test(String(username || ""))) return null;
|
|
return { login: loginFor(username), home: path.join(conf.usersRoot, username) };
|
|
}
|
|
|
|
/** Throws EBADUSER unless `username` can be a Linux account (S3 only). */
|
|
function assertLinuxName(username) {
|
|
if (s3Enabled() && !LINUX_NAME_RE.test(String(username || ""))) {
|
|
throw Object.assign(
|
|
new Error(
|
|
"username: with one Linux user per account it must be lower case — a letter, then up to 28 letters, digits, '_' or '-'"
|
|
),
|
|
{ code: "EBADUSER" }
|
|
);
|
|
}
|
|
}
|
|
|
|
// Test seam: the sudo call itself.
|
|
let runImpl = (argv) =>
|
|
execFileSync("sudo", ["-n", ...argv], { encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] });
|
|
function __setRunImpl(fn) {
|
|
runImpl = fn;
|
|
}
|
|
|
|
/**
|
|
* Create / disable / enable the Linux account of `username`. A no-op outside
|
|
* S3 (returns null). Throws EPROVISION with the helper's own words on failure.
|
|
*/
|
|
function provision(action, username) {
|
|
if (!s3Enabled()) return null;
|
|
if (!ACTIONS.has(action)) throw new Error(`unknown provision action: ${action}`);
|
|
assertLinuxName(username);
|
|
try {
|
|
return String(runImpl([PROVISION, action, username]) || "").trim();
|
|
} catch (e) {
|
|
const why = String(e.stderr || e.message || "")
|
|
.trim()
|
|
.split("\n")
|
|
.pop();
|
|
throw Object.assign(new Error(`could not ${action} the Linux account: ${why}`), {
|
|
code: "EPROVISION",
|
|
});
|
|
}
|
|
}
|
|
|
|
function __resetConfCache() {
|
|
confCache = { at: 0, path: null, value: null };
|
|
}
|
|
|
|
module.exports = {
|
|
__resetConfCache,
|
|
confPath,
|
|
LINUX_NAME_RE,
|
|
serverConf,
|
|
s3Enabled,
|
|
accountFor,
|
|
assertLinuxName,
|
|
provision,
|
|
loginFor,
|
|
__setRunImpl,
|
|
};
|