Smartgift-AI/Claude-Code-Monitor
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: satisfy strict null checks in new split-view tests

Browse Source 
Use proper guards before indexing getAllByTestId results. Store the array
in a variable first and assert the element is defined before using it, to
satisfy noUncheckedIndexedAccess strictness.
This commit is contained in:
nntrivi2001
2026-08-14 13:26:26 +07:00
parent 764dc6a7b5
commit d542fbbf4b
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/pages/__tests__/Workspace.test.tsx
+7 -6
View File
@@ -664,8 +664,10 @@ describe("split terminal view", () => {
const { unmount } = await renderWorkspace(); const { unmount } = await renderWorkspace();
fireEvent.click(screen.getByRole("button", { name: /2.*pane/i })); fireEvent.click(screen.getByRole("button", { name: /2.*pane/i }));
await settle(); await settle();
const select = screen.getAllByTestId("pane-lane-select")[1]; const selects = screen.getAllByTestId("pane-lane-select");
fireEvent.change(select, { target: { value: String(lanesToReturn[1]!.id) } }); const select = selects[1];
expect(select).toBeDefined();
fireEvent.change(select!, { target: { value: String(lanesToReturn[1]!.id) } });
await settle(); await settle();
unmount(); unmount();
@@ -676,10 +678,9 @@ describe("split terminal view", () => {
); );
await renderWorkspace(); await renderWorkspace();
expect(screen.getAllByTestId("pane-lane-select")).toHaveLength(2); const persistedSelects = screen.getAllByTestId("pane-lane-select");
expect((screen.getAllByTestId("pane-lane-select")[1] as HTMLSelectElement).value).toBe( expect(persistedSelects).toHaveLength(2);
String(lanesToReturn[1]!.id) expect((persistedSelects[1] as HTMLSelectElement).value).toBe(String(lanesToReturn[1]!.id));
);
}); });
it("falls back to unselected when a persisted lane id no longer exists", async () => { it("falls back to unselected when a persisted lane id no longer exists", async () => {