fix(lanes): don't auto-close Add Lane modal after setup summary

The 3s auto-close timer closed before a user reasonably had time to
look at the setup results, making the feature appear to do nothing.
Require an explicit dismiss (Cancel/X) instead.
This commit is contained in:
2026-08-06 13:55:43 +07:00
parent 7fa39687fe
commit e31d261fd7
3 changed files with 13 additions and 28 deletions
+6 -22
View File
@@ -58,25 +58,6 @@ export function AddLaneModal({
setSetupResult(null);
};
// The setup summary (below) is shown for a few seconds before the modal
// auto-closes, so the user actually sees whether profile/agents/mcp
// succeeded instead of the modal vanishing the instant the lane exists.
const closeTimerRef = useRef<number | null>(null);
const finishAndClose = useCallback(() => {
if (closeTimerRef.current !== null) {
window.clearTimeout(closeTimerRef.current);
closeTimerRef.current = null;
}
reset();
onClose();
}, [onClose]);
useEffect(
() => () => {
if (closeTimerRef.current !== null) window.clearTimeout(closeTimerRef.current);
},
[]
);
// Look up the repo's branches once the path settles - debounced so every
// keystroke while typing a path doesn't fire a request against a path that
// isn't finished yet.
@@ -147,9 +128,11 @@ export function AddLaneModal({
});
}
// Leave the modal open so the setup summary below stays on screen; the
// user dismisses it themselves (Cancel/X) once they've seen it, rather
// than racing a timer that can close before they've looked at it.
setBusy(false);
onAdded(result.lane);
closeTimerRef.current = window.setTimeout(finishAndClose, 3000);
} catch (err) {
setError(err instanceof Error ? err.message : String(err));
setBusy(false);
@@ -163,8 +146,9 @@ export function AddLaneModal({
// into after the very first character. useCallback keeps the identity stable
// across renders so only mount/unmount (and a real onClose change) refocuses.
const handleCancel = useCallback(() => {
finishAndClose();
}, [finishAndClose]);
reset();
onClose();
}, [onClose]);
return (
<ConfirmModal