Smartgift-AI/Claude-Code-Monitor
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(lanes): don't auto-close Add Lane modal after setup summary

Browse Source 
The 3s auto-close timer closed before a user reasonably had time to
look at the setup results, making the feature appear to do nothing.
Require an explicit dismiss (Cancel/X) instead.
This commit is contained in:
nntrivi2001
2026-08-06 13:55:43 +07:00
parent 7fa39687fe
commit e31d261fd7
3 changed files with 13 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/lanes/__tests__/AddLaneModal.test.tsx
+6 -5
View File
@@ -158,8 +158,9 @@ describe("AddLaneModal", () => {
expect(onAdded).toHaveBeenCalledWith(
expect.objectContaining({ id: 9, status: "provisioning" })
);
// The setup summary stays on screen for a few seconds before auto-closing.
await waitFor(() => expect(onClose).toHaveBeenCalled(), { timeout: 4000 });
// The modal stays open showing the setup summary until dismissed - it
// does not close itself just because the lane was added.
expect(onClose).not.toHaveBeenCalled();
});
it("shows a server error and leaves the modal open instead of closing silently", async () => {
@@ -208,7 +209,7 @@ describe("AddLaneModal", () => {
await waitFor(() => expect(onAdded).toHaveBeenCalled());
});
it("still calls onAdded and closes even when every setup call fails", async () => {
it("still calls onAdded even when every setup call fails", async () => {
vi.mocked(api.lanes.branches).mockResolvedValue({ branches: ["main"], current: "main" });
vi.mocked(api.lanes.worktree).mockResolvedValue({
lane: { id: 43, title: "demo2", cwd: "/lanes/demo2", status: "provisioning" } as Lane,
@@ -229,10 +230,10 @@ describe("AddLaneModal", () => {
await user.click(screen.getByRole("button", { name: "Add lane" }));
await waitFor(() => expect(onAdded).toHaveBeenCalled());
await waitFor(() => expect(onClose).toHaveBeenCalled(), { timeout: 4000 });
expect(onClose).not.toHaveBeenCalled();
});
it("shows the setup summary and lets the user dismiss it early instead of waiting out the auto-close timer", async () => {
it("shows the setup summary and lets the user dismiss it manually", async () => {
vi.mocked(api.lanes.branches).mockResolvedValue({ branches: ["main"], current: "main" });
vi.mocked(api.lanes.worktree).mockResolvedValue({
lane: { id: 44, title: "demo3", cwd: "/lanes/demo3", status: "provisioning" } as Lane,