feat: v2.6.0 — Chat UI composer (+ menu, project files, activity panel, permission mode, Stop), git on a workspace's extra folders (#70), long paste as a file (#68), S3 server mode (experimental)

Chat UI: - Each Claude/Codex session keeps its own chat/terminal view; Settings only sets how new sessions open. - Composer + menu: upload, project files and folders (#54, also dragged from the Files/Changes tree), context files, recent uploads, skills, plugins. - Activity side panel (progress, outputs, files read, uploads, memory, skills, connectors) with a file preview; edited-file counts per turn. - Permission-mode chip (Shift+Tab steps, read back from the pane: server/lib/pane-mode.js, GET|POST /api/run/:id/permission-mode). - Stop (Esc) while the main agent works; the status is checked per agent (with session_id /api/agents ignores its status filter) and re-read every 5 s while Stop shows. - Dropped images shown in the conversation (GET /api/run/drop/:name, the requester's own drop dir), full-size viewer. - A plain-text paste over 5,000 characters is attached as pasted-text.txt, so no prompt reaches tmux/argv limits (#68). Changes panel: every /api/lanes/:id/git* route takes ?source=<lane_sources id> (sourceFolder; ENOSOURCE otherwise) and a folder picker switches the whole panel to a workspace's extra folder (#70). Server mode S3 (one Linux user per account) — experimental, verified with fake sudo plus a P6 managed-settings spike on a test account: - member tmux listing runs in the background (cached, 15 s => unknown); - transcript snapshot copy is async, chunked, temp file + rename; - Express Layer patch only on Express 4; - tmux capturePane/sendKey go to the member's own server. Docs: the multi-user design moved in as docs/plans/server-mode/README.md (the AgentHub-Server repo is gone); S3-PLAN P6 result; LANES/API/openapi.
2026-10-09 15:51:19 +07:00
parent ce773a3f5a
commit fa156d6a59
114 changed files with 5831 additions and 885 deletions
@@ -2,7 +2,8 @@
 /**
 * @file run.test.js
 * @description Route tests for the terminal-run feature: same-origin guard,
- * laneId/cwd validation, spawn/kill/list against a mocked tmux backend.
+ * laneId/cwd validation, spawn/kill/list against a mocked tmux backend, a
+ * dropped image served back, and a live pane's permission mode.
 * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
 */
 const { describe, it, before, after, beforeEach } = require("node:test");
@@ -55,7 +56,7 @@ function fetchJson(p, opts = {}) {
          } catch {
            parsed = raw;
          }
-          resolve({ status: res.statusCode, body: parsed });
+          resolve({ status: res.statusCode, body: parsed, headers: res.headers });
        });
      }
    );
@@ -209,6 +210,27 @@ describe("/api/run", () => {
  });
 });

+describe("GET /api/run/files", () => {
+  let srv;
+  const DIR = path.join(TMP, "files-proj");
+  before(async () => {
+    fs.mkdirSync(path.join(DIR, "src", "lib"), { recursive: true });
+    fs.writeFileSync(path.join(DIR, "src", "lib", "a.js"), "");
+    srv = http.createServer(createApp());
+    await new Promise((r) => srv.listen(0, r));
+    BASE = `http://127.0.0.1:${srv.address().port}`;
+  });
+  after(() => new Promise((r) => srv.close(r)));
+  const list = async (qs) =>
+    (await fetchJson(`/api/run/files?cwd=${encodeURIComponent(DIR)}${qs}`)).body.items;
+
+  it("lists files only, unless dirs=1 adds the folders with a trailing slash", async () => {
+    assert.deepEqual(await list(""), ["src/lib/a.js"]);
+    assert.deepEqual(await list("&dirs=1"), ["src/", "src/lib/", "src/lib/a.js"]);
+    assert.deepEqual(await list("&dirs=1&q=lib"), ["src/lib/", "src/lib/a.js"]);
+  });
+});
+
 describe("POST /api/run/drop-image", () => {
  let srv;
  before(async () => {
@@ -274,3 +296,154 @@ describe("POST /api/run/drop-image", () => {
    assert.equal(r.status, 400);
  });
 });
+
+describe("GET /api/run/drop/:name", () => {
+  let srv;
+  before(async () => {
+    srv = http.createServer(createApp());
+    await new Promise((r) => srv.listen(0, r));
+    BASE = `http://127.0.0.1:${srv.address().port}`;
+  });
+  after(() => new Promise((r) => srv.close(r)));
+
+  const PNG = Buffer.from("89504e470d0a1a0a0000", "hex");
+
+  it("serves a dropped image back as an image that runs nothing", async () => {
+    const saved = await fetchJson("/api/run/drop-image", {
+      method: "POST",
+      raw: { type: "image/png", buf: PNG },
+    });
+    const r = await fetchJson(`/api/run/drop/${path.basename(saved.body.path)}`);
+    assert.equal(r.status, 200);
+    assert.equal(r.headers["content-type"], "image/png");
+    assert.equal(r.headers["x-content-type-options"], "nosniff");
+    assert.match(r.headers["content-security-policy"], /sandbox/);
+    fs.unlinkSync(saved.body.path);
+  });
+
+  it("serves no file that is not a dropped image", async () => {
+    const link = path.join(
+      os.tmpdir(),
+      `agenthub-drops-${os.userInfo().uid}`,
+      "fedcba9876543210.png"
+    );
+    fs.rmSync(link, { force: true });
+    fs.symlinkSync("/etc/passwd", link);
+    const pdf = await fetchJson("/api/run/drop-file?name=a.pdf", {
+      method: "POST",
+      raw: { type: "application/pdf", buf: Buffer.from("%PDF") },
+    });
+    for (const name of [
+      path.basename(pdf.body.path), // a drop, but no image
+      "0123456789abcdef.png", // the right shape, never dropped
+      "..%2F..%2Fetc%2Fpasswd",
+      "passwd.png", // no random prefix
+      "fedcba9876543210.png", // a link planted under a drop's name
+    ]) {
+      const r = await fetchJson(`/api/run/drop/${name}`);
+      assert.equal(r.status, 404, name);
+    }
+    fs.unlinkSync(pdf.body.path);
+    fs.unlinkSync(link);
+  });
+});
+
+describe("/api/run/:id/permission-mode", () => {
+  let srv;
+  before(async () => {
+    srv = http.createServer(createApp());
+    await new Promise((r) => srv.listen(0, r));
+    BASE = `http://127.0.0.1:${srv.address().port}`;
+  });
+  after(() => new Promise((r) => srv.close(r)));
+  beforeEach(() => tmux.__reset());
+
+  // A live claude pane whose mode line follows Shift+Tab around Claude Code's cycle.
+  const LINES = {
+    default: "  ⏸ manual mode on · ← for agents",
+    acceptEdits: "  ⏵⏵ accept edits on (shift+tab to cycle) · ← for agents",
+    plan: "  ⏸ plan mode on (shift+tab to cycle) · ← for agents",
+    auto: "  ⏵⏵ auto mode on (shift+tab to cycle) · ← for agents",
+  };
+  function fakePane(start) {
+    const cycle = ["default", "acceptEdits", "plan", "auto"];
+    const state = { mode: start, presses: 0 };
+    tmux.__setExecImpl((args) => {
+      if (args[0] === "capture-pane") return `❯ \n${"─".repeat(20)}\n${LINES[state.mode]}\n`;
+      if (args[0] === "send-keys" && args.at(-1) === "BTab") {
+        state.presses++;
+        state.mode = cycle[(cycle.indexOf(state.mode) + 1) % cycle.length];
+      }
+      return "";
+    });
+    return state;
+  }
+
+  it("GET reads the mode off the pane", async () => {
+    fakePane("plan");
+    const r = await fetchJson("/api/run/agenthub-lane-9/permission-mode");
+    assert.equal(r.status, 200);
+    assert.equal(r.body.mode, "plan");
+  });
+
+  it("POST presses Shift+Tab until the pane shows the mode asked for", async () => {
+    const state = fakePane("default");
+    const r = await fetchJson("/api/run/agenthub-lane-9/permission-mode", {
+      method: "POST",
+      body: { mode: "auto" },
+    });
+    assert.equal(r.status, 200);
+    assert.equal(r.body.mode, "auto");
+    assert.equal(state.presses, 3);
+  });
+
+  it("POST of a mode not in the cycle ends where it started, and says so", async () => {
+    const state = fakePane("acceptEdits");
+    const r = await fetchJson("/api/run/agenthub-lane-9/permission-mode", {
+      method: "POST",
+      body: { mode: "bypassPermissions" },
+    });
+    assert.equal(r.status, 409);
+    assert.equal(r.body.error.code, "EMODEUNAVAILABLE");
+    assert.equal(state.mode, "acceptEdits");
+  });
+
+  it("POST presses nothing when the mode line cannot be read", async () => {
+    let presses = 0;
+    tmux.__setExecImpl((args) => {
+      if (args[0] === "capture-pane") return "Select model\n❯ 1. Default\n";
+      if (args[0] === "send-keys") presses++;
+      return "";
+    });
+    const r = await fetchJson("/api/run/agenthub-lane-9/permission-mode", {
+      method: "POST",
+      body: { mode: "plan" },
+    });
+    assert.equal(r.status, 409);
+    assert.equal(r.body.error.code, "EMODEUNKNOWN");
+    assert.equal(presses, 0);
+  });
+
+  it("POST refuses a mode outside the allowlist", async () => {
+    fakePane("default");
+    const r = await fetchJson("/api/run/agenthub-lane-9/permission-mode", {
+      method: "POST",
+      body: { mode: "dontAsk; rm -rf ~" },
+    });
+    assert.equal(r.status, 400);
+    assert.equal(r.body.error.code, "EBADMODE");
+  });
+
+  it("answers 404 for a pane that is not running", async () => {
+    tmux.__setExecImpl((args) => {
+      if (args[0] === "has-session") {
+        const e = new Error("gone");
+        e.status = 1;
+        throw e;
+      }
+      return "";
+    });
+    const r = await fetchJson("/api/run/agenthub-lane-999/permission-mode");
+    assert.equal(r.status, 404);
+  });
+});