Compare commits
13 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| c28395402b | |||
| 7798530528 | |||
| 25f63d9ad3 | |||
| d060d288fb | |||
| 6099841cef | |||
| d70a7c9403 | |||
| 63eaa739d4 | |||
| 9f8dc9082e | |||
| f1a90e120e | |||
| db5a7776cc | |||
| 6c2c094f64 | |||
| 609a35f251 | |||
| 97c39d5e15 |
@@ -1,4 +1,8 @@
|
|||||||
{
|
{
|
||||||
|
"env": {
|
||||||
|
"ANTHROPIC_BASE_URL": "",
|
||||||
|
"ANTHROPIC_AUTH_TOKEN": ""
|
||||||
|
},
|
||||||
"permissions": {
|
"permissions": {
|
||||||
"allow": [
|
"allow": [
|
||||||
"Bash(npm run:*)",
|
"Bash(npm run:*)",
|
||||||
@@ -36,11 +40,8 @@
|
|||||||
"Bash(node -e ':*)",
|
"Bash(node -e ':*)",
|
||||||
"Bash(node -e \"require\\('./server/lib/transcript-cache'\\); require\\('./scripts/import-history'\\); console.log\\('All modules load OK'\\)\")",
|
"Bash(node -e \"require\\('./server/lib/transcript-cache'\\); require\\('./scripts/import-history'\\); console.log\\('All modules load OK'\\)\")",
|
||||||
"Bash(claude --version)",
|
"Bash(claude --version)",
|
||||||
"Bash(gh pr *)"
|
"Bash(gh pr *)",
|
||||||
|
"Bash(grep *)"
|
||||||
]
|
]
|
||||||
},
|
|
||||||
"env": {
|
|
||||||
"ANTHROPIC_BASE_URL": "",
|
|
||||||
"ANTHROPIC_AUTH_TOKEN": ""
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
# Claude Code Working Guide
|
# Claude Code Working Guide
|
||||||
|
|
||||||
_Last synced: v2.8.35 (2026-10-29) — an HTML file's Preview sits beside Whole file in the Changes panel._ A change that makes any statement in this file, `AGENTS.md`, or a README wrong — a moved path, a new or changed extension point, a retired rule — updates that file in the same change-set and bumps this marker. **Bump = replace the version/date and a ≤ 1-line summary; never append a changelog here** — details belong in the commit message and `docs/`, because this whole file is loaded into every session.
|
_Last synced: v2.8.40 (2026-10-29) — a Codex profile switch restarts Codex's app-server daemon so sessions follow._ A change that makes any statement in this file, `AGENTS.md`, or a README wrong — a moved path, a new or changed extension point, a retired rule — updates that file in the same change-set and bumps this marker. **Bump = replace the version/date and a ≤ 1-line summary; never append a changelog here** — details belong in the commit message and `docs/`, because this whole file is loaded into every session.
|
||||||
|
|
||||||
## Project mission
|
## Project mission
|
||||||
- Maintain a reliable local-first dashboard for Claude Code session monitoring.
|
- Maintain a reliable local-first dashboard for Claude Code session monitoring.
|
||||||
@@ -65,7 +65,7 @@ A **workspace** — called a **lane** in the API, CLI, database and code, which
|
|||||||
- **A workspace's sessions are the ones it OWNS, never the ones that ran in its folder.** `sessions.lane_id` is stamped by `bindRunSession` (`server/routes/hooks.js`) for the session a dashboard pane holds — first writer wins, a nested `claude -p` excluded — and no route sets it. A Codex/Antigravity session (their hooks are opt-in, so a pane may never learn its session) is also stamped by `claimToolSessions` (`server/lib/dashboard-runs.js`, called by both pollers and once at start): the lane of the newest same-tool dashboard run in the session's folder that was live when the session started, never a Claude session. A new Claude pane is started with `--session-id <uuid>` (`spawnRun`), so its `dashboard_runs.session_id` is known before any hook and a hook that carries no `run_id` (a hook handler older than `AGENTHUB_RUN_ID` forwarding) is still stamped from that run (`laneForSession`). Every workspace session list reads `GET /api/sessions?lane=<id>` — which also counts a still-unstamped session one of the lane's `dashboard_runs` holds, because hooks reach only the lowest-port dashboard on a shared DB and that one may be an older build that never stamps — and shows nothing else (no "other sessions in this folder"). Do not go back to listing a workspace by `cwd`, and do not guess ownership for old history.
|
- **A workspace's sessions are the ones it OWNS, never the ones that ran in its folder.** `sessions.lane_id` is stamped by `bindRunSession` (`server/routes/hooks.js`) for the session a dashboard pane holds — first writer wins, a nested `claude -p` excluded — and no route sets it. A Codex/Antigravity session (their hooks are opt-in, so a pane may never learn its session) is also stamped by `claimToolSessions` (`server/lib/dashboard-runs.js`, called by both pollers and once at start): the lane of the newest same-tool dashboard run in the session's folder that was live when the session started, never a Claude session. A new Claude pane is started with `--session-id <uuid>` (`spawnRun`), so its `dashboard_runs.session_id` is known before any hook and a hook that carries no `run_id` (a hook handler older than `AGENTHUB_RUN_ID` forwarding) is still stamped from that run (`laneForSession`). Every workspace session list reads `GET /api/sessions?lane=<id>` — which also counts a still-unstamped session one of the lane's `dashboard_runs` holds, because hooks reach only the lowest-port dashboard on a shared DB and that one may be an older build that never stamps — and shows nothing else (no "other sessions in this folder"). Do not go back to listing a workspace by `cwd`, and do not guess ownership for old history.
|
||||||
- **A session's worktree is `claude --worktree`'s, resolved from the session row — and removing it never forces.** A Worktree start passes `--worktree=<server-made name>` (the `=` form: `-w [name]` eats the prompt otherwise) and Claude Code makes, populates and cleans up `<repo>/.claude/worktrees/<name>`; AgentHub only excludes `/.claude/worktrees/` at the repo root. A git route, a resume or a removal may work in a session's worktree only through `sessionWorktree` (`server/lib/session-worktree.js`: the session owned by the lane, its cwd not the lane's folder, registered by `git worktree list`) — `?session=` on the git routes answers `ENOWORKTREE` rather than falling back to the main folder. `POST /api/lanes/:id/session-worktree/remove` (same-origin, `confirm: true`, refused while a live pane holds the session) is the ONE dashboard path that deletes a worktree: `git worktree remove` with no `--force`, `git branch -d` never `-D`, a live-pid lock refused. Do not add a force, and do not let it touch a lane's own folder.
|
- **A session's worktree is `claude --worktree`'s, resolved from the session row — and removing it never forces.** A Worktree start passes `--worktree=<server-made name>` (the `=` form: `-w [name]` eats the prompt otherwise) and Claude Code makes, populates and cleans up `<repo>/.claude/worktrees/<name>`; AgentHub only excludes `/.claude/worktrees/` at the repo root. A git route, a resume or a removal may work in a session's worktree only through `sessionWorktree` (`server/lib/session-worktree.js`: the session owned by the lane, its cwd not the lane's folder, registered by `git worktree list`) — `?session=` on the git routes answers `ENOWORKTREE` rather than falling back to the main folder. `POST /api/lanes/:id/session-worktree/remove` (same-origin, `confirm: true`, refused while a live pane holds the session) is the ONE dashboard path that deletes a worktree: `git worktree remove` with no `--force`, `git branch -d` never `-D`, a live-pid lock refused. Do not add a force, and do not let it touch a lane's own folder.
|
||||||
- **Opening a session never resumes it — only SENDING a message to it does.** The sidebar and a workspace home ATTACH pane 0 to a session's live tmux pane (`/workspace?lane=<id>&run=<runId>`, `attachRequest` on `LaneConsolePane`) or, for an ended one, open it in its workspace like Claude Desktop (`/workspace?lane=<id>&session=<id>`, `client/src/components/lanes/SessionReplay.tsx`: its conversation read-only plus a prompt box; the console is only hidden, CSS). A resume re-reads the whole transcript into context, so it happens only on an explicit action: a message SENT from that replay (`resumeSessionId` + `prompt`, first free slot), the transcript page's **Resume**/**Fork** (`SessionResumeButton.tsx`, behind a warning), or the ticked sessions of the **Resume interrupted sessions?** dialog (`InterruptedSessionsPrompt.tsx`, `GET /api/run/interrupted` — runs whose pane died under them; opening it resumes nothing). The analysis page `/sessions/<id>` is reached from the session view's **Analyst** button (beside Files/Changes in the right panel). Do not add a path that resumes on a click. A resume is refused while a live pane holds the session (`409 ESESSIONLIVE` with that pane's `run_id`) — open that pane instead; a fork makes a new session and is allowed.
|
- **Opening a session never resumes it — only SENDING a message to it does.** The sidebar and a workspace home ATTACH pane 0 to a session's live tmux pane (`/workspace?lane=<id>&run=<runId>`, `attachRequest` on `LaneConsolePane`) or, for an ended one, open it in its workspace like Claude Desktop (`/workspace?lane=<id>&session=<id>`, `client/src/components/lanes/SessionReplay.tsx`: its conversation read-only plus a prompt box; the console is only hidden, CSS). A resume re-reads the whole transcript into context, so it happens only on an explicit action: a message SENT from that replay (`resumeSessionId` + `prompt`, first free slot), the transcript page's **Resume**/**Fork** (`SessionResumeButton.tsx`, behind a warning), or the ticked sessions of the **Resume interrupted sessions?** dialog (`InterruptedSessionsPrompt.tsx`, `GET /api/run/interrupted` — runs whose pane died under them; opening it resumes nothing). The analysis page `/sessions/<id>` is reached from the session view's **Analyst** button (beside Files/Changes in the right panel). Do not add a path that resumes on a click. A resume is refused while a live pane holds the session (`409 ESESSIONLIVE` with that pane's `run_id`) — open that pane instead; a fork makes a new session and is allowed.
|
||||||
- **A chat artifact runs in its own sandbox, never on the dashboard's origin.** The artifact panel (`client/src/components/run/ChatFilePreview.tsx`, `client/src/lib/artifactView.ts`) runs model-written HTML/Mermaid/React in an `<iframe srcdoc sandbox="allow-scripts …">` and an SVG in `sandbox=""` — never add `allow-same-origin` (the script would read the dashboard's cookies and call its API as the user), never render one with `dangerouslySetInnerHTML`, and keep its CDN libraries pinned to exact versions. An HTML FILE opened from the Changes panel, a Chat file preview or the File Explorer runs in the same sandbox (`client/src/components/HtmlFrame.tsx`); its relative CSS/scripts/images are fetched by the DASHBOARD through the existing download routes and inlined (`client/src/lib/htmlInline.ts`) — never add a route that serves a folder to the frame without the login cookie. Versions are rebuilt from Write/Edit inputs (kept up to 256 KB by `server/lib/transcript-message.js`); no copy is stored, and Save to Artifacts uses the Hub's own `pinFile`/upload routes.
|
- **A chat artifact runs in its own sandbox, never on the dashboard's origin.** The artifact panel (`client/src/components/run/ChatFilePreview.tsx`, `client/src/lib/artifactView.ts`) runs model-written HTML/Mermaid/React in an `<iframe srcdoc sandbox="allow-scripts …">` and an SVG in `sandbox=""` — never add `allow-same-origin` (the script would read the dashboard's cookies and call its API as the user), never render one with `dangerouslySetInnerHTML`, and keep its CDN libraries pinned to exact versions. An HTML FILE opened from the Changes panel, a Chat file preview or the File Explorer runs in the same sandbox (`client/src/components/HtmlFrame.tsx`, shown in a modal — `HtmlViewerModal.tsx`, Chat's `FilePreview modal`); its relative CSS/scripts/images are fetched by the DASHBOARD through the existing download routes and inlined (`client/src/lib/htmlInline.ts`) — never add a route that serves a folder to the frame without the login cookie. Versions are rebuilt from Write/Edit inputs (kept up to 256 KB by `server/lib/transcript-message.js`); no copy is stored, and Save to Artifacts uses the Hub's own `pinFile`/upload routes.
|
||||||
- **A `cwd` can back at most one lane per tool, not one lane overall.** Uniqueness is the composite `idx_lanes_cwd_tool` (`cwd`, `tool`), not `cwd` alone — Repo/Adopt mode (`POST /api/lanes/ensure`) lets the same directory carry a `claude` lane and a `codex` lane side by side, shown as two separate cards. `resolveLaneByCwd(cwd, tool)` takes an optional `tool` filter for exactly this; hook ingestion (`touchLaneFromHook`) pins it to the hook's own tool — `claude`, `codex` for a hook posted with `tool: "codex"`, or `antigravity` for one posted with `tool: "antigravity"` (the Codex and Antigravity hook rules above) — so a hook event never touches the other tool's lane sharing the path, and stage detection (`resolveLaneForWork` + `detect`) runs for `claude` only. Worktree mode is unaffected — it already allocates a unique directory per lane.
|
- **A `cwd` can back at most one lane per tool, not one lane overall.** Uniqueness is the composite `idx_lanes_cwd_tool` (`cwd`, `tool`), not `cwd` alone — Repo/Adopt mode (`POST /api/lanes/ensure`) lets the same directory carry a `claude` lane and a `codex` lane side by side, shown as two separate cards. `resolveLaneByCwd(cwd, tool)` takes an optional `tool` filter for exactly this; hook ingestion (`touchLaneFromHook`) pins it to the hook's own tool — `claude`, `codex` for a hook posted with `tool: "codex"`, or `antigravity` for one posted with `tool: "antigravity"` (the Codex and Antigravity hook rules above) — so a hook event never touches the other tool's lane sharing the path, and stage detection (`resolveLaneForWork` + `detect`) runs for `claude` only. Worktree mode is unaffected — it already allocates a unique directory per lane.
|
||||||
|
|
||||||
See `docs/LANES.md` for full guide: stage reporting, custom templates, lane actions, and the five node states.
|
See `docs/LANES.md` for full guide: stage reporting, custom templates, lane actions, and the five node states.
|
||||||
|
|||||||
File diff suppressed because one or more lines are too long
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,109 @@
|
|||||||
|
/**
|
||||||
|
* @file HtmlViewerModal.tsx
|
||||||
|
* @description An HTML file shown as the page in a modal over the whole
|
||||||
|
* screen — the one viewer the File Explorer and the Changes panel's Preview
|
||||||
|
* open (the Chat's file preview opens its own panel as a modal instead, for
|
||||||
|
* its versions and Code tab). The page itself is `HtmlFrame`: the chat
|
||||||
|
* artifact's sandbox, its relative files read through the caller's guarded
|
||||||
|
* `fetchFile`. Keys and clicks stop at the modal, so a shortcut of the view
|
||||||
|
* underneath (the explorer's Delete) never fires from inside it.
|
||||||
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
||||||
|
*/
|
||||||
|
|
||||||
|
import { useRef, type ReactNode } from "react";
|
||||||
|
import { createPortal } from "react-dom";
|
||||||
|
import { useTranslation } from "react-i18next";
|
||||||
|
import { Download, X } from "lucide-react";
|
||||||
|
import { useDialog } from "../hooks/useDialog";
|
||||||
|
import { HtmlFrame } from "./HtmlFrame";
|
||||||
|
import type { FetchFile } from "../lib/htmlInline";
|
||||||
|
|
||||||
|
export function HtmlViewerModal({
|
||||||
|
path,
|
||||||
|
html,
|
||||||
|
fetchFile,
|
||||||
|
onDownload,
|
||||||
|
onClose,
|
||||||
|
testId = "html-viewer",
|
||||||
|
}: {
|
||||||
|
/** The file's path relative to the place `fetchFile` reads from; also its title. */
|
||||||
|
path: string;
|
||||||
|
/** The page's text; read through `fetchFile` when absent. */
|
||||||
|
html?: string;
|
||||||
|
fetchFile?: FetchFile | null;
|
||||||
|
onDownload?: () => void;
|
||||||
|
onClose: () => void;
|
||||||
|
testId?: string;
|
||||||
|
}) {
|
||||||
|
const { t } = useTranslation(["lanes"]);
|
||||||
|
const panelRef = useRef<HTMLDivElement>(null);
|
||||||
|
useDialog(true, panelRef, onClose);
|
||||||
|
const name = path.slice(path.lastIndexOf("/") + 1);
|
||||||
|
return createPortal(
|
||||||
|
<div
|
||||||
|
className="fixed inset-0 z-[70] flex items-center justify-center bg-black/60 p-3"
|
||||||
|
onClick={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
onClose();
|
||||||
|
}}
|
||||||
|
onKeyDown={(e) => {
|
||||||
|
// Nothing reaches the view underneath — so Esc, which useDialog's
|
||||||
|
// document listener would never see, closes here.
|
||||||
|
e.stopPropagation();
|
||||||
|
if (e.key === "Escape") onClose();
|
||||||
|
}}
|
||||||
|
role="presentation"
|
||||||
|
>
|
||||||
|
<div
|
||||||
|
ref={panelRef}
|
||||||
|
role="dialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-label={name}
|
||||||
|
data-testid={testId}
|
||||||
|
className="flex h-[92vh] w-[96vw] max-w-7xl flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-2xl shadow-black/50"
|
||||||
|
onClick={(e) => e.stopPropagation()}
|
||||||
|
>
|
||||||
|
<div className="flex items-center gap-2 border-b border-border px-3 py-2">
|
||||||
|
<span className="min-w-0 flex-1 truncate font-mono text-[13px] text-fg-primary">
|
||||||
|
{path}
|
||||||
|
</span>
|
||||||
|
{onDownload && (
|
||||||
|
<HeadButton label={t("fx.download")} onClick={onDownload}>
|
||||||
|
<Download className="h-4 w-4" />
|
||||||
|
</HeadButton>
|
||||||
|
)}
|
||||||
|
<HeadButton label={t("fx.close")} onClick={onClose}>
|
||||||
|
<X className="h-4 w-4" />
|
||||||
|
</HeadButton>
|
||||||
|
</div>
|
||||||
|
<HtmlFrame path={path} html={html} fetchFile={fetchFile} title={name} />
|
||||||
|
</div>
|
||||||
|
</div>,
|
||||||
|
document.body
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function HeadButton({
|
||||||
|
label,
|
||||||
|
onClick,
|
||||||
|
children,
|
||||||
|
}: {
|
||||||
|
label: string;
|
||||||
|
onClick: () => void;
|
||||||
|
children: ReactNode;
|
||||||
|
}) {
|
||||||
|
return (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
aria-label={label}
|
||||||
|
title={label}
|
||||||
|
onClick={(e) => {
|
||||||
|
e.stopPropagation();
|
||||||
|
onClick();
|
||||||
|
}}
|
||||||
|
className="rounded-md p-1.5 text-fg-secondary transition-colors hover:bg-surface-2 hover:text-fg-primary"
|
||||||
|
>
|
||||||
|
{children}
|
||||||
|
</button>
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -3,7 +3,8 @@
|
|||||||
* @description Tests for the sidebar's workspace list: one flat row per
|
* @description Tests for the sidebar's workspace list: one flat row per
|
||||||
* workspace in the stored order, a row expanding to its sessions (remembered),
|
* workspace in the stored order, a row expanding to its sessions (remembered),
|
||||||
* a live session opening its pane and an ended one its transcript, the
|
* a live session opening its pane and an ended one its transcript, the
|
||||||
* workspace's OWN sessions only, a session's state dot, rename and archive,
|
* workspace's OWN sessions only, a session's state dot, rename and archive
|
||||||
|
* (a live one's pane stopped first),
|
||||||
* selection
|
* selection
|
||||||
* by URL, Alt+arrow reordering kept in localStorage, double-click rename, the
|
* by URL, Alt+arrow reordering kept in localStorage, double-click rename, the
|
||||||
* search, the row menu's items by kind and tool, the status dot, and the
|
* search, the row menu's items by kind and tool, the status dot, and the
|
||||||
@@ -225,6 +226,8 @@ describe("WorkspaceTree", () => {
|
|||||||
await user.type(input, "Better name{Enter}");
|
await user.type(input, "Better name{Enter}");
|
||||||
expect(api.sessions.patch).toHaveBeenCalledWith("s-old", { name: "Better name" });
|
expect(api.sessions.patch).toHaveBeenCalledWith("s-old", { name: "Better name" });
|
||||||
await user.click(screen.getByTestId("workspace-session-archive-s-live"));
|
await user.click(screen.getByTestId("workspace-session-archive-s-live"));
|
||||||
|
// A live session's Archive stops its pane first — never a hidden pane left running.
|
||||||
|
expect(api.run.kill).toHaveBeenCalledWith("agenthub-lane-1-2", { archive: true });
|
||||||
expect(api.sessions.patch).toHaveBeenCalledWith("s-live", { archived: true });
|
expect(api.sessions.patch).toHaveBeenCalledWith("s-live", { archived: true });
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -683,7 +683,12 @@ export function HostSections({ host, heap }: { host: HostState; heap?: HeapInfo
|
|||||||
aria-expanded={isOpen}
|
aria-expanded={isOpen}
|
||||||
className="flex w-full items-center gap-2 text-left disabled:cursor-default"
|
className="flex w-full items-center gap-2 text-left disabled:cursor-default"
|
||||||
>
|
>
|
||||||
<UserAvatar name={name} className="h-6 w-6 text-[10px]" />
|
<UserAvatar
|
||||||
|
name={name}
|
||||||
|
userId={g.userId}
|
||||||
|
avatarAt={g.avatarAt}
|
||||||
|
className="h-6 w-6 text-[10px]"
|
||||||
|
/>
|
||||||
<span className="min-w-0 flex-1 truncate text-xs text-fg-secondary">
|
<span className="min-w-0 flex-1 truncate text-xs text-fg-secondary">
|
||||||
{name}
|
{name}
|
||||||
</span>
|
</span>
|
||||||
|
|||||||
@@ -69,6 +69,7 @@ const stats: HostStats = {
|
|||||||
const api = vi.hoisted(() => ({
|
const api = vi.hoisted(() => ({
|
||||||
host: { stats: vi.fn(), history: vi.fn() },
|
host: { stats: vi.fn(), history: vi.fn() },
|
||||||
me: { avatarUrl: () => null },
|
me: { avatarUrl: () => null },
|
||||||
|
users: { avatarUrl: () => null },
|
||||||
}));
|
}));
|
||||||
vi.mock("../../../lib/api", async (importOriginal) => {
|
vi.mock("../../../lib/api", async (importOriginal) => {
|
||||||
const actual = await importOriginal<Record<string, unknown>>();
|
const actual = await importOriginal<Record<string, unknown>>();
|
||||||
|
|||||||
@@ -91,7 +91,8 @@ import {
|
|||||||
} from "../../lib/api";
|
} from "../../lib/api";
|
||||||
import type { Lane } from "../../lib/types";
|
import type { Lane } from "../../lib/types";
|
||||||
import { useDialog } from "../../hooks/useDialog";
|
import { useDialog } from "../../hooks/useDialog";
|
||||||
import { HtmlFrame, fetchVia } from "../HtmlFrame";
|
import { fetchVia } from "../HtmlFrame";
|
||||||
|
import { HtmlViewerModal } from "../HtmlViewerModal";
|
||||||
import { toast } from "../../lib/toast";
|
import { toast } from "../../lib/toast";
|
||||||
import { confirmDialog } from "../../lib/confirm";
|
import { confirmDialog } from "../../lib/confirm";
|
||||||
import { formatBytes } from "../../lib/format";
|
import { formatBytes } from "../../lib/format";
|
||||||
@@ -1935,10 +1936,8 @@ export function FileExplorer({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/** An HTML file shown as the page, over the explorer: its relative CSS,
|
/** An HTML file as the page, in the shared modal viewer (`HtmlViewerModal`):
|
||||||
* scripts and images read through the same download route (`HtmlFrame`).
|
* its relative CSS, scripts and images read through the same download route. */
|
||||||
* Keys and clicks stop here — through the portal they would otherwise reach
|
|
||||||
* the explorer's own shortcuts (Delete would trash the selection). */
|
|
||||||
function HtmlViewer({
|
function HtmlViewer({
|
||||||
entry,
|
entry,
|
||||||
place,
|
place,
|
||||||
@@ -1950,49 +1949,20 @@ function HtmlViewer({
|
|||||||
onDownload: () => void;
|
onDownload: () => void;
|
||||||
onClose: () => void;
|
onClose: () => void;
|
||||||
}) {
|
}) {
|
||||||
const { t } = useTranslation(["lanes"]);
|
|
||||||
const panelRef = useRef<HTMLDivElement>(null);
|
|
||||||
useDialog(true, panelRef, onClose);
|
|
||||||
const placeKey = JSON.stringify(place);
|
const placeKey = JSON.stringify(place);
|
||||||
const fetchFile = useMemo(
|
const fetchFile = useMemo(
|
||||||
() => fetchVia((p) => api.files.downloadUrl(place, p)),
|
() => fetchVia((p) => api.files.downloadUrl(place, p)),
|
||||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||||
[placeKey]
|
[placeKey]
|
||||||
);
|
);
|
||||||
return createPortal(
|
return (
|
||||||
<div
|
<HtmlViewerModal
|
||||||
className="fixed inset-0 z-[70] flex items-center justify-center bg-black/60 p-3"
|
path={entry.path}
|
||||||
onClick={(e) => {
|
fetchFile={fetchFile}
|
||||||
e.stopPropagation();
|
onDownload={onDownload}
|
||||||
onClose();
|
onClose={onClose}
|
||||||
}}
|
testId="fx-html-viewer"
|
||||||
onKeyDown={(e) => e.stopPropagation()}
|
/>
|
||||||
role="presentation"
|
|
||||||
>
|
|
||||||
<div
|
|
||||||
ref={panelRef}
|
|
||||||
role="dialog"
|
|
||||||
aria-modal="true"
|
|
||||||
aria-label={entry.name}
|
|
||||||
data-testid="fx-html-viewer"
|
|
||||||
className="flex h-[92vh] w-[96vw] max-w-7xl flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-2xl shadow-black/50"
|
|
||||||
onClick={(e) => e.stopPropagation()}
|
|
||||||
>
|
|
||||||
<div className="flex items-center gap-2 border-b border-border px-3 py-2">
|
|
||||||
<span className="min-w-0 flex-1 truncate font-mono text-[13px] text-fg-primary">
|
|
||||||
{entry.path}
|
|
||||||
</span>
|
|
||||||
<HeadButton label={t("fx.download")} onClick={onDownload}>
|
|
||||||
<Download className="h-4 w-4" />
|
|
||||||
</HeadButton>
|
|
||||||
<HeadButton label={t("fx.close")} onClick={onClose}>
|
|
||||||
<X className="h-4 w-4" />
|
|
||||||
</HeadButton>
|
|
||||||
</div>
|
|
||||||
<HtmlFrame path={entry.path} fetchFile={fetchFile} title={entry.name} />
|
|
||||||
</div>
|
|
||||||
</div>,
|
|
||||||
document.body
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -14,9 +14,9 @@
|
|||||||
* is unsaved): Changes folds the unchanged lines away, Whole file
|
* is unsaved): Changes folds the unchanged lines away, Whole file
|
||||||
* shows them; any other file opens on its read-only diff; a
|
* shows them; any other file opens on its read-only diff; a
|
||||||
* whole markdown file can also be read rendered (Preview), an HTML
|
* whole markdown file can also be read rendered (Preview), an HTML
|
||||||
* file shown as the page by Preview beside Whole file
|
* file's Preview beside Whole file opens the page in a modal
|
||||||
* (`HtmlFrame`, its relative CSS, scripts and images read like
|
* (`HtmlViewerModal`, its relative CSS, scripts and images read
|
||||||
* downloads), and an
|
* like downloads), and an
|
||||||
* image file is shown as the picture (`GET …/git/raw`)
|
* image file is shown as the picture (`GET …/git/raw`)
|
||||||
* history — recent commits; opening one shows that commit's diff
|
* history — recent commits; opening one shows that commit's diff
|
||||||
* browse — quick-open by path, or the repo's tracked file tree (the
|
* browse — quick-open by path, or the repo's tracked file tree (the
|
||||||
@@ -139,7 +139,8 @@ import { LaneConflictView } from "./LaneConflictView";
|
|||||||
import { FileExplorer } from "./FileExplorer";
|
import { FileExplorer } from "./FileExplorer";
|
||||||
import { ContextMenu, MenuItem, MenuSeparator, useContextMenu } from "../ContextMenu";
|
import { ContextMenu, MenuItem, MenuSeparator, useContextMenu } from "../ContextMenu";
|
||||||
import { MarkdownPreview, isMarkdown } from "../MarkdownPreview";
|
import { MarkdownPreview, isMarkdown } from "../MarkdownPreview";
|
||||||
import { HtmlFrame, fetchVia } from "../HtmlFrame";
|
import { fetchVia } from "../HtmlFrame";
|
||||||
|
import { HtmlViewerModal } from "../HtmlViewerModal";
|
||||||
import { LaneGitHeader, useLaneGitFacts } from "./LaneGitHeader";
|
import { LaneGitHeader, useLaneGitFacts } from "./LaneGitHeader";
|
||||||
import { changeTree, treeFiles, type ChangeTreeDir } from "../../lib/changeTree";
|
import { changeTree, treeFiles, type ChangeTreeDir } from "../../lib/changeTree";
|
||||||
import { dragProjectPath } from "../../lib/promptAttach";
|
import { dragProjectPath } from "../../lib/promptAttach";
|
||||||
@@ -198,7 +199,7 @@ function Delta({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/** An HTML page, which the viewer can show rendered (`HtmlFrame`). */
|
/** An HTML page, which Preview opens as the page (`HtmlViewerModal`). */
|
||||||
const isHtml = (p: string | null | undefined) => !!p && /\.html?$/i.test(p);
|
const isHtml = (p: string | null | undefined) => !!p && /\.html?$/i.test(p);
|
||||||
|
|
||||||
/** What the viewer shows as a picture (`readImageAt`'s list on the server). */
|
/** What the viewer shows as a picture (`readImageAt`'s list on the server). */
|
||||||
@@ -890,11 +891,13 @@ export function LaneChangesPanel({
|
|||||||
const [layout, setLayout] = useState<DiffLayout>(wide ? "split" : "unified");
|
const [layout, setLayout] = useState<DiffLayout>(wide ? "split" : "unified");
|
||||||
useEffect(() => setLayout(wide ? "split" : "unified"), [wide]);
|
useEffect(() => setLayout(wide ? "split" : "unified"), [wide]);
|
||||||
const [whole, setWhole] = useState(false);
|
const [whole, setWhole] = useState(false);
|
||||||
// A whole markdown or HTML file shown rendered instead of as source; per
|
// A whole markdown file shown rendered instead of as source; per file,
|
||||||
// file, markdown opening as Settings → Appearance says
|
// opening as Settings → Appearance says (`lib/markdownView.ts`).
|
||||||
// (`lib/markdownView.ts`), an HTML page only once Preview is clicked.
|
|
||||||
const [mdPreview, setMdPreview] = useState(readMarkdownPreview);
|
const [mdPreview, setMdPreview] = useState(readMarkdownPreview);
|
||||||
useEffect(() => setMdPreview(!isHtml(openFile) && readMarkdownPreview()), [openFile]);
|
useEffect(() => setMdPreview(readMarkdownPreview()), [openFile]);
|
||||||
|
// An HTML file's page, open in the modal viewer (Preview beside Whole file).
|
||||||
|
const [htmlOpen, setHtmlOpen] = useState(false);
|
||||||
|
useEffect(() => setHtmlOpen(false), [openFile, mode]);
|
||||||
const [data, setData] = useState<LaneChanges | null>(null);
|
const [data, setData] = useState<LaneChanges | null>(null);
|
||||||
// A folder that is not a repo (an empty new workspace, a parent of clones)
|
// A folder that is not a repo (an empty new workspace, a parent of clones)
|
||||||
// has no changes, review or history — only its files, which Files reads
|
// has no changes, review or history — only its files, which Files reads
|
||||||
@@ -2059,10 +2062,8 @@ export function LaneChangesPanel({
|
|||||||
});
|
});
|
||||||
|
|
||||||
const dirty = draft !== null && draft !== text?.lines.join("\n");
|
const dirty = draft !== null && draft !== text?.lines.join("\n");
|
||||||
// Rendered only where the toggle is offered: a whole markdown or HTML file.
|
// Rendered only where the toggle is offered: a whole markdown file.
|
||||||
const mdShown = mdPreview && whole && (isMarkdown(openFile) || isHtml(openFile));
|
const mdShown = mdPreview && whole && isMarkdown(openFile);
|
||||||
// The HTML page is showing (the Preview view of the Changes / Whole file / Preview group).
|
|
||||||
const htmlShown = mdShown && isHtml(openFile);
|
|
||||||
// An HTML page's relative CSS/scripts/images, read like a download — only
|
// An HTML page's relative CSS/scripts/images, read like a download — only
|
||||||
// from the working tree: a commit's page would get today's files.
|
// from the working tree: a commit's page would get today's files.
|
||||||
const htmlFetch = useMemo(
|
const htmlFetch = useMemo(
|
||||||
@@ -2562,11 +2563,8 @@ export function LaneChangesPanel({
|
|||||||
<button
|
<button
|
||||||
key={String(w)}
|
key={String(w)}
|
||||||
type="button"
|
type="button"
|
||||||
aria-pressed={whole === w && !htmlShown}
|
aria-pressed={whole === w}
|
||||||
onClick={() => {
|
onClick={() => {
|
||||||
// Changes and Whole file show an HTML page's source;
|
|
||||||
// only Preview runs it.
|
|
||||||
if (htmlShown) setMdPreview(false);
|
|
||||||
if (whole === w) return;
|
if (whole === w) return;
|
||||||
// Both views of a working file are the same editor: the
|
// Both views of a working file are the same editor: the
|
||||||
// draft goes along, unsaved or not.
|
// draft goes along, unsaved or not.
|
||||||
@@ -2580,7 +2578,7 @@ export function LaneChangesPanel({
|
|||||||
});
|
});
|
||||||
}}
|
}}
|
||||||
className={`rounded px-2 py-0.5 text-[11px] transition-colors ${
|
className={`rounded px-2 py-0.5 text-[11px] transition-colors ${
|
||||||
whole === w && !htmlShown
|
whole === w
|
||||||
? "bg-surface-4 text-fg-primary"
|
? "bg-surface-4 text-fg-primary"
|
||||||
: "text-fg-secondary hover:text-fg-primary"
|
: "text-fg-secondary hover:text-fg-primary"
|
||||||
}`}
|
}`}
|
||||||
@@ -2588,28 +2586,33 @@ export function LaneChangesPanel({
|
|||||||
{t(w ? "changes.wholeFile" : "changes.changesView")}
|
{t(w ? "changes.wholeFile" : "changes.changesView")}
|
||||||
</button>
|
</button>
|
||||||
))}
|
))}
|
||||||
{/* An HTML file's third view: the page itself. */}
|
|
||||||
{isHtml(openFile) && (
|
|
||||||
<button
|
|
||||||
type="button"
|
|
||||||
data-testid="lane-file-preview"
|
|
||||||
aria-pressed={htmlShown}
|
|
||||||
disabled={dirty}
|
|
||||||
onClick={() => {
|
|
||||||
setMdPreview(true);
|
|
||||||
setWhole(true);
|
|
||||||
}}
|
|
||||||
className={`rounded px-2 py-0.5 text-[11px] transition-colors disabled:cursor-not-allowed disabled:opacity-40 ${
|
|
||||||
htmlShown
|
|
||||||
? "bg-surface-4 text-fg-primary"
|
|
||||||
: "text-fg-secondary hover:text-fg-primary"
|
|
||||||
}`}
|
|
||||||
>
|
|
||||||
{t("changes.preview")}
|
|
||||||
</button>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
{/* An HTML file opens as the page in a modal over the screen;
|
||||||
|
a commit's page once its text is read (Whole file). */}
|
||||||
|
{mode === "file" && isHtml(openFile) && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
data-testid="lane-file-preview"
|
||||||
|
disabled={dirty || (range === "commit" && !text)}
|
||||||
|
onClick={() => setHtmlOpen(true)}
|
||||||
|
className="flex items-center gap-1 rounded border border-border bg-surface-2 px-2 py-1 text-[11px] text-fg-secondary hover:text-fg-primary disabled:cursor-not-allowed disabled:opacity-40"
|
||||||
|
>
|
||||||
|
<Eye className="h-3 w-3" />
|
||||||
|
{t("changes.preview")}
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
{htmlOpen && openFile && (
|
||||||
|
<HtmlViewerModal
|
||||||
|
path={openFile}
|
||||||
|
// A commit's page is its text at that commit (no sibling
|
||||||
|
// files); a working one is read whole from the disk.
|
||||||
|
html={range === "commit" ? text?.lines.join("\n") : undefined}
|
||||||
|
fetchFile={htmlFetch}
|
||||||
|
onDownload={!local && range !== "commit" ? () => download(openFile) : undefined}
|
||||||
|
onClose={() => setHtmlOpen(false)}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
@@ -3164,17 +3167,7 @@ export function LaneChangesPanel({
|
|||||||
</Suspense>
|
</Suspense>
|
||||||
)
|
)
|
||||||
) : whole ? (
|
) : whole ? (
|
||||||
text && mdShown && isHtml(openFile) ? (
|
text && mdShown ? (
|
||||||
<HtmlFrame
|
|
||||||
key={openFile}
|
|
||||||
path={text.path}
|
|
||||||
// A cut-off page is read whole through the download.
|
|
||||||
html={text.truncated && htmlFetch ? undefined : text.lines.join("\n")}
|
|
||||||
fetchFile={htmlFetch}
|
|
||||||
title={text.path}
|
|
||||||
className="rounded border border-border-light"
|
|
||||||
/>
|
|
||||||
) : text && mdShown ? (
|
|
||||||
<div className="min-h-0 flex-1 overflow-auto rounded border border-border-light bg-surface-0 p-4">
|
<div className="min-h-0 flex-1 overflow-auto rounded border border-border-light bg-surface-0 p-4">
|
||||||
<MarkdownPreview text={text.lines.join("\n")} />
|
<MarkdownPreview text={text.lines.join("\n")} />
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -14,7 +14,7 @@
|
|||||||
* a catalog tool's bypass — a YOLO chip for Codex) and Local / New worktree — the workspace's Recents — the sessions it
|
* a catalog tool's bypass — a YOLO chip for Codex) and Local / New worktree — the workspace's Recents — the sessions it
|
||||||
* owns and has not archived (`?lane=&archived=0`, with each one's state dot,
|
* owns and has not archived (`?lane=&archived=0`, with each one's state dot,
|
||||||
* **Show more** past the first page, and the sidebar row's Rename/Archive in
|
* **Show more** past the first page, and the sidebar row's Rename/Archive in
|
||||||
* its right-click menu), then the archived ones folded with Unarchive; a live session opens its pane,
|
* its right-click menu — Archive on a live session stops its pane first, `endRuns`), then the archived ones folded with Unarchive; a live session opens its pane,
|
||||||
* any other its conversation (`&session=`, `SessionReplay`), nothing is resumed — and on the right its context: Instructions, Memory (read-only), Context files and
|
* any other its conversation (`&session=`, `SessionReplay`), nothing is resumed — and on the right its context: Instructions, Memory (read-only), Context files and
|
||||||
* Folders (`WorkspaceContext.tsx`, also folded at the bottom of the Changes panel).
|
* Folders (`WorkspaceContext.tsx`, also folded at the bottom of the Changes panel).
|
||||||
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
||||||
@@ -22,6 +22,7 @@
|
|||||||
|
|
||||||
import { isSubmitEnter } from "../../lib/keys";
|
import { isSubmitEnter } from "../../lib/keys";
|
||||||
import { confirmDialog } from "../../lib/confirm";
|
import { confirmDialog } from "../../lib/confirm";
|
||||||
|
import { endRuns } from "../../lib/stopSession";
|
||||||
import { useEffect, useRef, useState } from "react";
|
import { useEffect, useRef, useState } from "react";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import { useNavigate } from "react-router-dom";
|
import { useNavigate } from "react-router-dom";
|
||||||
@@ -307,30 +308,30 @@ function HomeBody({
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
const archiveSession = async (s: Session) => {
|
const archiveSession = async (s: Session) => {
|
||||||
const live = !!liveRunFor(lane, liveRuns, s.id);
|
const run = liveRunFor(lane, liveRuns, s.id);
|
||||||
|
// A live one is stopped first, as the tab's X does (its own confirm):
|
||||||
|
// archiving only its row left a pane running that no list showed.
|
||||||
|
if (run) {
|
||||||
|
if ((await endRuns([run], { name: s.name || t("tree.newSession"), t })).length)
|
||||||
|
await patchSession(s, { archived: true });
|
||||||
|
return;
|
||||||
|
}
|
||||||
const wt = sessionWorktreeName(lane, s);
|
const wt = sessionWorktreeName(lane, s);
|
||||||
const ok = await confirmDialog(
|
const ok = await confirmDialog(
|
||||||
wt && !live
|
wt
|
||||||
? {
|
? {
|
||||||
title: t("tree.archiveWorktreeTitle"),
|
title: t("tree.archiveWorktreeTitle"),
|
||||||
message: t("tree.archiveWorktreeBody", { name: wt }),
|
message: t("tree.archiveWorktreeBody", { name: wt }),
|
||||||
confirmLabel: t("tree.archiveWorktreeConfirm"),
|
confirmLabel: t("tree.archiveWorktreeConfirm"),
|
||||||
}
|
}
|
||||||
: live
|
: {
|
||||||
? {
|
title: t("tree.archiveSession"),
|
||||||
title: t("tree.archiveLiveTitle"),
|
confirmLabel: t("sessionMenu.archive"),
|
||||||
message: t("tree.archiveLiveBody"),
|
destructive: false,
|
||||||
confirmLabel: t("sessionMenu.archive"),
|
}
|
||||||
destructive: false,
|
|
||||||
}
|
|
||||||
: {
|
|
||||||
title: t("tree.archiveSession"),
|
|
||||||
confirmLabel: t("sessionMenu.archive"),
|
|
||||||
destructive: false,
|
|
||||||
}
|
|
||||||
);
|
);
|
||||||
if (!ok) return;
|
if (!ok) return;
|
||||||
if (wt && !live) {
|
if (wt) {
|
||||||
try {
|
try {
|
||||||
await api.lanes.removeSessionWorktree(lane.id, s.id).catch((err: unknown) => {
|
await api.lanes.removeSessionWorktree(lane.id, s.id).catch((err: unknown) => {
|
||||||
if ((err as { code?: string }).code !== "ENOWORKTREE") throw err;
|
if ((err as { code?: string }).code !== "ENOWORKTREE") throw err;
|
||||||
|
|||||||
@@ -24,7 +24,7 @@
|
|||||||
* The list shows `SESSION_LIMIT` rows and a **See all (N more)** under them that
|
* The list shows `SESSION_LIMIT` rows and a **See all (N more)** under them that
|
||||||
* loads every one, then a **Show less** that goes back to `SESSION_LIMIT`. A
|
* loads every one, then a **Show less** that goes back to `SESSION_LIMIT`. A
|
||||||
* live tab whose session was archived is not brought back as a New session,
|
* live tab whose session was archived is not brought back as a New session,
|
||||||
* and archiving a live one asks first. F2 renames the focused row too; each
|
* and archiving a live one STOPS it first (`endRuns`, the tab X's confirm). F2 renames the focused row too; each
|
||||||
* dot carries its meaning as screen-reader text. `readOnly` (another user's
|
* dot carries its meaning as screen-reader text. `readOnly` (another user's
|
||||||
* workspace, for an analyst): no live tabs, no rename/archive/menu, and a row
|
* workspace, for an analyst): no live tabs, no rename/archive/menu, and a row
|
||||||
* opens the session's analysis page (`/sessions/<id>`) — never a pane or a resume.
|
* opens the session's analysis page (`/sessions/<id>`) — never a pane or a resume.
|
||||||
@@ -32,7 +32,7 @@
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
import { useEffect, useState, type ReactNode } from "react";
|
import { useEffect, useState, type ReactNode } from "react";
|
||||||
import { confirmDialog } from "../../lib/confirm";
|
import { endRuns } from "../../lib/stopSession";
|
||||||
import { isSubmitEnter } from "../../lib/keys";
|
import { isSubmitEnter } from "../../lib/keys";
|
||||||
import { Archive, GitBranch, Pin, PinOff, SquareTerminal } from "lucide-react";
|
import { Archive, GitBranch, Pin, PinOff, SquareTerminal } from "lucide-react";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
@@ -363,17 +363,10 @@ export function WorkspaceSessionList({
|
|||||||
};
|
};
|
||||||
const archive = async (s: Session) => {
|
const archive = async (s: Session) => {
|
||||||
if (sessionWorktreeName(lane, s) && !runFor(s)) return setArchiving(s);
|
if (sessionWorktreeName(lane, s) && !runFor(s)) return setArchiving(s);
|
||||||
// A live one keeps running in its tab; archiving only hides its row.
|
// A live one is stopped first, as the tab's X does: archiving only its row
|
||||||
if (
|
// left a pane running that no list showed any more.
|
||||||
runFor(s) &&
|
const run = runFor(s);
|
||||||
!(await confirmDialog({
|
if (run && !(await endRuns([run], { name: s.name || t("tree.newSession"), t })).length) return;
|
||||||
title: t("tree.archiveLiveTitle"),
|
|
||||||
message: t("tree.archiveLiveBody"),
|
|
||||||
confirmLabel: t("sessionMenu.archive"),
|
|
||||||
destructive: false,
|
|
||||||
}))
|
|
||||||
)
|
|
||||||
return;
|
|
||||||
await patch(s, { archived: true });
|
await patch(s, { archived: true });
|
||||||
};
|
};
|
||||||
const archiveWithWorktree = async (s: Session) => {
|
const archiveWithWorktree = async (s: Session) => {
|
||||||
|
|||||||
@@ -544,7 +544,7 @@ describe("LaneChangesPanel", () => {
|
|||||||
expect(screen.queryByTestId("lane-file-editor")).toBeNull();
|
expect(screen.queryByTestId("lane-file-editor")).toBeNull();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("opens a whole HTML file as its source, the page after Preview, the source after Whole file", async () => {
|
it("opens a whole HTML file as its source, the page in a modal after Preview", async () => {
|
||||||
vi.mocked(api.lanes.gitTree).mockResolvedValue({
|
vi.mocked(api.lanes.gitTree).mockResolvedValue({
|
||||||
available: true,
|
available: true,
|
||||||
path: "",
|
path: "",
|
||||||
@@ -560,22 +560,31 @@ describe("LaneChangesPanel", () => {
|
|||||||
lines: ["<p>deck</p>"],
|
lines: ["<p>deck</p>"],
|
||||||
sha: "c".repeat(40),
|
sha: "c".repeat(40),
|
||||||
});
|
});
|
||||||
const user = userEvent.setup();
|
const fetchSpy = vi
|
||||||
render(<LaneChangesPanel laneId={7} full />);
|
.spyOn(globalThis, "fetch")
|
||||||
const sidebar = await screen.findByTestId("lane-changes-sidebar");
|
.mockResolvedValue(new Response("<p>deck</p>", { status: 200 }));
|
||||||
await user.click(await within(sidebar).findByText("deck.html"));
|
try {
|
||||||
expect(await screen.findByTestId("lane-file-editor")).toHaveValue("<p>deck</p>");
|
const user = userEvent.setup();
|
||||||
expect(screen.queryByTestId("html-frame")).toBeNull();
|
render(<LaneChangesPanel laneId={7} full />);
|
||||||
await user.click(screen.getByTestId("lane-file-preview"));
|
const sidebar = await screen.findByTestId("lane-changes-sidebar");
|
||||||
const frame = await screen.findByTestId("html-frame");
|
await user.click(await within(sidebar).findByText("deck.html"));
|
||||||
expect(frame.getAttribute("srcdoc")).toContain("<p>deck</p>");
|
expect(await screen.findByTestId("lane-file-editor")).toHaveValue("<p>deck</p>");
|
||||||
expect(screen.getByRole("button", { name: "Preview", pressed: true })).toBeInTheDocument();
|
expect(screen.queryByTestId("html-frame")).toBeNull();
|
||||||
await user.click(screen.getByRole("button", { name: "Whole file", pressed: false }));
|
await user.click(screen.getByTestId("lane-file-preview"));
|
||||||
expect(await screen.findByTestId("lane-file-editor")).toHaveValue("<p>deck</p>");
|
const modal = await screen.findByTestId("html-viewer");
|
||||||
expect(screen.queryByTestId("html-frame")).toBeNull();
|
const frame = await within(modal).findByTestId("html-frame");
|
||||||
|
expect(frame.getAttribute("srcdoc")).toContain("<p>deck</p>");
|
||||||
|
expect(frame.getAttribute("sandbox")).not.toContain("allow-same-origin");
|
||||||
|
await user.keyboard("{Escape}");
|
||||||
|
await waitFor(() => expect(screen.queryByTestId("html-viewer")).toBeNull());
|
||||||
|
// The source stayed where it was, under the modal.
|
||||||
|
expect(screen.getByTestId("lane-file-editor")).toHaveValue("<p>deck</p>");
|
||||||
|
} finally {
|
||||||
|
fetchSpy.mockRestore();
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
it("opens a changed HTML file on its Changes, the page only after Preview", async () => {
|
it("offers Preview on a changed HTML file's Changes, opening the page in a modal", async () => {
|
||||||
vi.mocked(api.lanes.changes).mockResolvedValue(
|
vi.mocked(api.lanes.changes).mockResolvedValue(
|
||||||
changes({
|
changes({
|
||||||
files: [
|
files: [
|
||||||
@@ -583,28 +592,21 @@ describe("LaneChangesPanel", () => {
|
|||||||
],
|
],
|
||||||
})
|
})
|
||||||
);
|
);
|
||||||
vi.mocked(api.lanes.gitFile).mockResolvedValue({
|
const fetchSpy = vi
|
||||||
available: true,
|
.spyOn(globalThis, "fetch")
|
||||||
path: "deck.html",
|
.mockResolvedValue(new Response("<p>deck</p>", { status: 200 }));
|
||||||
rev: "work",
|
try {
|
||||||
binary: false,
|
const user = userEvent.setup();
|
||||||
truncated: false,
|
render(<LaneChangesPanel laneId={7} />);
|
||||||
lines: ["<p>deck</p>"],
|
await user.click(await screen.findByTitle("deck.html"));
|
||||||
sha: "c".repeat(40),
|
await screen.findByRole("button", { name: "Changes", pressed: true });
|
||||||
});
|
await user.click(await screen.findByTestId("lane-file-preview"));
|
||||||
const user = userEvent.setup();
|
const modal = await screen.findByTestId("html-viewer");
|
||||||
render(<LaneChangesPanel laneId={7} />);
|
expect(await within(modal).findByTestId("html-frame")).toBeInTheDocument();
|
||||||
await user.click(await screen.findByTitle("deck.html"));
|
expect(screen.getByRole("button", { name: "Changes", pressed: true })).toBeInTheDocument();
|
||||||
await screen.findByRole("button", { name: "Changes", pressed: true });
|
} finally {
|
||||||
expect(screen.queryByTestId("html-frame")).toBeNull();
|
fetchSpy.mockRestore();
|
||||||
await user.click(await screen.findByTestId("lane-file-preview"));
|
}
|
||||||
const frame = await screen.findByTestId("html-frame");
|
|
||||||
expect(frame.getAttribute("srcdoc")).toContain("<p>deck</p>");
|
|
||||||
expect(frame.getAttribute("sandbox")).not.toContain("allow-same-origin");
|
|
||||||
// Back to Changes: the diff again, not the page.
|
|
||||||
await user.click(screen.getByRole("button", { name: "Changes", pressed: false }));
|
|
||||||
await screen.findByRole("button", { name: "Changes", pressed: true });
|
|
||||||
await waitFor(() => expect(screen.queryByTestId("html-frame")).toBeNull());
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it("shows an image file as the picture, with no edit control", async () => {
|
it("shows an image file as the picture, with no edit control", async () => {
|
||||||
|
|||||||
@@ -12,6 +12,8 @@
|
|||||||
* text file it read, wrote or named (a generated report) anywhere else through
|
* text file it read, wrote or named (a generated report) anywhere else through
|
||||||
* `GET /api/sessions/:id/file`.
|
* `GET /api/sessions/:id/file`.
|
||||||
* Anything else (or a file those routes refuse) shows its path only. A Windows path's `\` counts as `/` throughout.
|
* Anything else (or a file those routes refuse) shows its path only. A Windows path's `\` counts as `/` throughout.
|
||||||
|
* `FilePreview` with `modal` (an HTML page, from PaneChat) is the same view in
|
||||||
|
* a modal over the whole screen.
|
||||||
* `SkillListModal` is the same dialog over the session's skills, each one's
|
* `SkillListModal` is the same dialog over the session's skills, each one's
|
||||||
* SKILL.md found by name (`plugin:name` from the plugin list, else the user's
|
* SKILL.md found by name (`plugin:name` from the plugin list, else the user's
|
||||||
* or the project's); a built-in skill has no file and shows by name only.
|
* or the project's); a built-in skill has no file and shows by name only.
|
||||||
@@ -357,6 +359,7 @@ export function FilePreview({
|
|||||||
onClose,
|
onClose,
|
||||||
className = "",
|
className = "",
|
||||||
messages,
|
messages,
|
||||||
|
modal = false,
|
||||||
}: {
|
}: {
|
||||||
path: string;
|
path: string;
|
||||||
scope: PreviewScope;
|
scope: PreviewScope;
|
||||||
@@ -364,12 +367,16 @@ export function FilePreview({
|
|||||||
className?: string;
|
className?: string;
|
||||||
/** The conversation, for the versions its Write/Edit calls left. */
|
/** The conversation, for the versions its Write/Edit calls left. */
|
||||||
messages?: TranscriptMessage[];
|
messages?: TranscriptMessage[];
|
||||||
|
/** A modal over the whole screen (backdrop, Esc closes) instead of a panel. */
|
||||||
|
modal?: boolean;
|
||||||
}) {
|
}) {
|
||||||
const { t } = useTranslation("run");
|
const { t } = useTranslation("run");
|
||||||
const kind = artifactKind(path);
|
const kind = artifactKind(path);
|
||||||
const loaded = useContent(path, scope);
|
const loaded = useContent(path, scope);
|
||||||
const [view, setView] = useState<View>(() => defaultView(path));
|
const [view, setView] = useState<View>(() => defaultView(path));
|
||||||
const [full, setFull] = useState(false);
|
const [full, setFull] = useState(false);
|
||||||
|
const modalRef = useRef<HTMLDivElement>(null);
|
||||||
|
useDialog(modal, modalRef, onClose);
|
||||||
const [sharing, setSharing] = useState(false);
|
const [sharing, setSharing] = useState(false);
|
||||||
const versions = useMemo(
|
const versions = useMemo(
|
||||||
() => (messages ? artifactVersions(messages, path) : []),
|
() => (messages ? artifactVersions(messages, path) : []),
|
||||||
@@ -424,7 +431,9 @@ export function FilePreview({
|
|||||||
<section
|
<section
|
||||||
data-testid="chat-file-preview"
|
data-testid="chat-file-preview"
|
||||||
className={
|
className={
|
||||||
full
|
modal
|
||||||
|
? "flex h-[92vh] w-[96vw] max-w-7xl min-h-0 min-w-0 flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-2xl shadow-black/50"
|
||||||
|
: full
|
||||||
? "fixed inset-4 z-[200] flex min-h-0 min-w-0 flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-2xl"
|
? "fixed inset-4 z-[200] flex min-h-0 min-w-0 flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-2xl"
|
||||||
: `flex min-h-0 min-w-0 flex-col overflow-hidden bg-surface-1 ${className}`
|
: `flex min-h-0 min-w-0 flex-col overflow-hidden bg-surface-1 ${className}`
|
||||||
}
|
}
|
||||||
@@ -522,16 +531,18 @@ export function FilePreview({
|
|||||||
<Share2 className="h-3.5 w-3.5" />
|
<Share2 className="h-3.5 w-3.5" />
|
||||||
)}
|
)}
|
||||||
</button>
|
</button>
|
||||||
<button
|
{!modal && (
|
||||||
type="button"
|
<button
|
||||||
data-testid="artifact-expand"
|
type="button"
|
||||||
onClick={() => setFull((f) => !f)}
|
data-testid="artifact-expand"
|
||||||
title={t(full ? "chat.artifact.collapse" : "chat.artifact.expand")}
|
onClick={() => setFull((f) => !f)}
|
||||||
aria-label={t(full ? "chat.artifact.collapse" : "chat.artifact.expand")}
|
title={t(full ? "chat.artifact.collapse" : "chat.artifact.expand")}
|
||||||
className={iconBtn}
|
aria-label={t(full ? "chat.artifact.collapse" : "chat.artifact.expand")}
|
||||||
>
|
className={iconBtn}
|
||||||
{full ? <Minimize2 className="h-3.5 w-3.5" /> : <Maximize2 className="h-3.5 w-3.5" />}
|
>
|
||||||
</button>
|
{full ? <Minimize2 className="h-3.5 w-3.5" /> : <Maximize2 className="h-3.5 w-3.5" />}
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={onClose}
|
onClick={onClose}
|
||||||
@@ -546,6 +557,32 @@ export function FilePreview({
|
|||||||
<Body path={path} content={content} view={view} scope={scope} />
|
<Body path={path} content={content} view={view} scope={scope} />
|
||||||
</section>
|
</section>
|
||||||
);
|
);
|
||||||
|
if (modal) {
|
||||||
|
return createPortal(
|
||||||
|
<div
|
||||||
|
className="fixed inset-0 z-[70] flex items-center justify-center bg-black/60 p-3"
|
||||||
|
onClick={onClose}
|
||||||
|
onKeyDown={(e) => {
|
||||||
|
// Nothing reaches the view underneath — so Esc, which useDialog's
|
||||||
|
// document listener would never see, closes here.
|
||||||
|
e.stopPropagation();
|
||||||
|
if (e.key === "Escape") onClose();
|
||||||
|
}}
|
||||||
|
role="presentation"
|
||||||
|
>
|
||||||
|
<div
|
||||||
|
ref={modalRef}
|
||||||
|
role="dialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-label={displayName(path)}
|
||||||
|
onClick={(e) => e.stopPropagation()}
|
||||||
|
>
|
||||||
|
{panel}
|
||||||
|
</div>
|
||||||
|
</div>,
|
||||||
|
document.body
|
||||||
|
);
|
||||||
|
}
|
||||||
// Full screen: over the whole page, where a pane's edges cannot clip it.
|
// Full screen: over the whole page, where a pane's edges cannot clip it.
|
||||||
return full ? createPortal(panel, document.body) : panel;
|
return full ? createPortal(panel, document.body) : panel;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -35,7 +35,9 @@
|
|||||||
* of files or the used skills a list with a preview (`FileListModal`,
|
* of files or the used skills a list with a preview (`FileListModal`,
|
||||||
* `SkillListModal`). Anything there drags into the prompt box. A file in a turn's
|
* `SkillListModal`). Anything there drags into the prompt box. A file in a turn's
|
||||||
* "Edited N files" card opens in the Workspace's Changes panel
|
* "Edited N files" card opens in the Workspace's Changes panel
|
||||||
* (`openInChanges`) when it lies in the pane's folder. The unsent prompt and
|
* (`openInChanges`) when it lies in the pane's folder. An HTML file — a card,
|
||||||
|
* an Outputs row, a path in a reply — opens instead as the page, the same
|
||||||
|
* preview in a modal over the whole screen. The unsent prompt and
|
||||||
* its attachments are kept per session (`lib/chatDraft.ts`), so a reload
|
* its attachments are kept per session (`lib/chatDraft.ts`), so a reload
|
||||||
* leaves them as typed; switching to the terminal pastes them into its input
|
* leaves them as typed; switching to the terminal pastes them into its input
|
||||||
* box and back brings that box's text here (`ChatToggle`). A send scrolls the
|
* box and back brings that box's text here (`ChatToggle`). A send scrolls the
|
||||||
@@ -582,6 +584,12 @@ export const PaneChat = memo(function PaneChat({
|
|||||||
setPreview(null);
|
setPreview(null);
|
||||||
};
|
};
|
||||||
const [preview, setPreview] = useState<string | null>(null);
|
const [preview, setPreview] = useState<string | null>(null);
|
||||||
|
// An HTML file shown as the page, in a modal over the screen.
|
||||||
|
const [htmlView, setHtmlView] = useState<string | null>(null);
|
||||||
|
const show = useCallback(
|
||||||
|
(path: string) => (/\.html?$/i.test(path) ? setHtmlView(path) : setPreview(path)),
|
||||||
|
[]
|
||||||
|
);
|
||||||
// The side panel's width as a fraction of the pane: the dragged one, else
|
// The side panel's width as a fraction of the pane: the dragged one, else
|
||||||
// a default per content (a preview wants more room than the panel).
|
// a default per content (a preview wants more room than the panel).
|
||||||
const [dragged, setDragged] = useState(storedSide);
|
const [dragged, setDragged] = useState(storedSide);
|
||||||
@@ -757,20 +765,21 @@ export const PaneChat = memo(function PaneChat({
|
|||||||
// not the workspace's Changes panel a plain file link goes to.
|
// not the workspace's Changes panel a plain file link goes to.
|
||||||
const openArtifact = useCallback(
|
const openArtifact = useCallback(
|
||||||
(named: string) => {
|
(named: string) => {
|
||||||
setPreview(resolveIn(cwd, named));
|
show(resolveIn(cwd, named));
|
||||||
},
|
},
|
||||||
[cwd]
|
[cwd, show]
|
||||||
);
|
);
|
||||||
const openFile = useCallback(
|
const openFile = useCallback(
|
||||||
(named: string) => {
|
(named: string) => {
|
||||||
// A relative path in a reply (`server/lib/x.js`) is relative to this pane's folder.
|
// A relative path in a reply (`server/lib/x.js`) is relative to this pane's folder.
|
||||||
const path = resolveIn(cwd, named);
|
const path = resolveIn(cwd, named);
|
||||||
|
if (/\.html?$/i.test(path)) return show(path);
|
||||||
// The workspace's Changes panel when the file is in its folder;
|
// The workspace's Changes panel when the file is in its folder;
|
||||||
// else this view's own preview.
|
// else this view's own preview.
|
||||||
if (laneId !== null && openInChanges(laneId, cwd, path)) return;
|
if (laneId !== null && openInChanges(laneId, cwd, path)) return;
|
||||||
setPreview(path);
|
setPreview(path);
|
||||||
},
|
},
|
||||||
[laneId, cwd]
|
[laneId, cwd, show]
|
||||||
);
|
);
|
||||||
|
|
||||||
// Before the session starts the CLI may be asking in the terminal (trust
|
// Before the session starts the CLI may be asking in the terminal (trust
|
||||||
@@ -984,7 +993,7 @@ export const PaneChat = memo(function PaneChat({
|
|||||||
<ChatOutline
|
<ChatOutline
|
||||||
outline={activity}
|
outline={activity}
|
||||||
onClose={() => openOutline(false)}
|
onClose={() => openOutline(false)}
|
||||||
onOpenFile={setPreview}
|
onOpenFile={show}
|
||||||
onOpenList={setList}
|
onOpenList={setList}
|
||||||
/>
|
/>
|
||||||
)
|
)
|
||||||
@@ -1006,6 +1015,15 @@ export const PaneChat = memo(function PaneChat({
|
|||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
{htmlView && (
|
||||||
|
<FilePreview
|
||||||
|
path={htmlView}
|
||||||
|
scope={scope}
|
||||||
|
messages={convMessages}
|
||||||
|
onClose={() => setHtmlView(null)}
|
||||||
|
modal
|
||||||
|
/>
|
||||||
|
)}
|
||||||
{list === "skills" && (
|
{list === "skills" && (
|
||||||
<SkillListModal
|
<SkillListModal
|
||||||
title={t("chat.outline.skills")}
|
title={t("chat.outline.skills")}
|
||||||
|
|||||||
@@ -468,7 +468,8 @@ export const TerminalView = memo(function TerminalView({
|
|||||||
// A terminal mounted on a hidden tab sits in a 0×0 box (`display:none`):
|
// A terminal mounted on a hidden tab sits in a 0×0 box (`display:none`):
|
||||||
// fitting it there shrinks xterm to its 12×6 minimum, and that size would
|
// fitting it there shrinks xterm to its 12×6 minimum, and that size would
|
||||||
// reach tmux with the attach. It stays unfitted until it is shown.
|
// reach tmux with the attach. It stays unfitted until it is shown.
|
||||||
const hasBox = () => !!containerRef.current?.clientWidth && !!containerRef.current.clientHeight;
|
const hasBox = () =>
|
||||||
|
!!containerRef.current?.clientWidth && !!containerRef.current.clientHeight;
|
||||||
if (hasBox()) fit.fit();
|
if (hasBox()) fit.fit();
|
||||||
// Take the keyboard as soon as the pane is on screen: the terminal IS the
|
// Take the keyboard as soon as the pane is on screen: the terminal IS the
|
||||||
// page here, and having to click it first meant the first thing typed went
|
// page here, and having to click it first meant the first thing typed went
|
||||||
@@ -761,6 +762,16 @@ export const TerminalView = memo(function TerminalView({
|
|||||||
refit();
|
refit();
|
||||||
};
|
};
|
||||||
document.fonts?.addEventListener("loadingdone", onFontLoaded);
|
document.fonts?.addEventListener("loadingdone", onFontLoaded);
|
||||||
|
// The browser may drop or reuse the WebGL glyph atlas's GPU memory without
|
||||||
|
// a context-loss event (sleep/resume, a long-backgrounded tab, a display or
|
||||||
|
// zoom change on macOS): xterm keeps slicing the old coordinates and every
|
||||||
|
// cell shows a clipped or foreign glyph while the buffer stays correct.
|
||||||
|
// Rebuilding the atlas when the page comes back is cheap and redraws clean.
|
||||||
|
const onPageShown = () => {
|
||||||
|
if (document.visibilityState === "visible") term.clearTextureAtlas();
|
||||||
|
};
|
||||||
|
document.addEventListener("visibilitychange", onPageShown);
|
||||||
|
window.addEventListener("focus", onPageShown);
|
||||||
// Settings → Appearance changed the terminal's font or size: an open
|
// Settings → Appearance changed the terminal's font or size: an open
|
||||||
// pane takes it now, re-measured and re-fitted like a font landing.
|
// pane takes it now, re-measured and re-fitted like a font landing.
|
||||||
const onFontPref = () => {
|
const onFontPref = () => {
|
||||||
@@ -779,6 +790,8 @@ export const TerminalView = memo(function TerminalView({
|
|||||||
searchRef.current = null;
|
searchRef.current = null;
|
||||||
resizeObserver.disconnect();
|
resizeObserver.disconnect();
|
||||||
document.fonts?.removeEventListener("loadingdone", onFontLoaded);
|
document.fonts?.removeEventListener("loadingdone", onFontLoaded);
|
||||||
|
document.removeEventListener("visibilitychange", onPageShown);
|
||||||
|
window.removeEventListener("focus", onPageShown);
|
||||||
window.removeEventListener(FONT_SIZE_EVENT, onFontPref);
|
window.removeEventListener(FONT_SIZE_EVENT, onFontPref);
|
||||||
term.textarea?.removeEventListener("focus", reassert);
|
term.textarea?.removeEventListener("focus", reassert);
|
||||||
detachIme();
|
detachIme();
|
||||||
|
|||||||
@@ -217,6 +217,17 @@ describe("the artifact view", () => {
|
|||||||
cleanup();
|
cleanup();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("shows a page as a modal over the screen, closed by Esc", async () => {
|
||||||
|
const onClose = vi.fn();
|
||||||
|
render(<FilePreview path="/w/page.html" scope={scope} onClose={onClose} modal />);
|
||||||
|
const dialog = await screen.findByRole("dialog", { name: "page.html" });
|
||||||
|
expect(dialog.parentElement?.parentElement).toBe(document.body);
|
||||||
|
expect(await screen.findByTestId("artifact-frame")).toBeInTheDocument();
|
||||||
|
expect(screen.queryByTestId("artifact-expand")).toBeNull();
|
||||||
|
fireEvent.keyDown(screen.getByTestId("artifact-tab-code"), { key: "Escape" });
|
||||||
|
expect(onClose).toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
it("steps back to an older version the conversation wrote", async () => {
|
it("steps back to an older version the conversation wrote", async () => {
|
||||||
html(["<p>two</p>"]);
|
html(["<p>two</p>"]);
|
||||||
const tool = (id: string, input: Record<string, unknown>, name = "Write") => ({
|
const tool = (id: string, input: Record<string, unknown>, name = "Write") => ({
|
||||||
|
|||||||
@@ -262,11 +262,11 @@ function LabelEdit({
|
|||||||
function useRunner(load: () => Promise<unknown>) {
|
function useRunner(load: () => Promise<unknown>) {
|
||||||
const [busy, setBusy] = useState<string | null>(null);
|
const [busy, setBusy] = useState<string | null>(null);
|
||||||
const run = useCallback(
|
const run = useCallback(
|
||||||
async (key: string, fn: () => Promise<unknown>, success: string) => {
|
async <T,>(key: string, fn: () => Promise<T>, success: string | ((r: T) => string)) => {
|
||||||
setBusy(key);
|
setBusy(key);
|
||||||
try {
|
try {
|
||||||
await fn();
|
const r = await fn();
|
||||||
toast.success(success);
|
toast.success(typeof success === "function" ? success(r) : success);
|
||||||
await load();
|
await load();
|
||||||
} catch (err: unknown) {
|
} catch (err: unknown) {
|
||||||
toast.error(err);
|
toast.error(err);
|
||||||
@@ -399,7 +399,14 @@ function OtherProfiles({
|
|||||||
void run(
|
void run(
|
||||||
`switch:${p.name}`,
|
`switch:${p.name}`,
|
||||||
() => api.toolProfiles.activate(tool, p.name),
|
() => api.toolProfiles.activate(tool, p.name),
|
||||||
t("toolProfiles.switchSuccess", { name: p.label, tool: label })
|
(r) =>
|
||||||
|
t(
|
||||||
|
r.following ? "toolProfiles.switchFollowing" : "toolProfiles.switchSuccess",
|
||||||
|
{
|
||||||
|
name: p.label,
|
||||||
|
tool: label,
|
||||||
|
}
|
||||||
|
)
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
className={btnCls}
|
className={btnCls}
|
||||||
@@ -800,9 +807,7 @@ function ProfileUsageLine({
|
|||||||
|
|
||||||
/** Org / seat / plan line shared by the active card and each profile row. */
|
/** Org / seat / plan line shared by the active card and each profile row. */
|
||||||
function IdentityLine({ identity }: { identity: CcAccountIdentity }) {
|
function IdentityLine({ identity }: { identity: CcAccountIdentity }) {
|
||||||
const parts = [identity.organization, identity.plan || identity.subscriptionType].filter(
|
const parts = [identity.organization, identity.plan || identity.subscriptionType].filter(Boolean);
|
||||||
Boolean
|
|
||||||
);
|
|
||||||
if (parts.length === 0) return null;
|
if (parts.length === 0) return null;
|
||||||
return <div className="text-[10px] text-fg-muted mt-0.5">{parts.join(" · ")}</div>;
|
return <div className="text-[10px] text-fg-muted mt-0.5">{parts.join(" · ")}</div>;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ import { useTranslation } from "react-i18next";
|
|||||||
import { Search } from "lucide-react";
|
import { Search } from "lucide-react";
|
||||||
import type { AuthUser, ServerUserUsage } from "../../lib/api";
|
import type { AuthUser, ServerUserUsage } from "../../lib/api";
|
||||||
import { Checkbox } from "../Checkbox";
|
import { Checkbox } from "../Checkbox";
|
||||||
|
import { UserAvatar } from "./UserAvatar";
|
||||||
|
|
||||||
export const ROLES: AuthUser["role"][] = ["admin", "developer", "analyst"];
|
export const ROLES: AuthUser["role"][] = ["admin", "developer", "analyst"];
|
||||||
/** A role, every user, or the users in no pool group. */
|
/** A role, every user, or the users in no pool group. */
|
||||||
@@ -168,7 +169,14 @@ export function MemberPicker({
|
|||||||
checked={chosen.has(u.id)}
|
checked={chosen.has(u.id)}
|
||||||
onChange={(on) => setMany([u.id], on)}
|
onChange={(on) => setMany([u.id], on)}
|
||||||
label={
|
label={
|
||||||
<span>
|
<span className="inline-flex items-center gap-1.5">
|
||||||
|
<UserAvatar
|
||||||
|
name={u.displayName || u.username}
|
||||||
|
userId={u.id}
|
||||||
|
avatarAt={u.avatarAt}
|
||||||
|
letters={1}
|
||||||
|
className="h-5 w-5 text-[10px]"
|
||||||
|
/>
|
||||||
{u.username}
|
{u.username}
|
||||||
{u.disabled && <span className="ml-1 text-fg-muted">({t("disabled")})</span>}
|
{u.disabled && <span className="ml-1 text-fg-muted">({t("disabled")})</span>}
|
||||||
{note?.(u)}
|
{note?.(u)}
|
||||||
|
|||||||
@@ -36,6 +36,7 @@ import { toast } from "../../lib/toast";
|
|||||||
import { ConfirmModal } from "../ConfirmModal";
|
import { ConfirmModal } from "../ConfirmModal";
|
||||||
import { AiToolIcon } from "../AiToolIcon";
|
import { AiToolIcon } from "../AiToolIcon";
|
||||||
import { MemberPicker } from "./MemberPicker";
|
import { MemberPicker } from "./MemberPicker";
|
||||||
|
import { UserAvatar } from "./UserAvatar";
|
||||||
|
|
||||||
/** Pool tools with their labels, in display order. */
|
/** Pool tools with their labels, in display order. */
|
||||||
export const POOL_TOOL_LABELS: { id: PoolTool; label: string }[] = [
|
export const POOL_TOOL_LABELS: { id: PoolTool; label: string }[] = [
|
||||||
@@ -363,12 +364,13 @@ export function PoolGroups({
|
|||||||
} ${isDragged(drag) ? "opacity-40" : ""}`}
|
} ${isDragged(drag) ? "opacity-40" : ""}`}
|
||||||
data-testid="pool-member"
|
data-testid="pool-member"
|
||||||
>
|
>
|
||||||
<span
|
<UserAvatar
|
||||||
className="flex h-4 w-4 items-center justify-center rounded-full bg-accent/15 text-[9px] font-semibold uppercase text-accent"
|
name={name}
|
||||||
aria-hidden
|
userId={id}
|
||||||
>
|
avatarAt={u?.avatarAt}
|
||||||
{name.charAt(0)}
|
letters={1}
|
||||||
</span>
|
className="h-4 w-4 text-[9px]"
|
||||||
|
/>
|
||||||
{name}
|
{name}
|
||||||
{u && <span className="text-[10px] text-fg-muted">{t(`roles.${u.role}`)}</span>}
|
{u && <span className="text-[10px] text-fg-muted">{t(`roles.${u.role}`)}</span>}
|
||||||
{isAdmin && from && (
|
{isAdmin && from && (
|
||||||
|
|||||||
@@ -4,7 +4,9 @@
|
|||||||
* (`GET /api/me/avatar`) or, with `userId`, another's (`GET
|
* (`GET /api/me/avatar`) or, with `userId`, another's (`GET
|
||||||
* /api/users/:id/avatar`, staff only), versioned by `avatarAt`; without one —
|
* /api/users/:id/avatar`, staff only), versioned by `avatarAt`; without one —
|
||||||
* or when the image fails to load — the first letters of its name. Used by the
|
* or when the image fails to load — the first letters of its name. Used by the
|
||||||
* sidebar's account row, its workspace owner groups and Settings → Account.
|
* sidebar's account row, its workspace owner groups, Settings → Account, the
|
||||||
|
* Users page and its editor, the pool board and member picker, and System
|
||||||
|
* Health's per-user CPU/RAM card.
|
||||||
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
|||||||
@@ -33,6 +33,7 @@ import { copyText } from "../../lib/clipboard";
|
|||||||
import { isSubmitEnter } from "../../lib/keys";
|
import { isSubmitEnter } from "../../lib/keys";
|
||||||
import { passwordProblems } from "../../lib/passwordRules";
|
import { passwordProblems } from "../../lib/passwordRules";
|
||||||
import { PasswordRules } from "./PasswordRules";
|
import { PasswordRules } from "./PasswordRules";
|
||||||
|
import { UserAvatar } from "./UserAvatar";
|
||||||
import { useDialog } from "../../hooks/useDialog";
|
import { useDialog } from "../../hooks/useDialog";
|
||||||
import { Switch } from "../Switch";
|
import { Switch } from "../Switch";
|
||||||
import { Checkbox } from "../Checkbox";
|
import { Checkbox } from "../Checkbox";
|
||||||
@@ -243,12 +244,12 @@ export function UserEditDialog({
|
|||||||
className="flex max-h-[90vh] w-full max-w-2xl flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-xl"
|
className="flex max-h-[90vh] w-full max-w-2xl flex-col overflow-hidden rounded-xl border border-border bg-surface-1 shadow-xl"
|
||||||
>
|
>
|
||||||
<div className="flex items-start gap-3 border-b border-border px-5 py-4">
|
<div className="flex items-start gap-3 border-b border-border px-5 py-4">
|
||||||
<span
|
<UserAvatar
|
||||||
aria-hidden
|
name={shown}
|
||||||
className="flex h-10 w-10 flex-shrink-0 items-center justify-center rounded-full bg-accent/15 text-sm font-semibold uppercase text-accent"
|
userId={user.id}
|
||||||
>
|
avatarAt={user.avatarAt}
|
||||||
{shown.slice(0, 2)}
|
className="h-10 w-10 text-sm"
|
||||||
</span>
|
/>
|
||||||
<div className="min-w-0 flex-1">
|
<div className="min-w-0 flex-1">
|
||||||
<h2 id="user-edit-title" className="text-base font-semibold text-fg-primary">
|
<h2 id="user-edit-title" className="text-base font-semibold text-fg-primary">
|
||||||
{t("edit.title", { name: user.displayName || user.username })}
|
{t("edit.title", { name: user.displayName || user.username })}
|
||||||
|
|||||||
@@ -33,7 +33,7 @@ const accountPool = vi.hoisted(() => ({
|
|||||||
updateGroup: vi.fn(),
|
updateGroup: vi.fn(),
|
||||||
deleteGroup: vi.fn(),
|
deleteGroup: vi.fn(),
|
||||||
}));
|
}));
|
||||||
const users = vi.hoisted(() => ({ list: vi.fn() }));
|
const users = vi.hoisted(() => ({ list: vi.fn(), avatarUrl: () => null }));
|
||||||
const aiTools = vi.hoisted(() => ({
|
const aiTools = vi.hoisted(() => ({
|
||||||
list: vi.fn(),
|
list: vi.fn(),
|
||||||
ompSharing: vi.fn(),
|
ompSharing: vi.fn(),
|
||||||
|
|||||||
@@ -13,7 +13,12 @@ import { render, screen, waitFor } from "@testing-library/react";
|
|||||||
import userEvent from "@testing-library/user-event";
|
import userEvent from "@testing-library/user-event";
|
||||||
import type { ServerUserUsage } from "../../../lib/api";
|
import type { ServerUserUsage } from "../../../lib/api";
|
||||||
|
|
||||||
const users = vi.hoisted(() => ({ get: vi.fn(), update: vi.fn(), remove: vi.fn() }));
|
const users = vi.hoisted(() => ({
|
||||||
|
get: vi.fn(),
|
||||||
|
update: vi.fn(),
|
||||||
|
remove: vi.fn(),
|
||||||
|
avatarUrl: () => null,
|
||||||
|
}));
|
||||||
const confirmDialog = vi.hoisted(() => vi.fn());
|
const confirmDialog = vi.hoisted(() => vi.fn());
|
||||||
vi.mock("../../../lib/confirm", () => ({ confirmDialog }));
|
vi.mock("../../../lib/confirm", () => ({ confirmDialog }));
|
||||||
const lanes = vi.hoisted(() => ({ list: vi.fn() }));
|
const lanes = vi.hoisted(() => ({ list: vi.fn() }));
|
||||||
|
|||||||
@@ -16,6 +16,7 @@ const users = vi.hoisted(() => ({
|
|||||||
setQuotaDefault: vi.fn(),
|
setQuotaDefault: vi.fn(),
|
||||||
update: vi.fn(),
|
update: vi.fn(),
|
||||||
get: vi.fn(),
|
get: vi.fn(),
|
||||||
|
avatarUrl: () => null,
|
||||||
}));
|
}));
|
||||||
const lanes = vi.hoisted(() => ({ list: vi.fn() }));
|
const lanes = vi.hoisted(() => ({ list: vi.fn() }));
|
||||||
vi.mock("../../../lib/api", async (importOriginal) => {
|
vi.mock("../../../lib/api", async (importOriginal) => {
|
||||||
|
|||||||
@@ -505,8 +505,6 @@
|
|||||||
"changes.loadMore": "Load more commits",
|
"changes.loadMore": "Load more commits",
|
||||||
"changes.commentPasted": "Pasted into tab {{tab}} — press Enter there to send it",
|
"changes.commentPasted": "Pasted into tab {{tab}} — press Enter there to send it",
|
||||||
"changes.splitter": "Resize the changes panel",
|
"changes.splitter": "Resize the changes panel",
|
||||||
"tree.archiveLiveTitle": "Archive a live session?",
|
|
||||||
"tree.archiveLiveBody": "Its tab keeps running; archiving only hides it from this list. Unarchive it from the archived fold.",
|
|
||||||
"tree.state.awaiting": "waiting for you",
|
"tree.state.awaiting": "waiting for you",
|
||||||
"tree.state.error": "error",
|
"tree.state.error": "error",
|
||||||
"tree.state.live": "live",
|
"tree.state.live": "live",
|
||||||
|
|||||||
@@ -1396,6 +1396,7 @@
|
|||||||
"noActive": "{{tool}} holds no login on this machine.",
|
"noActive": "{{tool}} holds no login on this machine.",
|
||||||
"noProfiles": "Could not load the profiles.",
|
"noProfiles": "Could not load the profiles.",
|
||||||
"switchSuccess": "Switched {{tool}} to \"{{name}}\". Start a new session to use it.",
|
"switchSuccess": "Switched {{tool}} to \"{{name}}\". Start a new session to use it.",
|
||||||
|
"switchFollowing": "Switched {{tool}} to \"{{name}}\" — running sessions follow it.",
|
||||||
"deleteConfirmBody": "This removes the saved {{tool}} login. To use it again, sign in from a terminal and save it once more.",
|
"deleteConfirmBody": "This removes the saved {{tool}} login. To use it again, sign in from a terminal and save it once more.",
|
||||||
"loginHint": "Add another {{tool}} login by signing in from a terminal first:",
|
"loginHint": "Add another {{tool}} login by signing in from a terminal first:",
|
||||||
"subtitle": {
|
"subtitle": {
|
||||||
|
|||||||
@@ -79,6 +79,7 @@
|
|||||||
"EBADUSER": "Username: letters, digits, '.', '_' or '-' (up to 64).",
|
"EBADUSER": "Username: letters, digits, '.', '_' or '-' (up to 64).",
|
||||||
"EBADPASSWORD": "Password cannot be empty.",
|
"EBADPASSWORD": "Password cannot be empty.",
|
||||||
"EBADEMAIL": "That email address does not look valid.",
|
"EBADEMAIL": "That email address does not look valid.",
|
||||||
|
"ENAMETAKEN": "Another account already uses that name. Pick one that is yours.",
|
||||||
"EBADFIELD": "One of the values is not valid.",
|
"EBADFIELD": "One of the values is not valid.",
|
||||||
"ENOLANE": "That workspace no longer exists.",
|
"ENOLANE": "That workspace no longer exists.",
|
||||||
"ENOTOWNED": "That workspace is not this user's any more.",
|
"ENOTOWNED": "That workspace is not this user's any more.",
|
||||||
|
|||||||
@@ -505,8 +505,6 @@
|
|||||||
"changes.loadMore": "Tải thêm commit",
|
"changes.loadMore": "Tải thêm commit",
|
||||||
"changes.commentPasted": "Đã dán vào tab {{tab}} — nhấn Enter ở đó để gửi",
|
"changes.commentPasted": "Đã dán vào tab {{tab}} — nhấn Enter ở đó để gửi",
|
||||||
"changes.splitter": "Đổi độ rộng khung thay đổi",
|
"changes.splitter": "Đổi độ rộng khung thay đổi",
|
||||||
"tree.archiveLiveTitle": "Lưu trữ một session đang chạy?",
|
|
||||||
"tree.archiveLiveBody": "Tab của nó vẫn chạy; lưu trữ chỉ ẩn nó khỏi danh sách này. Bỏ lưu trữ trong mục đã lưu trữ.",
|
|
||||||
"tree.state.awaiting": "đang chờ bạn",
|
"tree.state.awaiting": "đang chờ bạn",
|
||||||
"tree.state.error": "lỗi",
|
"tree.state.error": "lỗi",
|
||||||
"tree.state.live": "đang chạy",
|
"tree.state.live": "đang chạy",
|
||||||
|
|||||||
@@ -1384,6 +1384,7 @@
|
|||||||
"noActive": "{{tool}} chưa có đăng nhập nào trên máy này.",
|
"noActive": "{{tool}} chưa có đăng nhập nào trên máy này.",
|
||||||
"noProfiles": "Không tải được danh sách hồ sơ.",
|
"noProfiles": "Không tải được danh sách hồ sơ.",
|
||||||
"switchSuccess": "Đã chuyển {{tool}} sang \"{{name}}\". Mở phiên mới để dùng.",
|
"switchSuccess": "Đã chuyển {{tool}} sang \"{{name}}\". Mở phiên mới để dùng.",
|
||||||
|
"switchFollowing": "Đã chuyển {{tool}} sang \"{{name}}\" — các phiên đang chạy theo luôn.",
|
||||||
"deleteConfirmBody": "Thao tác này xoá đăng nhập {{tool}} đã lưu. Muốn dùng lại, hãy đăng nhập từ terminal và lưu lại lần nữa.",
|
"deleteConfirmBody": "Thao tác này xoá đăng nhập {{tool}} đã lưu. Muốn dùng lại, hãy đăng nhập từ terminal và lưu lại lần nữa.",
|
||||||
"loginHint": "Thêm đăng nhập {{tool}} khác bằng cách đăng nhập từ terminal trước:",
|
"loginHint": "Thêm đăng nhập {{tool}} khác bằng cách đăng nhập từ terminal trước:",
|
||||||
"subtitle": {
|
"subtitle": {
|
||||||
|
|||||||
@@ -79,6 +79,7 @@
|
|||||||
"EBADUSER": "Tên đăng nhập: chữ, số, '.', '_' hoặc '-' (tối đa 64 ký tự).",
|
"EBADUSER": "Tên đăng nhập: chữ, số, '.', '_' hoặc '-' (tối đa 64 ký tự).",
|
||||||
"EBADPASSWORD": "Mật khẩu không được để trống.",
|
"EBADPASSWORD": "Mật khẩu không được để trống.",
|
||||||
"EBADEMAIL": "Địa chỉ email không hợp lệ.",
|
"EBADEMAIL": "Địa chỉ email không hợp lệ.",
|
||||||
|
"ENAMETAKEN": "Tên này đã có tài khoản khác dùng. Hãy chọn tên của chính bạn.",
|
||||||
"EBADFIELD": "Có một giá trị không hợp lệ.",
|
"EBADFIELD": "Có một giá trị không hợp lệ.",
|
||||||
"ENOLANE": "Workspace đó không còn tồn tại.",
|
"ENOLANE": "Workspace đó không còn tồn tại.",
|
||||||
"ENOTOWNED": "Workspace đó không còn thuộc người này.",
|
"ENOTOWNED": "Workspace đó không còn thuộc người này.",
|
||||||
|
|||||||
@@ -684,6 +684,8 @@ export interface HostUsageGroup {
|
|||||||
username?: string;
|
username?: string;
|
||||||
/** The user's display name, null when none is set (absent from an older server). */
|
/** The user's display name, null when none is set (absent from an older server). */
|
||||||
displayName?: string | null;
|
displayName?: string | null;
|
||||||
|
/** When the user's avatar was last set (null = none; absent from an older server). */
|
||||||
|
avatarAt?: string | null;
|
||||||
/** % of the whole machine's CPU (100 = every core busy) over the sample. */
|
/** % of the whole machine's CPU (100 = every core busy) over the sample. */
|
||||||
cpu: number;
|
cpu: number;
|
||||||
/** Resident memory, bytes (shared pages count in every process). */
|
/** Resident memory, bytes (shared pages count in every process). */
|
||||||
@@ -1399,7 +1401,7 @@ export const api = {
|
|||||||
),
|
),
|
||||||
/** POST /api/tool-profiles/:tool/activate — the outgoing login is saved back first. */
|
/** POST /api/tool-profiles/:tool/activate — the outgoing login is saved back first. */
|
||||||
activate: (tool: string, name: string) =>
|
activate: (tool: string, name: string) =>
|
||||||
request<{ ok: true; name: string; savedOutgoing: string | null }>(
|
request<{ ok: true; name: string; savedOutgoing: string | null; following?: boolean }>(
|
||||||
`/tool-profiles/${encodeURIComponent(tool)}/activate`,
|
`/tool-profiles/${encodeURIComponent(tool)}/activate`,
|
||||||
{ method: "POST", body: JSON.stringify({ name }) }
|
{ method: "POST", body: JSON.stringify({ name }) }
|
||||||
),
|
),
|
||||||
|
|||||||
@@ -6,7 +6,8 @@
|
|||||||
* message. Both ask first when any pane holds an AI agent (it may be
|
* message. Both ask first when any pane holds an AI agent (it may be
|
||||||
* mid-turn); a plain shell holds no session, so it neither asks nor sleeps.
|
* mid-turn); a plain shell holds no session, so it neither asks nor sleeps.
|
||||||
* Used by the tab bar (`ConsoleTabs`), the split panes (`Workspace`) and a
|
* Used by the tab bar (`ConsoleTabs`), the split panes (`Workspace`) and a
|
||||||
* session's right-click menu (`SessionMenu`).
|
* session's right-click menu (`SessionMenu`), and a live session's Archive
|
||||||
|
* (`WorkspaceSessionList`, `WorkspaceHome`) — archiving never leaves a pane running.
|
||||||
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
|||||||
@@ -48,7 +48,8 @@
|
|||||||
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { useCallback, useEffect, useRef, useState } from "react";
|
import { useCallback, useEffect, useLayoutEffect, useRef, useState } from "react";
|
||||||
|
import { createPortal } from "react-dom";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import {
|
import {
|
||||||
ChevronRight,
|
ChevronRight,
|
||||||
@@ -1629,12 +1630,41 @@ function DetailDialog({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/** "N installs" on a card; a click lists who installed it, when, and where. */
|
/** "N installs" on a card; a click lists who installed it, when, and where.
|
||||||
|
* The list floats over the page (a portal at the button, below it or above
|
||||||
|
* when there is no room, kept inside the window): inside the card list's
|
||||||
|
* `overflow-hidden` it was cut off at the last card. */
|
||||||
function InstallsButton({ item }: { item: Artifact }) {
|
function InstallsButton({ item }: { item: Artifact }) {
|
||||||
const { t } = useTranslation("artifacts");
|
const { t } = useTranslation("artifacts");
|
||||||
const [open, setOpen] = useState(false);
|
const [open, setOpen] = useState(false);
|
||||||
const [data, setData] = useState<ArtifactInstalls | null>(null);
|
const [data, setData] = useState<ArtifactInstalls | null>(null);
|
||||||
const box = useRef<HTMLSpanElement>(null);
|
const box = useRef<HTMLSpanElement>(null);
|
||||||
|
const pop = useRef<HTMLDivElement>(null);
|
||||||
|
const [at, setAt] = useState<{ left: number; top: number } | null>(null);
|
||||||
|
|
||||||
|
useLayoutEffect(() => {
|
||||||
|
if (!open) return setAt(null);
|
||||||
|
const place = () => {
|
||||||
|
const b = box.current?.getBoundingClientRect();
|
||||||
|
const p = pop.current;
|
||||||
|
if (!b || !p) return;
|
||||||
|
const w = p.offsetWidth;
|
||||||
|
const h = p.offsetHeight;
|
||||||
|
const gap = 4;
|
||||||
|
const below = b.bottom + gap + h <= window.innerHeight - 8 || b.top - gap - h < 8;
|
||||||
|
setAt({
|
||||||
|
left: Math.max(8, Math.min(b.left, window.innerWidth - w - 8)),
|
||||||
|
top: below ? b.bottom + gap : b.top - gap - h,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
place();
|
||||||
|
window.addEventListener("resize", place);
|
||||||
|
window.addEventListener("scroll", place, true);
|
||||||
|
return () => {
|
||||||
|
window.removeEventListener("resize", place);
|
||||||
|
window.removeEventListener("scroll", place, true);
|
||||||
|
};
|
||||||
|
}, [open, data]);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!open) return;
|
if (!open) return;
|
||||||
@@ -1647,7 +1677,8 @@ function InstallsButton({ item }: { item: Artifact }) {
|
|||||||
toast.error(err);
|
toast.error(err);
|
||||||
});
|
});
|
||||||
const onDown = (e: MouseEvent) => {
|
const onDown = (e: MouseEvent) => {
|
||||||
if (!box.current?.contains(e.target as Node)) setOpen(false);
|
const n = e.target as Node;
|
||||||
|
if (!box.current?.contains(n) && !pop.current?.contains(n)) setOpen(false);
|
||||||
};
|
};
|
||||||
const onKey = (e: KeyboardEvent) => {
|
const onKey = (e: KeyboardEvent) => {
|
||||||
if (e.key === "Escape") setOpen(false);
|
if (e.key === "Escape") setOpen(false);
|
||||||
@@ -1670,66 +1701,70 @@ function InstallsButton({ item }: { item: Artifact }) {
|
|||||||
>
|
>
|
||||||
{t("installs", { count: item.installs })}
|
{t("installs", { count: item.installs })}
|
||||||
</button>
|
</button>
|
||||||
{open && (
|
{open &&
|
||||||
<div
|
createPortal(
|
||||||
role="dialog"
|
<div
|
||||||
aria-label={t("installsTitle")}
|
ref={pop}
|
||||||
data-testid="artifact-installs"
|
role="dialog"
|
||||||
className="absolute left-0 z-30 mt-1 w-80 max-w-[80vw] rounded-lg border border-border bg-surface-1 p-2 shadow-xl"
|
aria-label={t("installsTitle")}
|
||||||
>
|
data-testid="artifact-installs"
|
||||||
<p className="mb-1.5 px-1 text-xs font-medium text-fg-primary">{t("installsTitle")}</p>
|
style={at ? { left: at.left, top: at.top } : { left: 0, top: 0, visibility: "hidden" }}
|
||||||
{data === null ? (
|
className="fixed z-[60] w-80 max-w-[80vw] rounded-lg border border-border bg-surface-1 p-2 shadow-xl"
|
||||||
<p className="px-1 text-xs text-fg-muted">{t("loading")}</p>
|
>
|
||||||
) : (
|
<p className="mb-1.5 px-1 text-xs font-medium text-fg-primary">{t("installsTitle")}</p>
|
||||||
<ul className="max-h-64 space-y-1 overflow-auto">
|
{data === null ? (
|
||||||
{data.items.map((i, n) => (
|
<p className="px-1 text-xs text-fg-muted">{t("loading")}</p>
|
||||||
<li key={n} className="rounded px-1.5 py-1 text-xs hover:bg-surface-2">
|
) : (
|
||||||
<div className="flex items-center gap-2">
|
<ul className="max-h-64 space-y-1 overflow-auto">
|
||||||
<span className="min-w-0 flex-1 truncate text-fg-primary">
|
{data.items.map((i, n) => (
|
||||||
{i.mine ? t("installsYou") : (i.user ?? t("installsUnknown"))}
|
<li key={n} className="rounded px-1.5 py-1 text-xs hover:bg-surface-2">
|
||||||
{i.replaced && (
|
<div className="flex items-center gap-2">
|
||||||
<span className="ml-1 text-fg-muted">· {t("installsReplaced")}</span>
|
<span className="min-w-0 flex-1 truncate text-fg-primary">
|
||||||
)}
|
{i.mine ? t("installsYou") : (i.user ?? t("installsUnknown"))}
|
||||||
</span>
|
{i.replaced && (
|
||||||
<span className="shrink-0 text-[11px] text-fg-muted">
|
<span className="ml-1 text-fg-muted">· {t("installsReplaced")}</span>
|
||||||
{new Date(i.at).toLocaleString()}
|
)}
|
||||||
</span>
|
</span>
|
||||||
</div>
|
<span className="shrink-0 text-[11px] text-fg-muted">
|
||||||
{i.paths && (
|
{new Date(i.at).toLocaleString()}
|
||||||
<div className="mt-0.5 space-y-0.5">
|
</span>
|
||||||
{i.paths.length ? (
|
|
||||||
i.paths.map((p) => (
|
|
||||||
<p
|
|
||||||
key={p}
|
|
||||||
className="truncate font-mono text-[10px] text-fg-muted"
|
|
||||||
title={p}
|
|
||||||
>
|
|
||||||
{p}
|
|
||||||
</p>
|
|
||||||
))
|
|
||||||
) : (
|
|
||||||
<p className="font-mono text-[10px] text-fg-muted">
|
|
||||||
{t("installsPluginWhere")}
|
|
||||||
</p>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
)}
|
{i.paths && (
|
||||||
</li>
|
<div className="mt-0.5 space-y-0.5">
|
||||||
))}
|
{i.paths.length ? (
|
||||||
{data.unrecorded > 0 && (
|
i.paths.map((p) => (
|
||||||
<li className="px-1.5 py-1 text-[11px] text-fg-muted">
|
<p
|
||||||
{t("installsUnrecorded", { count: data.unrecorded })}
|
key={p}
|
||||||
</li>
|
className="truncate font-mono text-[10px] text-fg-muted"
|
||||||
)}
|
title={p}
|
||||||
{data.items.length === 0 && data.unrecorded === 0 && (
|
>
|
||||||
<li className="px-1.5 py-1 text-[11px] text-fg-muted">
|
{p}
|
||||||
{t("installsNoneOfYours")}
|
</p>
|
||||||
</li>
|
))
|
||||||
)}
|
) : (
|
||||||
</ul>
|
<p className="font-mono text-[10px] text-fg-muted">
|
||||||
)}
|
{t("installsPluginWhere")}
|
||||||
</div>
|
</p>
|
||||||
)}
|
)}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
</li>
|
||||||
|
))}
|
||||||
|
{data.unrecorded > 0 && (
|
||||||
|
<li className="px-1.5 py-1 text-[11px] text-fg-muted">
|
||||||
|
{t("installsUnrecorded", { count: data.unrecorded })}
|
||||||
|
</li>
|
||||||
|
)}
|
||||||
|
{data.items.length === 0 && data.unrecorded === 0 && (
|
||||||
|
<li className="px-1.5 py-1 text-[11px] text-fg-muted">
|
||||||
|
{t("installsNoneOfYours")}
|
||||||
|
</li>
|
||||||
|
)}
|
||||||
|
</ul>
|
||||||
|
)}
|
||||||
|
</div>,
|
||||||
|
document.body
|
||||||
|
)}
|
||||||
</span>
|
</span>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -362,6 +362,11 @@ describe("Artifacts", () => {
|
|||||||
expect(await within(box).findByText("/h/.claude/skills/deploy")).toBeInTheDocument();
|
expect(await within(box).findByText("/h/.claude/skills/deploy")).toBeInTheDocument();
|
||||||
expect(within(box).getByText(/khoa/)).toBeInTheDocument();
|
expect(within(box).getByText(/khoa/)).toBeInTheDocument();
|
||||||
expect(within(box).getByText(/1 earlier installs/)).toBeInTheDocument();
|
expect(within(box).getByText(/1 earlier installs/)).toBeInTheDocument();
|
||||||
|
// Over the page, outside the card list that clips its overflow — and a
|
||||||
|
// click inside it keeps it open.
|
||||||
|
expect(box.parentElement).toBe(document.body);
|
||||||
|
await user.click(within(box).getByText(/khoa/));
|
||||||
|
expect(screen.getByTestId("artifact-installs")).toBeInTheDocument();
|
||||||
await user.keyboard("{Escape}");
|
await user.keyboard("{Escape}");
|
||||||
expect(screen.queryByTestId("artifact-installs")).toBeNull();
|
expect(screen.queryByTestId("artifact-installs")).toBeNull();
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -7316,7 +7316,7 @@ exports[`screen snapshots > Settings — about 1`] = `
|
|||||||
<span
|
<span
|
||||||
class="text-status-warning/90"
|
class="text-status-warning/90"
|
||||||
>
|
>
|
||||||
UI build v2.8.35 (rebuild client to match)
|
UI build v2.8.40 (rebuild client to match)
|
||||||
</span>
|
</span>
|
||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
+4
-4
@@ -89,9 +89,9 @@ A dashboard shared by several people runs in **server mode** ([SERVER-MODE.md](S
|
|||||||
| `POST /api/auth/login` `{username, password}` | `{user}` + the cookie; `401 EBADLOGIN`, `429 ETOOMANY`, `404 ENOTSERVER` in local mode |
|
| `POST /api/auth/login` `{username, password}` | `{user}` + the cookie; `401 EBADLOGIN`, `429 ETOOMANY`, `404 ENOTSERVER` in local mode |
|
||||||
| `POST /api/auth/logout` | `{ok: true}`, cookie cleared |
|
| `POST /api/auth/logout` | `{ok: true}`, cookie cleared |
|
||||||
|
|
||||||
In server mode a **developer** sees only rows of the workspaces they own (`lanes.owner_id`): every list, count, chart and cost answer is limited to them, and a request naming another user's session, agent, workspace or run (in the path, query or body) answers `404 ENOTFOUND`. Admin and analyst see everything; `GET /api/users` lists every account (`displayName`, `email`, `createdAt`, `logins`, `lastLoginAt` — the last login ever, kept after it ends —, `mustChangePassword` included) with its workspaces, sessions and `today` (since the viewer's local midnight — `?tz_offset=` is the browser's `getTimezoneOffset()`, UTC without it) / 7 / 30-day `{cost, tokens}`, `GET /api/users/storage[?refresh=1]` each user's home size (`{storage: {<id>: {bytes, files, partial, measuredAt} | null}, measuring}` — measured in the background, see [SERVER-MODE.md](SERVER-MODE.md)), `GET /api/users/tmux` each member's own tmux server under one Linux user per account (`{available, installed, matched, users: [{id, username, running, stuck?, version, pid, startedAt, sessions, busy, outdated}]}`; an admin's `POST /api/users/:id/tmux-restart` and `POST /api/users/tmux-restart-idle` restart them with `currentPassword`, audited, `409 ETMUXSTUCK` for a server that will not stop), `GET /api/host` the machine and each user's live share of it (`{at, hostname, os, uptime, cpu: {model, cores, load}, memory: {total, available, used, swapTotal, swapUsed}, disks: [{device, mount, type, kind: "HDD"|"SSD"|null, total, used, free}], homesMount, gpus: [{name, utilization, memoryUsed, memoryTotal}], usage: {cpu, sampleMs, groups: [{key, kind: "user"|"host"|"system", userId?, username?, cpu, memory, memoryPercent, processes, top: [{pid, name, cpu, memory}]}]} | null, bootTime, network: [{name, rx, tx}], diskIo: [{name, read, write}], temperatures: [{chip, label, celsius}], pressure: {cpu, memory, io: {some10, some60, full10} | null} | null (Linux PSI, `/proc/pressure/*`: % of the last 10 / 60 s tasks stalled on it), topProcesses: [{pid, name, cpu, memory, group}], process: {pid, node, uptime, rss, heapUsed}}`, `cpu` also carrying `physicalCores` and `perCore` (busy % per thread), rates in bytes/s over the sample — read-only, cached 3 s, `usage` null and the lists empty off Linux), `GET /api/host/history?range=1h|6h|24h` the CPU/memory history every server on Linux keeps in memory since it started (both read by the Dashboard's System Health tab and open to every signed-in user — `/host` is not staff-only) (`{range, intervalMs, running, startedAt, points: [{at, cpu, memory, memoryUsed, swapUsed, load1, users: {<id>: {cpu, memory}}}]}`, one point per 30 s, averaged to ≤ 360), `GET /api/users/:id/details[?tz_offset=]` one account in full for the Administration page's user detail (`{user (with logins, lastLoginAt), sessions: {total, active, firstAt, lastAt}, usage: {today, last7d, last30d, daily: [{date, cost, tokens}] (30 local days, oldest first), byTool, byModel: [{key, cost, tokens, sessions}]}, workspaces: [{id, title, cwd, tool, kind, branch, status, createdAt, sessions, lastActiveAt, livePanes}], panes: [{id, laneId, laneTitle, laneCwd, tool, model, account, proxy, sessionId, startedAt, status}], recentSessions (15, with cost/tokens), pool: {claude|codex|cursor: {pin, group, accounts: [{name, kind, email, expired, allowed, pinned, quota, quotaPercent, full, livePanes, spend5h, spend7d, userSpend5h, userSpend7d, userTokens5h, userTokens7d, userRuns7d, userLivePanes, userLastAt}]}}, audit}` — `user*` fields are only the runs on that user's workspaces; never a token; `404 ENOUSER`), and `GET /api/users/audit[?limit=]` the staff reads of developers' sessions and admins' account changes (kept `AGENTHUB_AUDIT_DAYS` days, default 180, `0` = forever) (`reader`/`owner` are usernames, `reader_display`/`owner_display` their display names or null) (all `403 EADMIN` for a developer). `GET /api/users` also carries each account's [spend quota](SERVER-MODE.md#spend-quotas) — `quotaSetting` (`{mode: "default"|"unlimited"|"custom", limit_usd?, period?, tz_offset?}`) and `quota` (the one binding them now with `spend`, `pct`, `exceeded`, `resetsAt`, or null) — and the top-level `quotaDefault`; an admin sets the default with `PUT /api/users/quota-default` `{quota: {limit_usd, period, tz_offset} | null, currentPassword}` and a user's own with `PATCH /api/users/:id` `{quota}` (`400 EBADQUOTA`). A workspace owner over their quota gets `429 EQUOTA` from `POST /api/run` and `POST /api/lanes/:id/start`. See [SERVER-MODE.md](SERVER-MODE.md#what-each-user-sees).
|
In server mode a **developer** sees only rows of the workspaces they own (`lanes.owner_id`): every list, count, chart and cost answer is limited to them, and a request naming another user's session, agent, workspace or run (in the path, query or body) answers `404 ENOTFOUND`. Admin and analyst see everything; `GET /api/users` lists every account (`displayName`, `email`, `createdAt`, `logins`, `lastLoginAt` — the last login ever, kept after it ends —, `mustChangePassword` included) with its workspaces, sessions and `today` (since the viewer's local midnight — `?tz_offset=` is the browser's `getTimezoneOffset()`, UTC without it) / 7 / 30-day `{cost, tokens}`, `GET /api/users/storage[?refresh=1]` each user's home size (`{storage: {<id>: {bytes, files, partial, measuredAt} | null}, measuring}` — measured in the background, see [SERVER-MODE.md](SERVER-MODE.md)), `GET /api/users/tmux` each member's own tmux server under one Linux user per account (`{available, installed, matched, users: [{id, username, running, stuck?, version, pid, startedAt, sessions, busy, outdated}]}`; an admin's `POST /api/users/:id/tmux-restart` and `POST /api/users/tmux-restart-idle` restart them with `currentPassword`, audited, `409 ETMUXSTUCK` for a server that will not stop), `GET /api/host` the machine and each user's live share of it (`{at, hostname, os, uptime, cpu: {model, cores, load}, memory: {total, available, used, swapTotal, swapUsed}, disks: [{device, mount, type, kind: "HDD"|"SSD"|null, total, used, free}], homesMount, gpus: [{name, utilization, memoryUsed, memoryTotal}], usage: {cpu, sampleMs, groups: [{key, kind: "user"|"host"|"system", userId?, username?, displayName?, avatarAt?, cpu, memory, memoryPercent, processes, top: [{pid, name, cpu, memory}]}]} | null, bootTime, network: [{name, rx, tx}], diskIo: [{name, read, write}], temperatures: [{chip, label, celsius}], pressure: {cpu, memory, io: {some10, some60, full10} | null} | null (Linux PSI, `/proc/pressure/*`: % of the last 10 / 60 s tasks stalled on it), topProcesses: [{pid, name, cpu, memory, group}], process: {pid, node, uptime, rss, heapUsed}}`, `cpu` also carrying `physicalCores` and `perCore` (busy % per thread), rates in bytes/s over the sample — read-only, cached 3 s, `usage` null and the lists empty off Linux), `GET /api/host/history?range=1h|6h|24h` the CPU/memory history every server on Linux keeps in memory since it started (both read by the Dashboard's System Health tab and open to every signed-in user — `/host` is not staff-only) (`{range, intervalMs, running, startedAt, points: [{at, cpu, memory, memoryUsed, swapUsed, load1, users: {<id>: {cpu, memory}}}]}`, one point per 30 s, averaged to ≤ 360), `GET /api/users/:id/details[?tz_offset=]` one account in full for the Administration page's user detail (`{user (with logins, lastLoginAt), sessions: {total, active, firstAt, lastAt}, usage: {today, last7d, last30d, daily: [{date, cost, tokens}] (30 local days, oldest first), byTool, byModel: [{key, cost, tokens, sessions}]}, workspaces: [{id, title, cwd, tool, kind, branch, status, createdAt, sessions, lastActiveAt, livePanes}], panes: [{id, laneId, laneTitle, laneCwd, tool, model, account, proxy, sessionId, startedAt, status}], recentSessions (15, with cost/tokens), pool: {claude|codex|cursor: {pin, group, accounts: [{name, kind, email, expired, allowed, pinned, quota, quotaPercent, full, livePanes, spend5h, spend7d, userSpend5h, userSpend7d, userTokens5h, userTokens7d, userRuns7d, userLivePanes, userLastAt}]}}, audit}` — `user*` fields are only the runs on that user's workspaces; never a token; `404 ENOUSER`), and `GET /api/users/audit[?limit=]` the staff reads of developers' sessions and admins' account changes (kept `AGENTHUB_AUDIT_DAYS` days, default 180, `0` = forever) (`reader`/`owner` are usernames, `reader_display`/`owner_display` their display names or null) (all `403 EADMIN` for a developer). `GET /api/users` also carries each account's [spend quota](SERVER-MODE.md#spend-quotas) — `quotaSetting` (`{mode: "default"|"unlimited"|"custom", limit_usd?, period?, tz_offset?}`) and `quota` (the one binding them now with `spend`, `pct`, `exceeded`, `resetsAt`, or null) — and the top-level `quotaDefault`; an admin sets the default with `PUT /api/users/quota-default` `{quota: {limit_usd, period, tz_offset} | null, currentPassword}` and a user's own with `PATCH /api/users/:id` `{quota}` (`400 EBADQUOTA`). A workspace owner over their quota gets `429 EQUOTA` from `POST /api/run` and `POST /api/lanes/:id/start`. See [SERVER-MODE.md](SERVER-MODE.md#what-each-user-sees).
|
||||||
|
|
||||||
An admin changes accounts with `POST /api/users` (`{username, password, role}` → `201 {user}`; the password may be any non-empty starting one and the account gets `mustChangePassword: true`), `GET /api/users/:id` (`{user, workspaces: [{id, title, cwd}]}`, the account with `logins` and `lastLoginAt`, for the Edit form; admin or analyst), `GET /api/users/:id/avatar` (that account's picture for the sidebar's owner groups — admin or analyst, `nosniff` + `sandbox` CSP, `404 ENOAVATAR`; a workspace in `GET /api/lanes` carries `owner_avatar_at` to version its URL), `PATCH /api/users/:id` (any of `{displayName?, email?, role?, disabled?, password?, addWorkspaces?: [laneId], removeWorkspaces?: [laneId], signOut?: true}` — every field validated before any is written; `removeWorkspaces` leaves the workspace with no owner and answers `409 ENOTOWNED` for one the user does not own; an admin's own `password`/`signOut` keeps the login it came from; a password for SOMEONE ELSE may be anything non-empty and sets their `mustChangePassword`, the admin's OWN must pass every rule below, `400 EWEAKPASSWORD` with `rules`), `POST /api/users/:id/password` (`{password}`; that user's logins end; the same two bars) `POST /api/users/:id/workspaces` (`{laneId}`; the workspace's owner becomes that user) and `DELETE /api/users/:id` (delete for good: the user's logins, panes, workspaces' records, prefs and — under S3 — their Linux account and whole home, removed FIRST so a refusal (`502 EPROVISION`) leaves every row; `409 ESELF` for yourself, `409 ELASTADMIN` for the last admin; session history and the audit log stay). No path — this API or the `agenthub users` CLI — may demote, disable or delete the last enabled admin (`409 ELASTADMIN`). Every one carries `currentPassword`, the admin's own password: `403 EREAUTH` when it is wrong or missing, `429 ETOOMANY` after 10 wrong tries in 15 minutes. `409 ESELF` for an admin's own role or disable, `409 EEXISTS` for a taken name, `400 EBADUSER`/`EBADPASSWORD`/`EBADROLE`/`EBADEMAIL`/`EBADFIELD`, `404 ENOUSER`/`ENOLANE`; a developer or analyst gets `403 EADMIN`, and local mode `403 ELOCALMODE`. No answer carries a password hash; each change is written to the audit log.
|
An admin changes accounts with `POST /api/users` (`{username, password, role}` → `201 {user}`; the password may be any non-empty starting one and the account gets `mustChangePassword: true`), `GET /api/users/:id` (`{user, workspaces: [{id, title, cwd}]}`, the account with `logins` and `lastLoginAt`, for the Edit form; admin or analyst), `GET /api/users/:id/avatar` (that account's picture for the sidebar's owner groups — admin or analyst, `nosniff` + `sandbox` CSP, `404 ENOAVATAR`; a workspace in `GET /api/lanes` carries `owner_avatar_at` to version its URL), `PATCH /api/users/:id` (any of `{displayName?, email?, role?, disabled?, password?, addWorkspaces?: [laneId], removeWorkspaces?: [laneId], signOut?: true}` — every field validated before any is written; `removeWorkspaces` leaves the workspace with no owner and answers `409 ENOTOWNED` for one the user does not own; an admin's own `password`/`signOut` keeps the login it came from; a password for SOMEONE ELSE may be anything non-empty and sets their `mustChangePassword`, the admin's OWN must pass every rule below, `400 EWEAKPASSWORD` with `rules`), `POST /api/users/:id/password` (`{password}`; that user's logins end; the same two bars) `POST /api/users/:id/workspaces` (`{laneId}`; the workspace's owner becomes that user) and `DELETE /api/users/:id` (delete for good: the user's logins, panes, workspaces' records, prefs and — under S3 — their Linux account and whole home, removed FIRST so a refusal (`502 EPROVISION`) leaves every row; `409 ESELF` for yourself, `409 ELASTADMIN` for the last admin; session history and the audit log stay). No path — this API or the `agenthub users` CLI — may demote, disable or delete the last enabled admin (`409 ELASTADMIN`). Every one carries `currentPassword`, the admin's own password: `403 EREAUTH` when it is wrong or missing, `429 ETOOMANY` after 10 wrong tries in 15 minutes. `409 ESELF` for an admin's own role or disable, `409 EEXISTS` for a taken name, `409 ENAMETAKEN` for a `displayName` that reads as another account's (the same rule as `PATCH /api/me/account`), `400 EBADUSER`/`EBADPASSWORD`/`EBADROLE`/`EBADEMAIL`/`EBADFIELD`, `404 ENOUSER`/`ENOLANE`; a developer or analyst gets `403 EADMIN`, and local mode `403 ELOCALMODE`. No answer carries a password hash; each change is written to the audit log.
|
||||||
|
|
||||||
`GET /api/accounts[?force=1]` lists the Claude account pool ([SERVER-MODE.md](SERVER-MODE.md#claude-account-pool)): `{accounts: [{name, addedAt, expiresAt, expired, livePanes, spend5h, spend7d, tokens5h, tokens7d, quota: {fiveHour, sevenDay, checkedAt, error} | null, quotaPercent, full}], codex: [{name, kind: "apikey"|"chatgpt", addedAt, livePanes, spend5h, spend7d, tokens5h, tokens7d, quota: {windows: [{label, usedPercent, resetsAt}], asOf} | null, quotaPercent, full}], pins: {claude: [{userId, username, account, pinnedAt}], codex: […]}, blockPercent}` — `pins` are the users an admin pinned to one account (empty in local mode, keyed by tool: `claude`, `codex`, `cursor`); `codex` is the [Codex account pool](SERVER-MODE.md#codex-account-pool); `cursor: [{name, kind: "apikey", addedAt, livePanes, …}]` is the [Cursor account pool](SERVER-MODE.md#cursor-account-pool) (API keys; `quota` null, spend 0); `groups: [{id, name, createdAt, users: [{userId, username}], accounts: {claude: [names], codex: […], cursor: […]}}]` are the [pool groups](SERVER-MODE.md#account-pool-groups) (empty in local mode). `spend*`/`tokens*` = the sessions the account's runs held, over the hours they held them (a Codex session counts whole once its run started in the window). It never includes a key or a token. `force=1` re-reads every quota first. Run rows (`/api/run/history`) carry `account`, the pool account their pane ran on (`null` = the machine's own login).
|
`GET /api/accounts[?force=1]` lists the Claude account pool ([SERVER-MODE.md](SERVER-MODE.md#claude-account-pool)): `{accounts: [{name, addedAt, expiresAt, expired, livePanes, spend5h, spend7d, tokens5h, tokens7d, quota: {fiveHour, sevenDay, checkedAt, error} | null, quotaPercent, full}], codex: [{name, kind: "apikey"|"chatgpt", addedAt, livePanes, spend5h, spend7d, tokens5h, tokens7d, quota: {windows: [{label, usedPercent, resetsAt}], asOf} | null, quotaPercent, full}], pins: {claude: [{userId, username, account, pinnedAt}], codex: […]}, blockPercent}` — `pins` are the users an admin pinned to one account (empty in local mode, keyed by tool: `claude`, `codex`, `cursor`); `codex` is the [Codex account pool](SERVER-MODE.md#codex-account-pool); `cursor: [{name, kind: "apikey", addedAt, livePanes, …}]` is the [Cursor account pool](SERVER-MODE.md#cursor-account-pool) (API keys; `quota` null, spend 0); `groups: [{id, name, createdAt, users: [{userId, username}], accounts: {claude: [names], codex: […], cursor: […]}}]` are the [pool groups](SERVER-MODE.md#account-pool-groups) (empty in local mode). `spend*`/`tokens*` = the sessions the account's runs held, over the hours they held them (a Codex session counts whole once its run started in the window). It never includes a key or a token. `force=1` re-reads every quota first. Run rows (`/api/run/history`) carry `account`, the pool account their pane ran on (`null` = the machine's own login).
|
||||||
|
|
||||||
@@ -110,7 +110,7 @@ An admin (server mode) adds an account with `POST /api/accounts` `{tool: "claude
|
|||||||
| `PUT /api/me/pool-accounts` `{tool, account: "<name>" \| null}` | the account's new sessions of `tool` run on `account` (`null` = automatic): `{tool, choice, switched}` — `switched` as for an admin's pin (a Claude login goes into the home at once). Below an admin's pin (`409 ELOCKED`), only an account the group allows (`404 ENOACCOUNT`), `400 EBADTOOL`; login cookie only, audited |
|
| `PUT /api/me/pool-accounts` `{tool, account: "<name>" \| null}` | the account's new sessions of `tool` run on `account` (`null` = automatic): `{tool, choice, switched}` — `switched` as for an admin's pin (a Claude login goes into the home at once). Below an admin's pin (`409 ELOCKED`), only an account the group allows (`404 ENOACCOUNT`), `400 EBADTOOL`; login cookie only, audited |
|
||||||
| `POST /api/me/onboarded` | the first-run setup is done or skipped (kept from the first call) |
|
| `POST /api/me/onboarded` | the first-run setup is done or skipped (kept from the first call) |
|
||||||
| `GET /api/me/account` | Settings → Account. Server mode: `{mode: "server", user: {id, username, role, disabled, displayName, email, avatarAt, createdAt}, workspaces, sessions, logins, lastLoginAt}`; local mode `{mode: "local"}` |
|
| `GET /api/me/account` | Settings → Account. Server mode: `{mode: "server", user: {id, username, role, disabled, displayName, email, avatarAt, createdAt}, workspaces, sessions, logins, lastLoginAt}`; local mode `{mode: "local"}` |
|
||||||
| `PATCH /api/me/account` `{displayName?, email?}` | the account's own profile (`""`/`null` clears), the same shape back; `400 EBADFIELD` (display name over 100 characters or with control characters) / `EBADEMAIL` |
|
| `PATCH /api/me/account` `{displayName?, email?}` | the account's own profile (`""`/`null` clears), the same shape back; `400 EBADFIELD` (display name over 100 characters or with control characters) / `EBADEMAIL`; `409 ENAMETAKEN` for a display name that reads as another account's display name or username (marks, case, punctuation, bracketed parts like "(you)" and look-alike letters ignored; keeping the name you have is always allowed) |
|
||||||
| `POST /api/me/password` `{currentPassword, newPassword}` | `{ok: true}`; every other login of the account ends, this one stays, and `mustChangePassword` clears. The new password must pass every rule — at least 8 characters, a lower-case and an upper-case letter, a digit, a symbol, not containing the username — and differ from the current one: `400 EWEAKPASSWORD` with `error.rules` (`length`, `lower`, `upper`, `digit`, `symbol`, `username`, `reused`). `403 EREAUTH` wrong current password (`429 ETOOMANY` after 10), `400 EBADPASSWORD` |
|
| `POST /api/me/password` `{currentPassword, newPassword}` | `{ok: true}`; every other login of the account ends, this one stays, and `mustChangePassword` clears. The new password must pass every rule — at least 8 characters, a lower-case and an upper-case letter, a digit, a symbol, not containing the username — and differ from the current one: `400 EWEAKPASSWORD` with `error.rules` (`length`, `lower`, `upper`, `digit`, `symbol`, `username`, `reused`). `403 EREAUTH` wrong current password (`429 ETOOMANY` after 10), `400 EBADPASSWORD` |
|
||||||
| `POST /api/me/sign-out-others` | `{ended}` — every login of the account but this one ends |
|
| `POST /api/me/sign-out-others` | `{ended}` — every login of the account but this one ends |
|
||||||
| `GET /api/me/avatar` | server mode: the account's own picture (`nosniff`, `sandbox` CSP; the client adds `?v=<avatarAt>`), `404 ENOAVATAR` when it has none |
|
| `GET /api/me/avatar` | server mode: the account's own picture (`nosniff`, `sandbox` CSP; the client adds `?v=<avatarAt>`), `404 ENOAVATAR` when it has none |
|
||||||
@@ -3036,7 +3036,7 @@ POST /api/tool-profiles/:tool/activate Body: { name }
|
|||||||
DELETE /api/tool-profiles/:tool Body: { name }
|
DELETE /api/tool-profiles/:tool Body: { name }
|
||||||
```
|
```
|
||||||
|
|
||||||
The login profiles of the AI tools other than Claude Code (`server/lib/tool-profiles.js`; Claude's are `/api/cc-config/profiles` above). Settings → AI tools → **Profiles** shows both, one tab per tool. `:tool` is `codex` (the whole `$CODEX_HOME/auth.json`: a ChatGPT login or an API key) or `omp` (every credential Oh My Pi stores, read with `omp auth export` and written back with `omp auth import -` — secrets on stdin, never argv; import merges, so a switch first empties omp's credential tables in `~/.omp/agent/agent.db`, and a failed import puts the outgoing set back). `antigravity` is listed with `supported: false` and a `reason`: agy keeps its login in the OS keyring, which AgentHub does not touch (`409 EUNSUPPORTED`). `GET /` answers `{tools: [{tool, supported, reason?, items, active, error?}]}`, each item `{name, label, savedAt, active, kind, email, detail}` — never a token; one tool's failure (omp not installed) is that tool's `error`, not the request's. Profiles are stored one file each under `<CLAUDE_HOME>/agenthub-profiles/<tool>/` (0700/0600) with cc-profiles' rules: one login is one profile (`409 EDUPLICATE`), a switch re-saves the outgoing login into its own profile first and refuses one never saved (`409 EUNSAVED`), the live login's profile is not deletable (`409 EACTIVE`), `409 ENOAUTH` when the tool holds no login, `409 ENOTINSTALLED`, `502 EOMP` when omp's own command fails. Writes are same-origin only; in server mode `/tool-profiles` is in `ADMIN_WRITE_PREFIXES` and `STAFF_ONLY_PREFIXES` — it changes the HOST's own logins.
|
The login profiles of the AI tools other than Claude Code (`server/lib/tool-profiles.js`; Claude's are `/api/cc-config/profiles` above). Settings → AI tools → **Profiles** shows both, one tab per tool. `:tool` is `codex` (the whole `$CODEX_HOME/auth.json`: a ChatGPT login or an API key) or `omp` (every credential Oh My Pi stores, read with `omp auth export` and written back with `omp auth import -` — secrets on stdin, never argv; import merges, so a switch first empties omp's credential tables in `~/.omp/agent/agent.db`, and a failed import puts the outgoing set back). `antigravity` is listed with `supported: false` and a `reason`: agy keeps its login in the OS keyring, which AgentHub does not touch (`409 EUNSUPPORTED`). `GET /` answers `{tools: [{tool, supported, reason?, items, active, error?}]}`, each item `{name, label, savedAt, active, kind, email, detail}` — never a token; one tool's failure (omp not installed) is that tool's `error`, not the request's. Profiles are stored one file each under `<CLAUDE_HOME>/agenthub-profiles/<tool>/` (0700/0600) with cc-profiles' rules: one login is one profile (`409 EDUPLICATE`), a switch re-saves the outgoing login into its own profile first and refuses one never saved (`409 EUNSAVED`), and for Codex then runs `codex app-server daemon restart` when that CODEX_HOME's shared daemon is running (its `app-server-control.sock` resolves) — the daemon holds the login it started with, so without it neither an open nor a NEW Codex session saw the switch; open TUIs reconnect on their own — answering `following: true` (the activate response's extra field; `false` when no daemon ran), the live login's profile is not deletable (`409 EACTIVE`), `409 ENOAUTH` when the tool holds no login, `409 ENOTINSTALLED`, `502 EOMP` when omp's own command fails. Writes are same-origin only; in server mode `/tool-profiles` is in `ADMIN_WRITE_PREFIXES` and `STAFF_ONLY_PREFIXES` — it changes the HOST's own logins.
|
||||||
|
|
||||||
### AI Proxy profiles
|
### AI Proxy profiles
|
||||||
|
|
||||||
|
|||||||
+9
-7
File diff suppressed because one or more lines are too long
+7
-1
@@ -372,7 +372,13 @@ Wherever the dashboard names a person — the sidebar's sign-out tooltip, the
|
|||||||
workspace list's owner groups, the Users page and its audit log, the Edit user
|
workspace list's owner groups, the Users page and its audit log, the Edit user
|
||||||
form — it shows their display name when one is set, else the username (the
|
form — it shows their display name when one is set, else the username (the
|
||||||
Users page keeps `@username` beside a display name). Logging in, the CLI and
|
Users page keeps `@username` beside a display name). Logging in, the CLI and
|
||||||
the Linux account always use the username.
|
the Linux account always use the username. No one can pose as a colleague: a
|
||||||
|
display name that reads as another account's display name or username — marks,
|
||||||
|
case, spaces, punctuation, a bracketed part like "(you)" and look-alike letters
|
||||||
|
from other alphabets ignored — is refused (`409 ENAMETAKEN`), whether the user
|
||||||
|
sets it in Settings → Account or an admin does on the Users page. A name an
|
||||||
|
account already has is kept on an unrelated save; rename an old clash from the
|
||||||
|
Users page.
|
||||||
|
|
||||||
Under S3 an admin's folder browser opens on their own home too; ticking
|
Under S3 an admin's folder browser opens on their own home too; ticking
|
||||||
**Server folder** opens the host account's home (`/home/<host>`), where a
|
**Server folder** opens the host account's home (`/home/<host>`), where a
|
||||||
|
|||||||
Generated
+2
-2
@@ -1,12 +1,12 @@
|
|||||||
{
|
{
|
||||||
"name": "agenthub",
|
"name": "agenthub",
|
||||||
"version": "2.8.35",
|
"version": "2.8.40",
|
||||||
"lockfileVersion": 3,
|
"lockfileVersion": 3,
|
||||||
"requires": true,
|
"requires": true,
|
||||||
"packages": {
|
"packages": {
|
||||||
"": {
|
"": {
|
||||||
"name": "agenthub",
|
"name": "agenthub",
|
||||||
"version": "2.8.35",
|
"version": "2.8.40",
|
||||||
"hasInstallScript": true,
|
"hasInstallScript": true,
|
||||||
"license": "UNLICENSED",
|
"license": "UNLICENSED",
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "agenthub",
|
"name": "agenthub",
|
||||||
"version": "2.8.35",
|
"version": "2.8.40",
|
||||||
"bin": {
|
"bin": {
|
||||||
"agenthub": "bin/agenthub.js"
|
"agenthub": "bin/agenthub.js"
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -222,6 +222,26 @@ describe("Settings → Account (/api/me)", () => {
|
|||||||
assert.equal(bad.body.error.code, "EBADEMAIL");
|
assert.equal(bad.body.error.code, "EBADEMAIL");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("refuses a display name that reads as another account's (ENAMETAKEN)", async () => {
|
||||||
|
assert.equal(auth.nameKey("Nguyễn Ngọc Trí Vĩ (you)"), auth.nameKey("nguyen.ngoc-tri VI"));
|
||||||
|
assert.equal(auth.nameKey("Đào"), "dao");
|
||||||
|
// Cyrillic о and а in place of Latin letters.
|
||||||
|
assert.equal(auth.nameKey("Mіа Trоn"), auth.nameKey("Mia Tron"));
|
||||||
|
const leo = await login("leo", "member-pass-2");
|
||||||
|
// mia's display name is "Mia Tran"; boss has none, only a username.
|
||||||
|
for (const name of ["MIA TRẦN (you)", "Mia\u200b Tran", "mia", "Bóss"]) {
|
||||||
|
const r = await call("PATCH", "/api/me/account", { cookie: leo, body: { displayName: name } });
|
||||||
|
assert.equal(r.status, 409, name);
|
||||||
|
assert.equal(r.body.error.code, "ENAMETAKEN");
|
||||||
|
}
|
||||||
|
assert.equal(auth.findUser("leo").display_name, "Leo N");
|
||||||
|
// Keeping one's own name, or a name of one's own, still works.
|
||||||
|
for (const name of ["Leo N", "Leo Nguyen"]) {
|
||||||
|
const r = await call("PATCH", "/api/me/account", { cookie: leo, body: { displayName: name } });
|
||||||
|
assert.equal(r.status, 200, name);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
it("changes its own password only with the old one, keeping this login", async () => {
|
it("changes its own password only with the old one, keeping this login", async () => {
|
||||||
const leo = await login("leo", "member-pass-2");
|
const leo = await login("leo", "member-pass-2");
|
||||||
const other = await login("leo", "member-pass-2");
|
const other = await login("leo", "member-pass-2");
|
||||||
|
|||||||
@@ -97,6 +97,33 @@ describe("tool-profiles: codex", () => {
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("restarts a running Codex daemon so open sessions follow; none running, nothing to restart", async () => {
|
||||||
|
login("acct-a", "alice@example.com");
|
||||||
|
profiles.saveProfile("codex");
|
||||||
|
login("acct-b", "bob@example.com");
|
||||||
|
profiles.saveProfile("codex");
|
||||||
|
assert.equal(profiles.activateProfile("codex", "alice").following, false);
|
||||||
|
|
||||||
|
const log = path.join(ROOT, "codex-argv.log");
|
||||||
|
const bin = path.join(ROOT, "fake-codex.sh");
|
||||||
|
fs.writeFileSync(bin, `#!/bin/sh\necho "$CODEX_HOME $*" >> '${log}'\n`, { mode: 0o755 });
|
||||||
|
const sock = path.join(process.env.CODEX_HOME, "app-server-control", "app-server-control.sock");
|
||||||
|
fs.mkdirSync(path.dirname(sock), { recursive: true });
|
||||||
|
fs.writeFileSync(sock, "");
|
||||||
|
process.env.AGENTHUB_CODEX_BIN = bin;
|
||||||
|
try {
|
||||||
|
assert.equal(profiles.activateProfile("codex", "bob").following, true);
|
||||||
|
for (let i = 0; i < 50 && !fs.existsSync(log); i++)
|
||||||
|
await new Promise((r) => setTimeout(r, 20));
|
||||||
|
assert.equal(
|
||||||
|
fs.readFileSync(log, "utf8").trim(),
|
||||||
|
`${process.env.CODEX_HOME} app-server daemon restart`
|
||||||
|
);
|
||||||
|
} finally {
|
||||||
|
delete process.env.AGENTHUB_CODEX_BIN;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
it("refuses to switch away from an unsaved login", () => {
|
it("refuses to switch away from an unsaved login", () => {
|
||||||
login("acct-a", "alice@example.com");
|
login("acct-a", "alice@example.com");
|
||||||
profiles.saveProfile("codex");
|
profiles.saveProfile("codex");
|
||||||
|
|||||||
@@ -93,6 +93,12 @@ describe("GET /api/sessions/:id/stats tool totals", () => {
|
|||||||
assert.equal(body.tool_call_count, 2);
|
assert.equal(body.tool_call_count, 2);
|
||||||
assert.equal(body.distinct_tool_count, 1);
|
assert.equal(body.distinct_tool_count, 1);
|
||||||
});
|
});
|
||||||
|
it("counts each call once in tools_used, not its Pre and Post events", async () => {
|
||||||
|
const one = (await get("/api/sessions/ua-1/stats")).body.tools_used;
|
||||||
|
assert.ok(one.every((t) => t.count === 1));
|
||||||
|
const two = (await get("/api/sessions/ua-2/stats")).body.tools_used;
|
||||||
|
assert.deepEqual(two, [{ tool_name: "Read", count: 2 }]);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("GET /api/events labels", () => {
|
describe("GET /api/events labels", () => {
|
||||||
|
|||||||
@@ -2547,10 +2547,16 @@ const stmts = {
|
|||||||
FROM events
|
FROM events
|
||||||
WHERE session_id = ? AND tool_name IS NOT NULL
|
WHERE session_id = ? AND tool_name IS NOT NULL
|
||||||
`),
|
`),
|
||||||
|
// One row per call, like sessionToolCallTotals: a call is its PreToolUse,
|
||||||
|
// or its PostToolUse in a session that has none (imported). Counting every
|
||||||
|
// event with a tool_name counted each call twice.
|
||||||
sessionToolUsageCounts: db.prepare(`
|
sessionToolUsageCounts: db.prepare(`
|
||||||
SELECT tool_name, COUNT(*) as count
|
SELECT tool_name, COUNT(*) as count
|
||||||
FROM events
|
FROM events
|
||||||
WHERE session_id = ? AND tool_name IS NOT NULL
|
WHERE session_id = ? AND tool_name IS NOT NULL
|
||||||
|
AND event_type = CASE
|
||||||
|
WHEN EXISTS (SELECT 1 FROM events WHERE session_id = ? AND event_type = 'PreToolUse')
|
||||||
|
THEN 'PreToolUse' ELSE 'PostToolUse' END
|
||||||
GROUP BY tool_name
|
GROUP BY tool_name
|
||||||
ORDER BY count DESC
|
ORDER BY count DESC
|
||||||
LIMIT 15
|
LIMIT 15
|
||||||
|
|||||||
+45
-1
@@ -20,7 +20,8 @@
|
|||||||
* admin on the Users page (`server/routes/users.js`), where every change
|
* admin on the Users page (`server/routes/users.js`), where every change
|
||||||
* needs the admin's own password again (`confirmPassword`, throttled).
|
* needs the admin's own password again (`confirmPassword`, throttled).
|
||||||
* An account also carries an optional display name and email
|
* An account also carries an optional display name and email
|
||||||
* (`validateProfile`), which its owner edits in Settings → Account without
|
* (`validateProfile`; no two accounts may read as one name — `assertNameFree`,
|
||||||
|
* ENAMETAKEN), which its owner edits in Settings → Account without
|
||||||
* that step-up; changing their OWN password there needs the old one and
|
* that step-up; changing their OWN password there needs the old one and
|
||||||
* keeps the login it was changed from (`setPassword`'s `keepToken`).
|
* keeps the login it was changed from (`setPassword`'s `keepToken`).
|
||||||
* - Two password bars: an admin may GIVE any non-empty password (a create or a
|
* - Two password bars: an admin may GIVE any non-empty password (a create or a
|
||||||
@@ -247,6 +248,47 @@ function validateProfile(body) {
|
|||||||
return out;
|
return out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Latin look-alikes from other scripts, so "Vĩ" in Cyrillic still collides.
|
||||||
|
const CONFUSABLE = {
|
||||||
|
а: "a", в: "b", е: "e", к: "k", м: "m", н: "h", о: "o", р: "p", с: "c", т: "t",
|
||||||
|
у: "y", х: "x", і: "i", ј: "j", ԁ: "d", ѕ: "s", ӏ: "l", α: "a", β: "b", ε: "e",
|
||||||
|
η: "n", ι: "i", κ: "k", ν: "v", ο: "o", ρ: "p", τ: "t", υ: "u", χ: "x", "ı": "i",
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The name two accounts may not share: no marks (Vĩ = Vi), đ = d, any case,
|
||||||
|
* look-alike letters folded, and only letters and digits outside brackets —
|
||||||
|
* so "Nguyễn Ngọc Trí Vĩ (you)" and "nguyen.ngoc-tri vi" are both one name.
|
||||||
|
*/
|
||||||
|
function nameKey(s) {
|
||||||
|
return String(s || "")
|
||||||
|
.normalize("NFKD")
|
||||||
|
.replace(/\p{M}/gu, "")
|
||||||
|
.toLowerCase()
|
||||||
|
.replace(/\([^)]*\)|\[[^\]]*\]/g, "")
|
||||||
|
.replace(/[đð]/g, "d")
|
||||||
|
.replace(/./gu, (c) => CONFUSABLE[c] ?? c)
|
||||||
|
.replace(/[^\p{L}\p{N}]/gu, "");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Refuse (ENAMETAKEN) a display name that reads as another account's display
|
||||||
|
* name or username, so no one can pose as a colleague. Keeping the name one
|
||||||
|
* already has is always allowed — a clash from before this rule is no reason
|
||||||
|
* to block an admin's unrelated edit.
|
||||||
|
*/
|
||||||
|
function assertNameFree(userId, fields) {
|
||||||
|
if (!("display_name" in fields) || !fields.display_name) return;
|
||||||
|
const key = nameKey(fields.display_name);
|
||||||
|
if (!key) return;
|
||||||
|
const own = sql("SELECT display_name FROM users WHERE id = ?").get(userId);
|
||||||
|
if (own && own.display_name === fields.display_name) return;
|
||||||
|
const rows = sql("SELECT id, username, display_name FROM users WHERE id != ?").all(userId);
|
||||||
|
if (rows.some((u) => nameKey(u.username) === key || nameKey(u.display_name) === key)) {
|
||||||
|
throw err("ENAMETAKEN", "displayName: another account already uses that name");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/** Write `validateProfile`'s result for one account. */
|
/** Write `validateProfile`'s result for one account. */
|
||||||
function setProfile(userId, fields) {
|
function setProfile(userId, fields) {
|
||||||
for (const [col, value] of Object.entries(fields)) {
|
for (const [col, value] of Object.entries(fields)) {
|
||||||
@@ -812,6 +854,8 @@ module.exports = {
|
|||||||
unassignWorkspace,
|
unassignWorkspace,
|
||||||
ownedWorkspaces,
|
ownedWorkspaces,
|
||||||
validateProfile,
|
validateProfile,
|
||||||
|
nameKey,
|
||||||
|
assertNameFree,
|
||||||
setProfile,
|
setProfile,
|
||||||
validatePassword,
|
validatePassword,
|
||||||
validateOwnPassword,
|
validateOwnPassword,
|
||||||
|
|||||||
@@ -555,12 +555,13 @@ async function usage(t0, t1, p0, p1, mem) {
|
|||||||
|
|
||||||
const round = (n) => Math.round(n * 10) / 10;
|
const round = (n) => Math.round(n * 10) / 10;
|
||||||
|
|
||||||
/** A user's group fields: id, username and display name (every viewer reads them). */
|
/** A user's group fields: id, username, display name and avatar version (every viewer reads them). */
|
||||||
const userExtra = (u) => ({
|
const userExtra = (u) => ({
|
||||||
kind: "user",
|
kind: "user",
|
||||||
userId: u.id,
|
userId: u.id,
|
||||||
username: u.username,
|
username: u.username,
|
||||||
displayName: u.displayName ?? null,
|
displayName: u.displayName ?? null,
|
||||||
|
avatarAt: u.avatarAt ?? null,
|
||||||
});
|
});
|
||||||
|
|
||||||
async function collect() {
|
async function collect() {
|
||||||
|
|||||||
@@ -6,7 +6,9 @@
|
|||||||
* swap it back in later, touching nothing but that login.
|
* swap it back in later, touching nothing but that login.
|
||||||
*
|
*
|
||||||
* - `codex`: the whole `$CODEX_HOME/auth.json` (a ChatGPT login or an API
|
* - `codex`: the whole `$CODEX_HOME/auth.json` (a ChatGPT login or an API
|
||||||
* key). Config, sessions, skills and history stay where they are.
|
* key). Config, sessions, skills and history stay where they are. A
|
||||||
|
* switch then restarts Codex's shared app-server daemon when one runs,
|
||||||
|
* so running and new sessions follow the new login (`follow`).
|
||||||
* - `omp`: every credential Oh My Pi stores, read with `omp auth export`
|
* - `omp`: every credential Oh My Pi stores, read with `omp auth export`
|
||||||
* and put back with `omp auth import -` (secrets on stdin, never argv).
|
* and put back with `omp auth import -` (secrets on stdin, never argv).
|
||||||
* Import MERGES, so a switch first empties omp's own credential tables in
|
* Import MERGES, so a switch first empties omp's own credential tables in
|
||||||
@@ -85,6 +87,15 @@ const codex = {
|
|||||||
writeJson(codexAuthFile(), secret);
|
writeJson(codexAuthFile(), secret);
|
||||||
return [codexAuthFile()];
|
return [codexAuthFile()];
|
||||||
},
|
},
|
||||||
|
// Codex ≥ 0.164 talks to the API through a shared app-server daemon that
|
||||||
|
// outlives every TUI and holds the login it started with: a new auth.json
|
||||||
|
// reached neither a running session nor a NEW one, which kept the old
|
||||||
|
// (often out-of-quota) account. Restarting the daemon makes it read the new
|
||||||
|
// login, and every open TUI reconnects to it on its own (verified on
|
||||||
|
// 0.164.0). No daemon running: nothing to restart — the next one reads the file.
|
||||||
|
follow() {
|
||||||
|
return restartCodexDaemon();
|
||||||
|
},
|
||||||
identify(auth) {
|
identify(auth) {
|
||||||
if (auth.tokens && auth.tokens.id_token) {
|
if (auth.tokens && auth.tokens.id_token) {
|
||||||
const c = jwtClaims(auth.tokens.id_token) || {};
|
const c = jwtClaims(auth.tokens.id_token) || {};
|
||||||
@@ -107,6 +118,26 @@ const codex = {
|
|||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/** The control socket's link points into a per-user runtime dir that exists only while a daemon runs. */
|
||||||
|
const codexDaemonSocket = () =>
|
||||||
|
path.join(getCodexHome(), "app-server-control", "app-server-control.sock");
|
||||||
|
|
||||||
|
/** Restart the CODEX_HOME's app-server daemon when one is running; true when a restart was started. */
|
||||||
|
function restartCodexDaemon() {
|
||||||
|
if (!fs.existsSync(codexDaemonSocket())) return false;
|
||||||
|
const bin = process.env.AGENTHUB_CODEX_BIN || require("./ai-tools").detect("codex").path;
|
||||||
|
if (!bin) return false;
|
||||||
|
cp.execFile(
|
||||||
|
bin,
|
||||||
|
["app-server", "daemon", "restart"],
|
||||||
|
{ env: { ...process.env, CODEX_HOME: getCodexHome() }, timeout: 60000, windowsHide: true },
|
||||||
|
(e) => {
|
||||||
|
if (e) console.warn(`[tool-profiles] codex daemon restart failed: ${e.message}`);
|
||||||
|
}
|
||||||
|
);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
// ── Oh My Pi ───────────────────────────────────────────────────────────
|
// ── Oh My Pi ───────────────────────────────────────────────────────────
|
||||||
|
|
||||||
const ompDir = () => process.env.AGENTHUB_OMP_DIR || path.join(os.homedir(), ".omp");
|
const ompDir = () => process.env.AGENTHUB_OMP_DIR || path.join(os.homedir(), ".omp");
|
||||||
@@ -405,7 +436,9 @@ function activateProfile(tool, name) {
|
|||||||
}
|
}
|
||||||
const target = readProfile(tool, name);
|
const target = readProfile(tool, name);
|
||||||
const written = a.write(target.secret, live);
|
const written = a.write(target.secret, live);
|
||||||
return { ok: true, name, savedOutgoing, written };
|
// `following`: running sessions take the new login without a restart of their own.
|
||||||
|
const following = typeof a.follow === "function" ? a.follow() : false;
|
||||||
|
return { ok: true, name, savedOutgoing, written, following };
|
||||||
}
|
}
|
||||||
|
|
||||||
function deleteProfile(tool, name) {
|
function deleteProfile(tool, name) {
|
||||||
|
|||||||
@@ -489,6 +489,11 @@ const paths = {
|
|||||||
items: { type: "string" },
|
items: { type: "string" },
|
||||||
description: "Files the switch wrote.",
|
description: "Files the switch wrote.",
|
||||||
},
|
},
|
||||||
|
following: {
|
||||||
|
type: "boolean",
|
||||||
|
description:
|
||||||
|
"Codex: a running app-server daemon was restarted, so open and new sessions use the new login.",
|
||||||
|
},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
"Switched."
|
"Switched."
|
||||||
|
|||||||
@@ -197,6 +197,7 @@ const { recordAccountChange } = require("../lib/audit");
|
|||||||
const ACCOUNT_STATUS = {
|
const ACCOUNT_STATUS = {
|
||||||
EBADFIELD: 400,
|
EBADFIELD: 400,
|
||||||
EBADEMAIL: 400,
|
EBADEMAIL: 400,
|
||||||
|
ENAMETAKEN: 409,
|
||||||
EBADPASSWORD: 400,
|
EBADPASSWORD: 400,
|
||||||
EWEAKPASSWORD: 400,
|
EWEAKPASSWORD: 400,
|
||||||
EBADIMAGE: 400,
|
EBADIMAGE: 400,
|
||||||
@@ -262,6 +263,7 @@ router.patch(
|
|||||||
sameOriginGuard,
|
sameOriginGuard,
|
||||||
accountWrite(async (_req, user, body) => {
|
accountWrite(async (_req, user, body) => {
|
||||||
const fields = auth.validateProfile({ displayName: body.displayName, email: body.email });
|
const fields = auth.validateProfile({ displayName: body.displayName, email: body.email });
|
||||||
|
auth.assertNameFree(user.id, fields);
|
||||||
auth.setProfile(user.id, fields);
|
auth.setProfile(user.id, fields);
|
||||||
return { out: accountView(user.id), action: "own profile" };
|
return { out: accountView(user.id), action: "own profile" };
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -702,7 +702,7 @@ router.get("/:id/file", async (req, res) => {
|
|||||||
function sessionStats(sessionId) {
|
function sessionStats(sessionId) {
|
||||||
const totalEvents = stmts.sessionEventCount.get(sessionId)?.count ?? 0;
|
const totalEvents = stmts.sessionEventCount.get(sessionId)?.count ?? 0;
|
||||||
const eventsByType = stmts.sessionEventTypeCounts.all(sessionId);
|
const eventsByType = stmts.sessionEventTypeCounts.all(sessionId);
|
||||||
const tools = stmts.sessionToolUsageCounts.all(sessionId);
|
const tools = stmts.sessionToolUsageCounts.all(sessionId, sessionId);
|
||||||
// Exact totals: `tools_used` is a top-15 list, so its sum is not the count.
|
// Exact totals: `tools_used` is a top-15 list, so its sum is not the count.
|
||||||
// A tool call is a PreToolUse; a session with none (imported) counts PostToolUse.
|
// A tool call is a PreToolUse; a session with none (imported) counts PostToolUse.
|
||||||
const toolTotals = stmts.sessionToolCallTotals.get(sessionId) || {};
|
const toolTotals = stmts.sessionToolCallTotals.get(sessionId) || {};
|
||||||
|
|||||||
@@ -171,6 +171,7 @@ router.get("/tmux", (_req, res) => {
|
|||||||
const STATUS = {
|
const STATUS = {
|
||||||
EBADUSER: 400,
|
EBADUSER: 400,
|
||||||
EBADEMAIL: 400,
|
EBADEMAIL: 400,
|
||||||
|
ENAMETAKEN: 409,
|
||||||
ENOTOWNED: 409,
|
ENOTOWNED: 409,
|
||||||
EBADPASSWORD: 400,
|
EBADPASSWORD: 400,
|
||||||
EWEAKPASSWORD: 400,
|
EWEAKPASSWORD: 400,
|
||||||
@@ -562,6 +563,7 @@ router.patch(
|
|||||||
|
|
||||||
// 1. Validate everything — nothing is written until all of it passes.
|
// 1. Validate everything — nothing is written until all of it passes.
|
||||||
const profile = auth.validateProfile(body);
|
const profile = auth.validateProfile(body);
|
||||||
|
auth.assertNameFree(u.id, profile);
|
||||||
const roleChange = body.role !== undefined && body.role !== u.role;
|
const roleChange = body.role !== undefined && body.role !== u.role;
|
||||||
if (roleChange) {
|
if (roleChange) {
|
||||||
if (self) throw ESELF("you cannot change your own role");
|
if (self) throw ESELF("you cannot change your own role");
|
||||||
|
|||||||
Reference in New Issue
Block a user