Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 890cd08f57 | |||
| aabc95768c | |||
| b34b201bd1 | |||
| c356cf96a1 | |||
| 2a31537b80 | |||
| 0cd853e330 |
@@ -1,6 +1,6 @@
|
||||
# Claude Code Working Guide
|
||||
|
||||
_Last synced: v2.8.73 (2026-11-04) — Claude quota rows carry `accountUuid`; the Artifacts folder bar is restyled._ A change that makes any statement in this file, `AGENTS.md`, or a README wrong — a moved path, a new or changed extension point, a retired rule — updates that file in the same change-set and bumps this marker. **Bump = replace the version/date and a ≤ 1-line summary; never append a changelog here** — details belong in the commit message and `docs/`, because this whole file is loaded into every session.
|
||||
_Last synced: v2.8.76 (2026-11-05) — four colour themes (Sunset Cloud, Terminal, Night Sea, Sakura); `--ansi-blue` for a non-blue accent._ A change that makes any statement in this file, `AGENTS.md`, or a README wrong — a moved path, a new or changed extension point, a retired rule — updates that file in the same change-set and bumps this marker. **Bump = replace the version/date and a ≤ 1-line summary; never append a changelog here** — details belong in the commit message and `docs/`, because this whole file is loaded into every session.
|
||||
|
||||
## Project mission
|
||||
- Maintain a reliable local-first dashboard for Claude Code session monitoring.
|
||||
@@ -61,7 +61,7 @@ A **workspace** — called a **lane** in the API, CLI, database and code, which
|
||||
- **The File Explorer (`server/lib/file-explorer.js`, `/api/lanes/:id/fs/*`) reuses the read path's guards and never replaces silently.** Every path is `lanePath` + the PARENT `resolveInLane`-confined with the last segment kept as a name (so a symlink is moved/deleted as a link, never followed); never in or under `.git`, never a secret, never the workspace folder itself. Writes run as the folder's account — a member's only through `write-as` (`move`/`copy` modes; `writeAsAsync` streams an upload to its stdin; a batch upload of many small files is ONE `extract` of a tar the server writes itself — folders and regular files only, names it checked, `tar -k`; a member's single file goes to a hidden temp name and is `write-as move`d onto its name only once every byte arrived, never written in place) — and a move/copy never crosses accounts (`sameOwner`, `EFOREIGN`). A taken name is settled by `conflict` (`fail` → 409 with `names`, `skip`, `keep`, `replace` = the old one to the trash first). Delete is a move into the account's trash (member: `~/.local/share/agenthub/trash/`, host: `<data dir>/trash/<user id>/`), restorable 7 days. `write-as` is root-installed: a change to it needs `agenthub server install-system` again (`EUPGRADE` until then). A user's HOME is browsed through the same module inside `inHome` (`/api/homes/:who/fs/*`, `server/lib/homes.js` picks the folder): every dot entry at the TOP of a home stays hidden and refused — through a symlink, a download, a zip or as a copy source too — and another user's home is an admin's READ-ONLY, audited view (`EREADONLY`) — except its TRASH, whose restore/purge an admin may run (`TRASH_W` in `server/routes/homes.js`, the owner's trash via `trashKey`, audited with the item id); keep that exception to the trash routes only. A home's Trash is its USER's one recycle bin (`listUserTrash`: home-account store + host store `<data dir>/trash/<user id>/`, items tagged `store`). **An upload survives a dashboard restart because its bytes are staged first** (`server/lib/upload-staging.js`): parts go to `<data dir>/upload-staging/<user>/<id>/` on the HOST, keyed by the caller's user and a browser-made id (never a path), and `?staged=<id>` on `upload`/`upload-batch` writes them through the SAME code and guards — a commit's answer is stored and replayed, never written twice. Do not add a staged write that skips `upload`/`uploadBatch`, nor stage inside a member's home. Do not add a delete that skips the trash, an overwrite without `conflict`, or a request path that is not run through `locate`/`folder`.
|
||||
- **The whole-file editor and the Files tab's upload are the two non-git writes on the lane file surface, and both live outside `git-ops.js` on purpose.** `git-ops.js` only touches paths `git status` reports as changed; `lane-file-write.js` may save any existing text file, so it must reuse the READ path's guards (`lanePath`, `resolveInLane`, `isSecretOnDisk`) and never be weaker than them, and it saves only over the `baseSha` it was opened at — do not let it create files or touch a binary. `lane-file-transfer.js`'s upload (`POST /api/lanes/:id/git/upload`, issue #78) is the opposite and only that: it CREATES one file (any bytes, ≤ 25 MB) under the same guards, into an existing folder, refuses a taken name (`EEXISTS`, a symlink included) and anything into or named `.git` (a hook there runs on the dashboard's next git call), and writes as the folder's member through `write-as` under S3 — do not let it overwrite, make folders or take a path from anything but `dir` + one plain name. Its `GET …/git/download` twin streams any file through `openSafe` as a `sandbox`ed attachment. The tree, expand-all and quick-open read the disk (`walkFolder`) for a folder that is not a repo.
|
||||
- **Server tests never touch the user's tmux.** Run them through `npm run test:server` (`scripts/test-server.js`), never a bare `node --test server/__tests__/*.test.js` from inside a lane pane — the suites create and kill real `agenthub-lane-<id>` sessions.
|
||||
- **An artifact is shared as a SNAPSHOT and installed only into the viewer's own account.** `server/lib/artifacts.js` (`/api/artifacts`): a pinned file or a skill is copied once into `<data dir>/artifacts/<random>/` and every viewer reads only that copy (an owner's edit of a skill — in the Hub, or in the skill's source folder, which the server takes when the Hub is listed and an installer's differing copy is then offered **Update** — writes a NEW snapshot and drops the old one — never a write into the one being read; the newer of the two changes wins; **Share again** (`POST /api/artifacts/:id/reshare`) takes the owner's folder on the server — else a user-scope plugin's same-named skill — on a click, and an upload named like the uploader's own skill, or carrying `id`, replaces that row's snapshot instead of adding a twin) — `raw` serves only a file the snapshot recorded, under a `sandbox` CSP + `nosniff`; a `page` is a `https://claude.ai/…` link only. A developer sees their own rows plus those shared with everyone (`shared`, the Hub) or with them by name (`artifact_shares`, **Shared with you** — the name list only its owner or an admin sees); only the owner or an admin changes one, and Share again never widens a by-name share to everyone. Artifact folders are the viewer's own (`agenthub.artifacts.folders` preference), never an artifact column. A `page` keeps a COPY anyone it reaches can view without the publishing claude.ai account — its HTML file (and the files the tool named) snapshotted at publish, or the `artifacts-export/<artifact id>.*` Claude saves for a Doc / Slides / Design (`scripts/artifact-export-hint.js`, the one hook that answers Claude: synchronous, matched to those tools only, silent outside AgentHub panes) attached at Stop; it is viewed in `HtmlFrame`'s sandbox or drawn by pdf.js, never fetched from claude.ai — do not add a route that proxies or logs into claude.ai for it. Install writes a skill into BOTH `~/.claude/skills/` and the cross-tool `~/.agents/skills/` of every account the CALLER's sessions run as (`installAccounts`: their S3 member home, plus the host's for an admin, whose host-folder workspaces run as the host; S3: as them through `write-as`), never over an existing one without `replace` (the old one is moved to `~/.claude/agenthub-replaced-skills/`, never deleted), and runs a plugin's `claude plugin marketplace add`/`install --scope user` as the caller, never with `-y`; Uninstall (`POST /api/artifacts/:id/uninstall`) takes it out of the same accounts — a skill MOVED to `agenthub-replaced-skills/`, never deleted, a plugin `claude plugin uninstall --scope user --keep-data`; an admin's switch (Settings → AI tools, `ArtifactsHubSettings`) turns installs off. An uploaded or written skill is snapshotted under the same checks (paths relative, no `..`, no secret names, zip sizes read before inflating). `POST /api/artifacts/plugin/inspect` clones a user-named https link only to read `marketplace.json`, with every credential helper OFF — never send a login with it. Do not add a route that serves a live file of another user, installs into someone else's account, or takes a plugin command from the request.
|
||||
- **An artifact is shared as a SNAPSHOT and installed only into the viewer's own account.** `server/lib/artifacts.js` (`/api/artifacts`): a pinned file or a skill is copied once into `<data dir>/artifacts/<random>/` and every viewer reads only that copy (an owner's edit of a skill — in the Hub, or in the skill's source folder, which the server takes when the Hub is listed and an installer's differing copy is then offered **Update** — writes a NEW snapshot and drops the old one — never a write into the one being read; the newer of the two changes wins; **Share again** (`POST /api/artifacts/:id/reshare`) takes the owner's folder on the server — else a user-scope plugin's same-named skill — on a click, and an upload named like the uploader's own skill, or carrying `id`, replaces that row's snapshot instead of adding a twin) — `raw` serves only a file the snapshot recorded, under a `sandbox` CSP + `nosniff`; a `page` is a `https://claude.ai/…` link only. A developer sees their own rows plus those shared with everyone (`shared`, the Hub) or with them by name (`artifact_shares`, **Shared with you** — the name list only its owner or an admin sees); only the owner or an admin changes one, and Share again never widens a by-name share to everyone. Artifact folders are the viewer's own (`agenthub.artifacts.folders` preference), never an artifact column. A `page` keeps a COPY anyone it reaches can view without the publishing claude.ai account — its HTML file (and the files the tool named) snapshotted at publish from the workspace folder or the publishing session's own Claude Code scratchpad (`<tmp>/claude-<uid>/<project>/<session id>/scratchpad`, its folders real dirs of the workspace's account, each file opened `O_NOFOLLOW` and owned by it — never any other path), or the `artifacts-export/<artifact id>.*` Claude saves for a Doc / Slides / Design (`scripts/artifact-export-hint.js`, the one hook that answers Claude: synchronous, matched to those tools only, silent outside AgentHub panes) attached at Stop; it is viewed in `HtmlFrame`'s sandbox or drawn by pdf.js, never fetched from claude.ai — do not add a route that proxies or logs into claude.ai for it. Install writes a skill into BOTH `~/.claude/skills/` and the cross-tool `~/.agents/skills/` of every account the CALLER's sessions run as (`installAccounts`: their S3 member home, plus the host's for an admin, whose host-folder workspaces run as the host; S3: as them through `write-as`), never over an existing one without `replace` (the old one is moved to `~/.claude/agenthub-replaced-skills/`, never deleted), and runs a plugin's `claude plugin marketplace add`/`install --scope user` as the caller, never with `-y`; Uninstall (`POST /api/artifacts/:id/uninstall`) takes it out of the same accounts — a skill MOVED to `agenthub-replaced-skills/`, never deleted, a plugin `claude plugin uninstall --scope user --keep-data`; an admin's switch (Settings → AI tools, `ArtifactsHubSettings`) turns installs off. An uploaded or written skill is snapshotted under the same checks (paths relative, no `..`, no secret names, zip sizes read before inflating). `POST /api/artifacts/plugin/inspect` clones a user-named https link only to read `marketplace.json`, with every credential helper OFF — never send a login with it. Do not add a route that serves a live file of another user, installs into someone else's account, or takes a plugin command from the request.
|
||||
- **A workspace's instructions, extra folders and context files are lane facts, and a pane reads them only from the lane's rows.** The one addition is the workspace OWNER's own agent instructions (`user_prefs.instructions`, `PUT /api/me/instructions`, Settings → AI tools), which `launchExtras` puts first — keyed by `lanes.owner_id` (`local` in local mode), never by whoever clicked Start. `lanes.instructions` and `lane_sources` (`server/lib/lane-sources.js`) reach a pane through `launchExtras(laneId, tool)`, which `spawnRun` calls ITSELF — so neither spawn path can take them from a request — and every write is same-origin (`server/routes/lane-sources.js`). A folder must be absolute, exist, be a directory, not be or contain the OS home (`validateHomeDir`) and not be the workspace's own folder; it is the user's, and AgentHub never deletes it. An uploaded file is stored under `<data dir>/workspace-context/<lane id>/` under a name AgentHub derives (never a path from the request), and those copies are the only thing here AgentHub deletes (`ownsFile`): with their row, and with the workspace in `deleteLane`. Claude's `--add-dir` is VARIADIC, so it goes first in the argv where `--permission-mode` ends it, and the text (instructions + context file list + extra folders) is written at every spawn as the ONLY file `CLAUDE.md` of `<data dir>/workspace-prompts/<lane id>/` (a member's: `prompt-<lane id>/` in their handoff dir, via `write-as`), which goes in as one more `--add-dir` with `CLAUDE_CODE_ADDITIONAL_DIRECTORIES_CLAUDE_MD=1` in the pane env — never `--append-system-prompt-file`: a custom system prompt is a launch flag Claude cannot carry over a restart, so it refused `/tui` in every pane with instructions (side effect: a CLAUDE.md in an extra folder is now read too); Codex gets one `--add-dir` per directory and `-c developer_instructions=<JSON string>` — the text itself up to 6 KB, else a line pointing at that file. Only `claude`/`codex` take them. Never write them into the user's repo (CLAUDE.md/AGENTS.md).
|
||||
- **A workspace's sessions are the ones it OWNS, never the ones that ran in its folder.** `sessions.lane_id` is stamped by `bindRunSession` (`server/routes/hooks.js`) for the session a dashboard pane holds — first writer wins, a nested `claude -p` excluded — and no route sets it. A Codex/Antigravity session (their hooks are opt-in, so a pane may never learn its session) is also stamped by `claimToolSessions` (`server/lib/dashboard-runs.js`, called by both pollers and once at start): the lane of the newest same-tool dashboard run in the session's folder that was live when the session started, never a Claude session. A new Claude pane is started with `--session-id <uuid>` (`spawnRun`), so its `dashboard_runs.session_id` is known before any hook and a hook that carries no `run_id` (a hook handler older than `AGENTHUB_RUN_ID` forwarding) is still stamped from that run (`laneForSession`). Every workspace session list reads `GET /api/sessions?lane=<id>` — which also counts a still-unstamped session one of the lane's `dashboard_runs` holds, because hooks reach only the lowest-port dashboard on a shared DB and that one may be an older build that never stamps — and shows nothing else (no "other sessions in this folder"). Do not go back to listing a workspace by `cwd`, and do not guess ownership for old history. Billing has one more owner: a session NO workspace owns belongs to the user of the Linux account it ran as (`sessions.account` — the hook's peer, else its folder; `server/lib/session-account.js`, the host's account → the admin marked `users.host_account`, else the only admin), so a script's `claude -p` counts in Today, the Users page and spend quotas — a workspace's ownership always wins over it.
|
||||
- **A session's worktree is `claude --worktree`'s, resolved from the session row — and removing it never forces.** A Worktree start passes `--worktree=<server-made name>` (the `=` form: `-w [name]` eats the prompt otherwise) and Claude Code makes, populates and cleans up `<repo>/.claude/worktrees/<name>`; AgentHub only excludes `/.claude/worktrees/` at the repo root. A git route, a resume or a removal may work in a session's worktree only through `sessionWorktree` (`server/lib/session-worktree.js`: the session owned by the lane, its cwd not the lane's folder, registered by `git worktree list`) — `?session=` on the git routes answers `ENOWORKTREE` rather than falling back to the main folder. `POST /api/lanes/:id/session-worktree/remove` (same-origin, `confirm: true`, refused while a live pane holds the session) is the ONE dashboard path that deletes a worktree: `git worktree remove` with no `--force`, `git branch -d` never `-D`, a live-pid lock refused. Do not add a force, and do not let it touch a lane's own folder.
|
||||
|
||||
@@ -60,6 +60,10 @@ export const THEME_LABELS: Record<string, string> = {
|
||||
canvas: "Canvas",
|
||||
"orca-dark": "Orca Dark",
|
||||
"orca-light": "Orca Light",
|
||||
"sunset-cloud": "Sunset Cloud",
|
||||
terminal: "Terminal",
|
||||
"night-sea": "Night Sea",
|
||||
sakura: "Sakura",
|
||||
};
|
||||
|
||||
const MODES: { mode: ThemeMode; Icon: typeof Moon }[] = [
|
||||
|
||||
@@ -53,6 +53,10 @@ describe("AppearanceSettings", () => {
|
||||
"Apple Light",
|
||||
"Canvas",
|
||||
"Orca Light",
|
||||
"Sunset Cloud",
|
||||
"Terminal",
|
||||
"Night Sea",
|
||||
"Sakura",
|
||||
]) {
|
||||
expect(screen.getByText(name)).toBeInTheDocument();
|
||||
}
|
||||
|
||||
@@ -103,6 +103,19 @@ describe("useTheme", () => {
|
||||
expect(document.documentElement.dataset.theme).toBe("orca-light");
|
||||
});
|
||||
|
||||
it("applies the ai-chat-themes palettes by id, each in its own mode only", () => {
|
||||
const { result } = renderHook(() => useTheme());
|
||||
for (const name of ["sunset-cloud", "terminal", "night-sea"]) {
|
||||
act(() => result.current.setThemeFor("dark", name));
|
||||
expect(document.documentElement.dataset.theme).toBe(name);
|
||||
}
|
||||
act(() => result.current.setThemeFor("dark", "sakura"));
|
||||
expect(result.current.themeFor.dark).toBe("night-sea");
|
||||
act(() => result.current.setThemeFor("light", "sakura"));
|
||||
act(() => result.current.toggleTheme());
|
||||
expect(document.documentElement.dataset.theme).toBe("sakura");
|
||||
});
|
||||
|
||||
it("the default theme carries no data-theme attribute", () => {
|
||||
const { result } = renderHook(() => useTheme());
|
||||
act(() => result.current.setThemeFor("dark", "darcula"));
|
||||
|
||||
@@ -22,8 +22,8 @@ export type ThemeMode = Theme | "system";
|
||||
|
||||
/** Named themes per mode, in picker order. `default` is the stock palette. */
|
||||
export const THEMES = {
|
||||
dark: ["default", "darcula", "apple-dark", "orca-dark"],
|
||||
light: ["default", "canvas", "apple-light", "orca-light"],
|
||||
dark: ["default", "darcula", "apple-dark", "orca-dark", "sunset-cloud", "terminal", "night-sea"],
|
||||
light: ["default", "canvas", "apple-light", "orca-light", "sakura"],
|
||||
} as const satisfies Record<Theme, readonly string[]>;
|
||||
|
||||
const MODE_KEY = "theme";
|
||||
|
||||
@@ -270,7 +270,7 @@
|
||||
"folders.takeOut": "Take it out of its folder",
|
||||
"page.view": "View",
|
||||
"page.viewHint": "Its copy, viewable here without the claude.ai account that published it",
|
||||
"page.noCopy": "No viewable copy: the file this page was published from is gone. Open it on claude.ai instead.",
|
||||
"page.noCopy": "No viewable copy: the file this page was published from is gone, or lies outside this workspace and its session's scratchpad. Open it on claude.ai instead.",
|
||||
"pdf.page": "Page {{n}}",
|
||||
"pdf.failed": "This PDF could not be shown. Download it instead.",
|
||||
"pdf.more": "Showing the first {{shown}} of {{total}} pages — download it for the rest.",
|
||||
|
||||
@@ -268,7 +268,7 @@
|
||||
"folders.takeOut": "Bỏ khỏi thư mục",
|
||||
"page.view": "Xem",
|
||||
"page.viewHint": "Bản sao xem được ngay tại đây, không cần tài khoản claude.ai đã tạo trang",
|
||||
"page.noCopy": "Chưa có bản xem: file gốc của trang này không còn. Hãy mở trên claude.ai.",
|
||||
"page.noCopy": "Chưa có bản xem: file gốc của trang này không còn, hoặc nằm ngoài workspace và scratchpad của phiên. Hãy mở trên claude.ai.",
|
||||
"pdf.page": "Trang {{n}}",
|
||||
"pdf.failed": "Không hiển thị được PDF này. Hãy tải về.",
|
||||
"pdf.more": "Đang hiện {{shown}}/{{total}} trang đầu — tải về để xem hết.",
|
||||
|
||||
@@ -350,6 +350,106 @@
|
||||
--syn-del: 197 0 15; /* #c5000f */
|
||||
}
|
||||
|
||||
/* Sunset Cloud, Terminal, Night Sea (dark) and Sakura (light) — the colour
|
||||
* themes of ai-chat-themes (github.com/Aohkne/ai-chat-themes, MIT), which
|
||||
* gives only a background, a text and an accent colour per theme. Every
|
||||
* other token is derived from those three and held to the bar above: text
|
||||
* ≥ 4.5:1 on a card and on its hover lift, the text accent ≥ 4.5:1 on a card
|
||||
* and on its own /15 chip (Sakura's #e0567f and Sunset's #ff8a6b darkened /
|
||||
* lightened to get there), white ≥ 4.5:1 on `--accent-solid`, each status
|
||||
* label ≥ 4.5:1 on its /20 chip. Their fonts (a monospace UI, Georgia) are
|
||||
* not taken; syntax, diff and `--kept` colours are their mode's defaults.
|
||||
* `--ansi-blue` (read only by `lib/terminalTheme.ts`) keeps a terminal's
|
||||
* blue blue where the accent is green or coral. */
|
||||
.dark[data-theme="sunset-cloud"] {
|
||||
--surface-0: 32 24 36; /* #201824 */
|
||||
--surface-1: 48 37 52; /* #302534 */
|
||||
--surface-2: 54 43 58; /* #362b3a */
|
||||
--surface-3: 60 49 63; /* #3c313f */
|
||||
--surface-4: 67 56 69; /* #433845 */
|
||||
--surface-5: 75 63 76; /* #4b3f4c */
|
||||
--border: 76 64 76; /* #4c404c */
|
||||
--border-light: 88 76 87; /* #584c57 */
|
||||
--accent: 255 159 134; /* #ff9f86 */
|
||||
--accent-hover: 255 188 170; /* #ffbcaa */
|
||||
--accent-solid: 173 94 73; /* #ad5e49 */
|
||||
--accent-solid-hover: 149 81 63; /* #95513f */
|
||||
--fg-primary: 247 232 226; /* #f7e8e2 */
|
||||
--fg-secondary: 214 203 203; /* #d6cbcb */
|
||||
--fg-muted: 176 165 168; /* #b0a5a8 */
|
||||
--status-success: 88 220 156; /* #58dc9c */
|
||||
--status-danger: 255 176 173; /* #ffb0ad */
|
||||
--status-warning: 255 202 22; /* #ffca16 */
|
||||
/* ANSI blue in the terminal: the accent is not blue here. */
|
||||
--ansi-blue: 112 184 255; /* #70b8ff */
|
||||
}
|
||||
|
||||
.dark[data-theme="terminal"] {
|
||||
--surface-0: 8 13 9; /* #080d09 */
|
||||
--surface-1: 14 23 17; /* #0e1711 */
|
||||
--surface-2: 20 30 22; /* #141e16 */
|
||||
--surface-3: 25 36 28; /* #19241c */
|
||||
--surface-4: 31 44 34; /* #1f2c22 */
|
||||
--surface-5: 37 52 41; /* #253429 */
|
||||
--border: 38 54 42; /* #26362a */
|
||||
--border-light: 49 67 53; /* #314335 */
|
||||
--accent: 57 232 122; /* #39e87a */
|
||||
--accent-hover: 116 239 162; /* #74efa2 */
|
||||
--accent-solid: 32 132 70; /* #208446 */
|
||||
--accent-solid-hover: 28 114 60; /* #1c723c */
|
||||
--fg-primary: 185 246 198; /* #b9f6c6 */
|
||||
--fg-secondary: 147 196 157; /* #93c49d */
|
||||
--fg-muted: 117 154 125; /* #759a7d */
|
||||
--status-success: 61 214 140; /* #3dd68c */
|
||||
--status-danger: 255 149 146; /* #ff9592 */
|
||||
--status-warning: 255 202 22; /* #ffca16 */
|
||||
/* ANSI blue in the terminal: the accent is not blue here. */
|
||||
--ansi-blue: 112 184 255; /* #70b8ff */
|
||||
}
|
||||
|
||||
.dark[data-theme="night-sea"] {
|
||||
--surface-0: 11 20 33; /* #0b1421 */
|
||||
--surface-1: 20 31 49; /* #141f31 */
|
||||
--surface-2: 26 37 55; /* #1a2537 */
|
||||
--surface-3: 32 43 62; /* #202b3e */
|
||||
--surface-4: 40 50 69; /* #283245 */
|
||||
--surface-5: 47 58 76; /* #2f3a4c */
|
||||
--border: 48 59 77; /* #303b4d */
|
||||
--border-light: 60 71 89; /* #3c4759 */
|
||||
--accent: 92 175 255; /* #5cafff */
|
||||
--accent-hover: 141 199 255; /* #8dc7ff */
|
||||
--accent-solid: 62 120 176; /* #3e78b0 */
|
||||
--accent-solid-hover: 53 103 151; /* #356797 */
|
||||
--fg-primary: 220 230 250; /* #dce6fa */
|
||||
--fg-secondary: 183 192 210; /* #b7c0d2 */
|
||||
--fg-muted: 146 155 173; /* #929bad */
|
||||
--status-success: 61 214 140; /* #3dd68c */
|
||||
--status-danger: 255 155 153; /* #ff9b99 */
|
||||
--status-warning: 255 202 22; /* #ffca16 */
|
||||
}
|
||||
|
||||
[data-mode="light"][data-theme="sakura"] {
|
||||
--surface-0: 242 230 232; /* #f2e6e8 */
|
||||
--surface-1: 247 235 237; /* #f7ebed */
|
||||
--surface-2: 251 240 242; /* #fbf0f2 */
|
||||
--surface-3: 255 249 250; /* #fff9fa */
|
||||
--surface-4: 255 252 253; /* #fffcfd */
|
||||
--surface-5: 255 255 255; /* #ffffff */
|
||||
--border: 224 210 213; /* #e0d2d5 */
|
||||
--border-light: 237 224 227; /* #ede0e3 */
|
||||
--accent: 167 64 95; /* #a7405f */
|
||||
--accent-hover: 137 52 78; /* #89344e */
|
||||
--accent-solid: 195 75 110; /* #c34b6e */
|
||||
--accent-solid-hover: 168 65 95; /* #a8415f */
|
||||
--fg-primary: 75 42 53; /* #4b2a35 */
|
||||
--fg-secondary: 107 80 89; /* #6b5059 */
|
||||
--fg-muted: 120 97 105; /* #786169 */
|
||||
--status-success: 23 105 45; /* #17692d */
|
||||
--status-danger: 173 28 38; /* #ad1c26 */
|
||||
--status-warning: 124 82 0; /* #7c5200 */
|
||||
--shadow-card: 0 1px 2px rgb(75 42 53 / 0.06), 0 2px 6px rgb(75 42 53 / 0.07);
|
||||
}
|
||||
|
||||
@layer base {
|
||||
body {
|
||||
font-weight: 500;
|
||||
|
||||
@@ -39,6 +39,11 @@ describe("buildTerminalTheme", () => {
|
||||
expect(t.brightWhite).toBe("#edeef0");
|
||||
});
|
||||
|
||||
it("takes ANSI blue from --ansi-blue when a theme's accent is not blue", () => {
|
||||
const t = buildTerminalTheme((n) => ({ ...vars, "--ansi-blue": "112 184 255" })[n] ?? "");
|
||||
expect(t.blue).toBe("#70b8ff");
|
||||
});
|
||||
|
||||
it("makes each bright twin lighter than its base colour", () => {
|
||||
const t = buildTerminalTheme((n) => vars[n] ?? "");
|
||||
const sum = (hex: string) =>
|
||||
|
||||
@@ -40,7 +40,9 @@ function lighten(hex: string | undefined, amount: number): string | undefined {
|
||||
|
||||
/**
|
||||
* Build an xterm theme from a theme's CSS variables. red/green/yellow come from
|
||||
* `--status-*`, blue from `--accent`, black/white from the surface/fg ramp.
|
||||
* `--status-*`, blue from `--ansi-blue` when a theme sets one (its accent is
|
||||
* not blue: Terminal's green, Sunset Cloud's coral) else `--accent`,
|
||||
* black/white from the surface/fg ramp.
|
||||
* Magenta and cyan stay the classic ANSI hues: no token keeps that hue in every
|
||||
* theme (darcula's keyword is orange), and a program printing "magenta" should
|
||||
* get magenta.
|
||||
@@ -50,7 +52,7 @@ export function buildTerminalTheme(read: VarReader): ITheme {
|
||||
const red = v("--status-danger");
|
||||
const green = v("--status-success");
|
||||
const yellow = v("--status-warning");
|
||||
const blue = v("--accent");
|
||||
const blue = v("--ansi-blue") ?? v("--accent");
|
||||
const magenta = "#c678dd";
|
||||
const cyan = "#56b6c2";
|
||||
return {
|
||||
|
||||
@@ -7316,7 +7316,7 @@ exports[`screen snapshots > Settings — about 1`] = `
|
||||
<span
|
||||
class="text-status-warning/90"
|
||||
>
|
||||
UI build v2.8.73 (rebuild client to match)
|
||||
UI build v2.8.76 (rebuild client to match)
|
||||
</span>
|
||||
</p>
|
||||
</div>
|
||||
|
||||
+3
-2
@@ -84,8 +84,9 @@ Internal build — all rights reserved.
|
||||
- **Updates.** Release-based update detection with an in-UI **Update all**
|
||||
(marketplaces → every plugin → AgentHub last → one session reload).
|
||||
- **Appearance.** Settings → Appearance picks Dark / Light / System (follows the
|
||||
OS live) and a theme per mode — dark: Default, Darcula, Apple Dark, Orca Dark;
|
||||
light: Default, Apple Light, Canvas, Orca Light. Each mode
|
||||
OS live) and a theme per mode — dark: Default, Darcula, Apple Dark, Orca Dark,
|
||||
Sunset Cloud, Terminal, Night Sea; light: Default, Apple Light, Canvas, Orca
|
||||
Light, Sakura (the four last from ai-chat-themes, colours only). Each mode
|
||||
remembers its own theme, so the sidebar's quick toggle swaps between the two.
|
||||
It also picks the workspace terminals' font: JetBrains Mono (default), the
|
||||
rounded Maple Mono, or the browser's own fixed-width
|
||||
|
||||
@@ -14,7 +14,7 @@ One place to keep what agents PRODUCE, and (in server mode) to share it:
|
||||
| `plugin` | A plugin by marketplace source + name (no files) | picked from the list a marketplace link answers (`POST /api/artifacts/plugin/inspect`), or typed as `name@marketplace` |
|
||||
|
||||
- **Local mode:** one personal library, no sharing UI.
|
||||
- **Server mode:** every artifact is the OWNER's and private by default. The owner can **Share** it with everyone — it appears in the **Hub** for every signed-in user — or with chosen people only (`artifact_shares`; they find it under **Shared with you**). A `page` keeps a viewable copy — its HTML file, or the copy Claude exports of a Doc / Slides / Design (`artifacts-export/`) — so the people it is shared with need no access to the claude.ai account that published it. A shared skill or plugin can be **installed** into the viewer's own account.
|
||||
- **Server mode:** every artifact is the OWNER's and private by default. The owner can **Share** it with everyone — it appears in the **Hub** for every signed-in user — or with chosen people only (`artifact_shares`; they find it under **Shared with you**). A `page` keeps a viewable copy — its HTML file (from the workspace folder, or from the publishing session's own Claude Code scratchpad, where the Artifact tool writes a page by default), or the copy Claude exports of a Doc / Slides / Design (`artifacts-export/`) — so the people it is shared with need no access to the claude.ai account that published it. A shared skill or plugin can be **installed** into the viewer's own account.
|
||||
|
||||
## Rules (binding, same spirit as CLAUDE.md)
|
||||
|
||||
|
||||
Generated
+2
-2
@@ -1,12 +1,12 @@
|
||||
{
|
||||
"name": "agenthub",
|
||||
"version": "2.8.73",
|
||||
"version": "2.8.76",
|
||||
"lockfileVersion": 3,
|
||||
"requires": true,
|
||||
"packages": {
|
||||
"": {
|
||||
"name": "agenthub",
|
||||
"version": "2.8.73",
|
||||
"version": "2.8.76",
|
||||
"hasInstallScript": true,
|
||||
"license": "UNLICENSED",
|
||||
"dependencies": {
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "agenthub",
|
||||
"version": "2.8.73",
|
||||
"version": "2.8.76",
|
||||
"bin": {
|
||||
"agenthub": "bin/agenthub.js"
|
||||
},
|
||||
|
||||
@@ -30,6 +30,8 @@ process.env.CLAUDE_HOME = path.join(ROOT, "claude");
|
||||
process.env.DASHBOARD_DATA_DIR = path.join(ROOT, "data");
|
||||
process.env.DASHBOARD_REMOTE_SYNC_MS = "0";
|
||||
process.env.DASHBOARD_LIVENESS_PROBE = "0";
|
||||
// Claude Code's scratchpads (`<tmp>/claude-<uid>/…`) go under this test's own folder.
|
||||
process.env.CLAUDE_CODE_TMPDIR = ROOT;
|
||||
|
||||
const { createApp } = require("../index");
|
||||
const { db } = require("../db");
|
||||
@@ -1223,6 +1225,92 @@ describe("a page's own copy, viewable without its claude.ai account", () => {
|
||||
}
|
||||
});
|
||||
|
||||
// The Artifact tool writes a page into the session's own scratchpad by default.
|
||||
const scratchpad = (sid, cwd = ws) =>
|
||||
path.join(
|
||||
ROOT,
|
||||
`claude-${process.getuid()}`,
|
||||
cwd.replace(/[^A-Za-z0-9]/g, "-"),
|
||||
sid,
|
||||
"scratchpad"
|
||||
);
|
||||
const SID = "5f0c1e2a-6b7d-4c8e-9f10-112233445566";
|
||||
|
||||
it("copies a page published from its session's scratchpad", async () => {
|
||||
db.prepare(
|
||||
"INSERT OR IGNORE INTO sessions (id, name, status, cwd, lane_id) VALUES (?, 'sp', 'active', ?, ?)"
|
||||
).run(SID, ws, lane.id);
|
||||
const dir = scratchpad(SID);
|
||||
fs.mkdirSync(dir, { recursive: true });
|
||||
fs.writeFileSync(path.join(dir, "themes.html"), "<h1>themes</h1>");
|
||||
fs.writeFileSync(path.join(dir, "app.js"), "1");
|
||||
const row = artifacts.captureFromHook(SID, {
|
||||
cwd: ws,
|
||||
tool_input: {
|
||||
action: "publish",
|
||||
file_path: path.join(dir, "themes.html"),
|
||||
files: { "app.js": path.join(dir, "app.js"), "x.html": path.join(ws, "pub", "deck.html") },
|
||||
},
|
||||
tool_response: "https://claude.ai/artifact/scratch-1",
|
||||
});
|
||||
await Promise.all(artifacts.__pageCopies());
|
||||
const kept = db.prepare("SELECT files FROM artifacts WHERE id = ?").get(row.id);
|
||||
assert.ok(kept.files, "the page has a copy");
|
||||
// A supporting file comes only from the page's own root, never the workspace.
|
||||
assert.deepEqual(
|
||||
JSON.parse(kept.files).map((f) => f.path),
|
||||
["themes.html", "app.js"]
|
||||
);
|
||||
assert.match(fs.readFileSync(artifacts.snapshotFile(null, row.id).abs, "utf8"), /themes/);
|
||||
});
|
||||
|
||||
it("never copies from another session's scratchpad or through a linked one", async () => {
|
||||
const other = scratchpad("other-session-1");
|
||||
fs.mkdirSync(other, { recursive: true });
|
||||
fs.writeFileSync(path.join(other, "x.html"), "<p>not mine</p>");
|
||||
const foreign = artifacts.captureFromHook(SID, {
|
||||
cwd: ws,
|
||||
tool_input: { action: "publish", file_path: path.join(other, "x.html") },
|
||||
tool_response: "https://claude.ai/artifact/scratch-foreign",
|
||||
});
|
||||
// A scratchpad that is a link to somewhere else is refused too.
|
||||
const sid2 = "linked-session-2";
|
||||
const real = path.join(ROOT, "elsewhere");
|
||||
fs.mkdirSync(real, { recursive: true });
|
||||
fs.writeFileSync(path.join(real, "y.html"), "<p>elsewhere</p>");
|
||||
fs.mkdirSync(path.dirname(scratchpad(sid2)), { recursive: true });
|
||||
fs.symlinkSync(real, scratchpad(sid2));
|
||||
const linked = artifacts.captureFromHook(sid2, {
|
||||
cwd: ws,
|
||||
tool_input: { action: "publish", file_path: path.join(scratchpad(sid2), "y.html") },
|
||||
tool_response: "https://claude.ai/artifact/scratch-linked",
|
||||
});
|
||||
await Promise.all(artifacts.__pageCopies());
|
||||
for (const r of [foreign, linked]) {
|
||||
assert.equal(
|
||||
db.prepare("SELECT snapshot FROM artifacts WHERE id = ?").get(r.id).snapshot,
|
||||
null
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
it("takes an older scratchpad page's copy on first view", async () => {
|
||||
fs.writeFileSync(path.join(scratchpad(SID), "older.html"), "<p>older</p>");
|
||||
const id = Number(
|
||||
db
|
||||
.prepare(
|
||||
"INSERT INTO artifacts (kind, title, lane_id, session_id, source, url) VALUES ('page', 'older', ?, ?, ?, 'https://claude.ai/artifact/older-sp')"
|
||||
)
|
||||
.run(lane.id, SID, path.join(scratchpad(SID), "older.html")).lastInsertRowid
|
||||
);
|
||||
const r = await request("POST", `/api/artifacts/${id}/copy`, {});
|
||||
assert.equal(r.status, 200, r.text);
|
||||
assert.deepEqual(
|
||||
r.body.item.files.map((f) => f.path),
|
||||
["older.html"]
|
||||
);
|
||||
});
|
||||
|
||||
it("takes an older page's copy on first view, once", async () => {
|
||||
fs.writeFileSync(path.join(ws, "pub", "old.html"), "<p>old</p>");
|
||||
const id = Number(
|
||||
|
||||
@@ -0,0 +1,66 @@
|
||||
/**
|
||||
* @file Regression: transcript lookups in claude-home.js find a file by
|
||||
* `stat`, never `fs.existsSync`. existsSync is access(2), which the kernel runs
|
||||
* with the capabilities cleared, so under S3 it reported a member's live
|
||||
* transcript (behind their 0700 `~/.claude/projects`) as missing and the chat
|
||||
* served the stale import-time snapshot — a whole turn shown in the terminal
|
||||
* never reached the chat. Here `fs.existsSync` is stubbed to answer "no" for
|
||||
* everything under the temp Claude home, as access(2) does for the unit.
|
||||
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
||||
*/
|
||||
|
||||
const os = require("node:os");
|
||||
const fs = require("node:fs");
|
||||
const path = require("node:path");
|
||||
const { describe, it, before, after } = require("node:test");
|
||||
const assert = require("node:assert/strict");
|
||||
|
||||
const ROOT = fs.mkdtempSync(path.join(os.tmpdir(), "agenthub-access-blind-"));
|
||||
const SAVED_HOME = process.env.CLAUDE_HOME;
|
||||
process.env.CLAUDE_HOME = ROOT;
|
||||
|
||||
const ch = require("../lib/claude-home");
|
||||
|
||||
const SID = "11111111-2222-3333-4444-555555555555";
|
||||
const CWD = "/work/demo-repo";
|
||||
const PROJECT = path.join(ROOT, "projects", ch.encodeCwd(CWD));
|
||||
const MAIN = path.join(PROJECT, `${SID}.jsonl`);
|
||||
const SUB = path.join(PROJECT, SID, "subagents", "agent-abc.jsonl");
|
||||
const NESTED = path.join(PROJECT, SID, "subagents", "workflows", "wf_1", "agent-xyz.jsonl");
|
||||
|
||||
const realExists = fs.existsSync;
|
||||
|
||||
describe("claude-home transcript lookups when access(2) is blind", () => {
|
||||
before(() => {
|
||||
for (const f of [MAIN, SUB, NESTED]) {
|
||||
fs.mkdirSync(path.dirname(f), { recursive: true });
|
||||
fs.writeFileSync(f, "{}\n");
|
||||
}
|
||||
fs.existsSync = (p) => (String(p).startsWith(ROOT) ? false : realExists(p));
|
||||
});
|
||||
after(() => {
|
||||
fs.existsSync = realExists;
|
||||
if (SAVED_HOME === undefined) delete process.env.CLAUDE_HOME;
|
||||
else process.env.CLAUDE_HOME = SAVED_HOME;
|
||||
fs.rmSync(ROOT, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
it("getTranscriptPath finds the live main transcript", () => {
|
||||
assert.equal(ch.getTranscriptPath(SID, CWD), MAIN);
|
||||
});
|
||||
|
||||
it("findTranscriptPath finds it by scanning", () => {
|
||||
assert.equal(ch.findTranscriptPath(SID, CWD), MAIN);
|
||||
});
|
||||
|
||||
it("subagent transcripts (flat and nested Workflow) are found", () => {
|
||||
assert.equal(ch.findSubagentTranscriptPath(SID, "abc", null, CWD), SUB);
|
||||
assert.equal(ch.findSubagentTranscriptPath(SID, "xyz", "wf_1", CWD), NESTED);
|
||||
assert.equal(ch.findSubagentTranscriptPath(SID, "xyz", null, CWD), NESTED);
|
||||
});
|
||||
|
||||
it("a missing transcript is still reported missing", () => {
|
||||
assert.equal(ch.getTranscriptPath("no-such-session", CWD), null);
|
||||
assert.equal(ch.exists(path.join(ROOT, "nope")), false);
|
||||
});
|
||||
});
|
||||
+122
-21
@@ -494,7 +494,8 @@ function captureFromHook(sessionId, data, peer = null) {
|
||||
const file = typeof input.file_path === "string" ? input.file_path : "";
|
||||
// A publish of a page from a file: keep a copy anyone it is shared with can
|
||||
// view here, without a claude.ai login (a republish takes the new version).
|
||||
const copy = laneId != null && file ? pageCopy(laneId, data?.cwd, file, input.files) : null;
|
||||
const copy =
|
||||
laneId != null && file ? pageCopy(laneId, data?.cwd, file, input.files, sessionId) : null;
|
||||
if (same) {
|
||||
if (copy) schedulePageSnapshot(same.id, copy);
|
||||
return same;
|
||||
@@ -522,6 +523,9 @@ function captureFromHook(sessionId, data, peer = null) {
|
||||
// such file: Claude is asked (scripts/artifact-export-hint.js) to export a
|
||||
// copy to `artifacts-export/<artifact id>.(md|pdf)`, which the Stop capture
|
||||
// attaches to the row instead (`captureOutputsNow`).
|
||||
// The file is taken from the workspace folder OR from the publishing
|
||||
// session's own Claude Code scratchpad — where the Artifact tool writes a
|
||||
// page by default — and from nowhere else.
|
||||
|
||||
const PAGE_FILE_EXT = /\.html?$/i;
|
||||
const PAGE_FILES_MAX = 50;
|
||||
@@ -530,29 +534,118 @@ const PUBLISHED_RE =
|
||||
/** Where Claude is asked to export a typed artifact's copy. */
|
||||
const EXPORT_DIR = "artifacts-export";
|
||||
|
||||
const SESSION_ID_RE = /^[A-Za-z0-9_-]{1,128}$/;
|
||||
/** Claude Code's name for a project folder in its temp tree: every non-alphanumeric is "-". */
|
||||
const projectKey = (cwd) => String(cwd).replace(/[^A-Za-z0-9]/g, "-");
|
||||
|
||||
/** The uid a workspace's sessions run as (a member's under S3, else this process's), or null. */
|
||||
function workspaceUid(lane) {
|
||||
try {
|
||||
const acct = require("./run-as").accountForPath(lane.cwd);
|
||||
return acct ? acct.uid : typeof process.getuid === "function" ? process.getuid() : null;
|
||||
} catch {
|
||||
return null; // EMEMBERGONE: nobody to read as
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* What to copy for a page: `{laneId, main, extra: [{rel, as}]}` with every
|
||||
* path workspace-relative, or null when the main file is not an HTML file
|
||||
* inside the workspace. `cwd` is the session's folder (a relative path in
|
||||
* the hook is relative to it); `files` is the Artifact tool's supporting
|
||||
* files map (`{published: source | {from}}`) or list (`[{path}]`).
|
||||
* The scratchpad Claude Code gives ONE session —
|
||||
* `<tmp>/claude-<uid>/<project key>/<session id>/scratchpad`, `<tmp>` being
|
||||
* `/tmp`, `os.tmpdir()` or `CLAUDE_CODE_TMPDIR` — as `{dir, uid}`, when `abs`
|
||||
* lies inside it; else null. Only the text is judged here: `scratchpadSafe`
|
||||
* checks the folders on disk before anything is read.
|
||||
*/
|
||||
function pageCopy(laneId, cwd, file, files) {
|
||||
function scratchpadOf(lane, sessionId, cwd, abs) {
|
||||
if (!SESSION_ID_RE.test(String(sessionId ?? ""))) return null;
|
||||
const uid = workspaceUid(lane);
|
||||
if (uid == null) return null;
|
||||
const tail = path.join(`claude-${uid}`, projectKey(cwd), String(sessionId), "scratchpad");
|
||||
const bases = new Set(
|
||||
[require("node:os").tmpdir(), "/tmp", process.env.CLAUDE_CODE_TMPDIR]
|
||||
.filter((b) => typeof b === "string" && path.isAbsolute(b))
|
||||
.map((b) => path.resolve(b))
|
||||
);
|
||||
for (const b of bases) {
|
||||
const dir = path.join(b, tail);
|
||||
const rel = path.relative(dir, abs);
|
||||
if (rel && !rel.startsWith("..") && !path.isAbsolute(rel)) return { dir, uid };
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
/** Each of the scratchpad's four own folders is a real directory of its account (never a link). */
|
||||
async function scratchpadSafe(sp) {
|
||||
let d = sp.dir;
|
||||
for (let i = 0; i < 4; i += 1) {
|
||||
let st;
|
||||
try {
|
||||
st = await fs.promises.lstat(d);
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
if (!st.isDirectory() || st.uid !== sp.uid) return false;
|
||||
d = path.dirname(d);
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* Open `rel` inside a scratchpad like a pinned file is opened in a
|
||||
* workspace: confined by its REAL path, not a link, a regular file of the
|
||||
* scratchpad's account. `{size, stream}`.
|
||||
*/
|
||||
async function openScratch(sp, rel) {
|
||||
const refused = () =>
|
||||
Object.assign(new Error("not a file of this scratchpad"), { code: "ENOFILE" });
|
||||
const root = await fs.promises.realpath(sp.dir);
|
||||
const real = await fs.promises.realpath(path.resolve(sp.dir, rel));
|
||||
const r = path.relative(root, real);
|
||||
if (!r || r.startsWith("..") || path.isAbsolute(r)) throw refused();
|
||||
const { O_RDONLY, O_NOFOLLOW = 0, O_NONBLOCK = 0 } = fs.constants;
|
||||
const fh = await fs.promises.open(real, O_RDONLY | O_NOFOLLOW | O_NONBLOCK);
|
||||
const st = await fh.stat();
|
||||
if (!st.isFile() || st.uid !== sp.uid) {
|
||||
await fh.close();
|
||||
throw refused();
|
||||
}
|
||||
return {
|
||||
size: st.size,
|
||||
stream: fh.createReadStream({ start: 0, end: Math.max(0, st.size - 1) }),
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* What to copy for a page: `{laneId, main, extra: [{rel, as}], scratch?}`,
|
||||
* every path relative to its root — the workspace folder, or (`scratch`,
|
||||
* `{dir, uid}`) the publishing session's own scratchpad — or null when the
|
||||
* main file is not an HTML file inside either. `cwd` is the session's folder
|
||||
* (a relative path in the hook is relative to it); `files` is the Artifact
|
||||
* tool's supporting files map (`{published: source | {from}}`) or list
|
||||
* (`[{path}]`), each taken only from the main file's root.
|
||||
*/
|
||||
function pageCopy(laneId, cwd, file, files, sessionId) {
|
||||
const lane = require("./lanes").getLane(Number(laneId));
|
||||
if (!lane || !PAGE_FILE_EXT.test(file)) return null;
|
||||
const base = typeof cwd === "string" && path.isAbsolute(cwd) ? cwd : lane.cwd;
|
||||
const inLane = (p) => {
|
||||
const rel = path.relative(lane.cwd, path.resolve(base, p));
|
||||
const under = (root) => (p) => {
|
||||
const rel = path.relative(root, path.resolve(base, p));
|
||||
return rel && !rel.startsWith("..") && !path.isAbsolute(rel)
|
||||
? rel.split(path.sep).join("/")
|
||||
: null;
|
||||
};
|
||||
const main = inLane(file);
|
||||
if (!main) return null;
|
||||
let inRoot = under(lane.cwd);
|
||||
let main = inRoot(file);
|
||||
let scratch = null;
|
||||
if (!main) {
|
||||
scratch = scratchpadOf(lane, sessionId, base, path.resolve(base, file));
|
||||
if (!scratch) return null;
|
||||
inRoot = under(scratch.dir);
|
||||
main = inRoot(file);
|
||||
}
|
||||
const extra = [];
|
||||
const add = (as, src) => {
|
||||
if (typeof as !== "string" || !PUBLISHED_RE.test(as) || typeof src !== "string") return;
|
||||
const rel = inLane(src);
|
||||
const rel = inRoot(src);
|
||||
if (rel && extra.length < PAGE_FILES_MAX) extra.push({ rel, as });
|
||||
};
|
||||
if (Array.isArray(files)) {
|
||||
@@ -562,7 +655,7 @@ function pageCopy(laneId, cwd, file, files) {
|
||||
add(as, typeof v === "string" ? v : v && typeof v.from === "string" ? v.from : null);
|
||||
}
|
||||
}
|
||||
return { laneId: lane.id, main, extra };
|
||||
return scratch ? { laneId: lane.id, main, extra, scratch } : { laneId: lane.id, main, extra };
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -571,9 +664,11 @@ function pageCopy(laneId, cwd, file, files) {
|
||||
* written at its published path `as`. A file that is a secret, gone or
|
||||
* outside the workspace is skipped; the total stays under FILE_MAX_BYTES.
|
||||
* Returns `{snap, files: [{path, size}]}`, or null when nothing was copied.
|
||||
* `open(rel)` → `{size, stream}` reads one entry (default: the workspace's
|
||||
* guarded download).
|
||||
*/
|
||||
async function snapshotLaneFiles(lane, entries) {
|
||||
const { openDownload } = require("./lane-file-transfer");
|
||||
async function snapshotLaneFiles(lane, entries, open) {
|
||||
const read = open || ((rel) => require("./lane-file-transfer").openDownload(lane.cwd, rel));
|
||||
const snap = newSnapshotDir();
|
||||
const files = [];
|
||||
let total = 0;
|
||||
@@ -587,7 +682,7 @@ async function snapshotLaneFiles(lane, entries) {
|
||||
continue;
|
||||
let file;
|
||||
try {
|
||||
file = await openDownload(lane.cwd, rel);
|
||||
file = await read(rel);
|
||||
} catch {
|
||||
continue;
|
||||
}
|
||||
@@ -633,11 +728,14 @@ function setSnapshot(rowId, shot) {
|
||||
async function snapshotPage(rowId, copy) {
|
||||
const lane = require("./lanes").getLane(Number(copy.laneId));
|
||||
if (!lane) return null;
|
||||
const sp = copy.scratch;
|
||||
if (sp && !(await scratchpadSafe(sp))) return null;
|
||||
const mainAs = path.posix.basename(copy.main);
|
||||
const shot = await snapshotLaneFiles(lane, [
|
||||
{ rel: copy.main, as: mainAs },
|
||||
...copy.extra.filter((e) => e.as !== mainAs),
|
||||
]);
|
||||
const shot = await snapshotLaneFiles(
|
||||
lane,
|
||||
[{ rel: copy.main, as: mainAs }, ...copy.extra.filter((e) => e.as !== mainAs)],
|
||||
sp ? (rel) => openScratch(sp, rel) : undefined
|
||||
);
|
||||
if (!shot || shot.files[0].path !== mainAs) {
|
||||
if (shot) dropSnapshot(shot.snap.id);
|
||||
return null;
|
||||
@@ -681,7 +779,10 @@ async function ensurePageCopy(req, id) {
|
||||
}
|
||||
if (backfillTried.has(row.id)) return view(row, req);
|
||||
backfillTried.add(row.id);
|
||||
const copy = pageCopy(row.lane_id, null, row.source, null);
|
||||
const cwd = row.session_id
|
||||
? sql("SELECT cwd FROM sessions WHERE id = ?").get(row.session_id)?.cwd
|
||||
: null;
|
||||
const copy = pageCopy(row.lane_id, cwd || null, row.source, null, row.session_id);
|
||||
const next = copy ? await schedulePageSnapshot(row.id, copy) : null;
|
||||
return view(next || row, req);
|
||||
}
|
||||
|
||||
+28
-11
@@ -11,6 +11,22 @@ const path = require("path");
|
||||
const os = require("os");
|
||||
const fs = require("fs");
|
||||
|
||||
/**
|
||||
* Whether `p` exists, by `stat`. Not `fs.existsSync`: that is access(2), which
|
||||
* checks the REAL uid with capabilities cleared, so under S3 it says "no" for a
|
||||
* member's transcript behind their 0700 `~/.claude/projects` — and the chat
|
||||
* fell back to a stale snapshot while the unit itself reads the live file
|
||||
* through its CAP_DAC_READ_SEARCH.
|
||||
*/
|
||||
function exists(p) {
|
||||
try {
|
||||
fs.statSync(p);
|
||||
return true;
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
function getClaudeHome() {
|
||||
return process.env.CLAUDE_HOME || path.join(os.homedir(), ".claude");
|
||||
}
|
||||
@@ -143,7 +159,7 @@ function getTranscriptPath(sessionId, cwd) {
|
||||
if (!cwd) return null;
|
||||
const encoded = encodeCwd(cwd);
|
||||
const candidate = path.join(projectsDirFor(cwd), encoded, `${sessionId}.jsonl`);
|
||||
if (fs.existsSync(candidate)) return candidate;
|
||||
if (exists(candidate)) return candidate;
|
||||
// Fallback: scan the owner's projects/ subdirectories
|
||||
return findTranscriptPath(sessionId, cwd);
|
||||
}
|
||||
@@ -170,14 +186,14 @@ function getTranscriptPath(sessionId, cwd) {
|
||||
function resolveAgentTranscriptInDir(subagentsDir, agentId, runId = null) {
|
||||
if (!subagentsDir) return null;
|
||||
const flat = path.join(subagentsDir, `agent-${agentId}.jsonl`);
|
||||
if (fs.existsSync(flat)) return flat;
|
||||
if (exists(flat)) return flat;
|
||||
|
||||
const workflowsDir = path.join(subagentsDir, "workflows");
|
||||
if (!fs.existsSync(workflowsDir)) return null;
|
||||
if (!exists(workflowsDir)) return null;
|
||||
|
||||
if (runId) {
|
||||
const nested = path.join(workflowsDir, runId, `agent-${agentId}.jsonl`);
|
||||
return fs.existsSync(nested) ? nested : null;
|
||||
return exists(nested) ? nested : null;
|
||||
}
|
||||
|
||||
// Unknown run: accept only an unambiguous single match across all runs.
|
||||
@@ -186,7 +202,7 @@ function resolveAgentTranscriptInDir(subagentsDir, agentId, runId = null) {
|
||||
for (const d of fs.readdirSync(workflowsDir, { withFileTypes: true })) {
|
||||
if (!d.isDirectory()) continue;
|
||||
const cand = path.join(workflowsDir, d.name, `agent-${agentId}.jsonl`);
|
||||
if (fs.existsSync(cand)) matches.push(cand);
|
||||
if (exists(cand)) matches.push(cand);
|
||||
if (matches.length > 1) break;
|
||||
}
|
||||
return matches.length === 1 ? matches[0] : null;
|
||||
@@ -218,13 +234,13 @@ function getSubagentTranscriptPath(sessionId, cwd, agentId, runId = null) {
|
||||
*/
|
||||
function findTranscriptPath(sessionId, cwd = null) {
|
||||
for (const projectsDir of sessionProjectsDirs(cwd)) {
|
||||
if (!fs.existsSync(projectsDir)) continue;
|
||||
if (!exists(projectsDir)) continue;
|
||||
try {
|
||||
const dirs = fs.readdirSync(projectsDir, { withFileTypes: true });
|
||||
for (const d of dirs) {
|
||||
if (!d.isDirectory()) continue;
|
||||
const candidate = path.join(projectsDir, d.name, `${sessionId}.jsonl`);
|
||||
if (fs.existsSync(candidate)) return candidate;
|
||||
if (exists(candidate)) return candidate;
|
||||
}
|
||||
} catch {
|
||||
// Permission or IO error, ignore
|
||||
@@ -242,7 +258,7 @@ function findTranscriptPath(sessionId, cwd = null) {
|
||||
*/
|
||||
function getSnapshotTranscriptPath(sessionId) {
|
||||
const candidate = path.join(getTranscriptSnapshotDir(), `${sessionId}.jsonl`);
|
||||
return fs.existsSync(candidate) ? candidate : null;
|
||||
return exists(candidate) ? candidate : null;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -255,7 +271,7 @@ function getSnapshotTranscriptPath(sessionId) {
|
||||
*/
|
||||
function getSnapshotSubagentTranscriptPath(sessionId, agentId, runId = null) {
|
||||
const subDir = path.join(getTranscriptSnapshotDir(), sessionId, "subagents");
|
||||
if (!fs.existsSync(subDir)) return null;
|
||||
if (!exists(subDir)) return null;
|
||||
const hit = resolveAgentTranscriptInDir(subDir, agentId, runId);
|
||||
if (hit) return hit;
|
||||
if (agentId.startsWith("acompact-")) {
|
||||
@@ -287,13 +303,13 @@ function findSubagentTranscriptPath(sessionId, agentId, runId = null, cwd = null
|
||||
}
|
||||
|
||||
function findSubagentIn(projectsDir, sessionId, agentId, runId) {
|
||||
if (!fs.existsSync(projectsDir)) return null;
|
||||
if (!exists(projectsDir)) return null;
|
||||
try {
|
||||
const dirs = fs.readdirSync(projectsDir, { withFileTypes: true });
|
||||
for (const d of dirs) {
|
||||
if (!d.isDirectory()) continue;
|
||||
const subagentsDir = path.join(projectsDir, d.name, sessionId, "subagents");
|
||||
if (!fs.existsSync(subagentsDir)) continue;
|
||||
if (!exists(subagentsDir)) continue;
|
||||
|
||||
// Exact match (flat or nested Workflow-tool layout)
|
||||
const hit = resolveAgentTranscriptInDir(subagentsDir, agentId, runId);
|
||||
@@ -358,4 +374,5 @@ module.exports = {
|
||||
allProjectsDirs,
|
||||
sessionProjectsDirs,
|
||||
setClaudeHome,
|
||||
exists,
|
||||
};
|
||||
|
||||
@@ -21,6 +21,7 @@ const {
|
||||
getSnapshotSubagentTranscriptPath,
|
||||
findTranscriptPath,
|
||||
findSubagentTranscriptPath,
|
||||
exists,
|
||||
} = require("../lib/claude-home");
|
||||
const {
|
||||
classifyTranscriptSender,
|
||||
@@ -908,7 +909,7 @@ router.get("/:id/transcripts", async (req, res) => {
|
||||
getTranscriptPath(req.params.id, session.cwd) ||
|
||||
findTranscriptPath(req.params.id, session.cwd) ||
|
||||
getSnapshotTranscriptPath(req.params.id);
|
||||
if (mainPath && fs.existsSync(mainPath)) {
|
||||
if (mainPath && exists(mainPath)) {
|
||||
// Main agent database ID format: <sessionId>-main
|
||||
const mainDbAgent = dbAgents.find((a) => a.type === "main");
|
||||
result.push({
|
||||
@@ -928,18 +929,18 @@ router.get("/:id/transcripts", async (req, res) => {
|
||||
if (encoded) {
|
||||
// A member's session (S3) wrote under their own home.
|
||||
const directDir = path.join(projectsDirFor(session.cwd), encoded, req.params.id, "subagents");
|
||||
if (fs.existsSync(directDir)) subagentDirs.push(directDir);
|
||||
if (exists(directDir)) subagentDirs.push(directDir);
|
||||
}
|
||||
|
||||
// Fallback: scan the owner's project directory when the direct path doesn't exist
|
||||
if (subagentDirs.length === 0) {
|
||||
for (const projectsDir of sessionProjectsDirs(session.cwd)) {
|
||||
if (fs.existsSync(projectsDir)) {
|
||||
if (exists(projectsDir)) {
|
||||
try {
|
||||
for (const d of fs.readdirSync(projectsDir, { withFileTypes: true })) {
|
||||
if (!d.isDirectory()) continue;
|
||||
const candidate = path.join(projectsDir, d.name, req.params.id, "subagents");
|
||||
if (fs.existsSync(candidate)) subagentDirs.push(candidate);
|
||||
if (exists(candidate)) subagentDirs.push(candidate);
|
||||
}
|
||||
} catch {
|
||||
/* ignore */
|
||||
@@ -958,7 +959,7 @@ router.get("/:id/transcripts", async (req, res) => {
|
||||
// Try reading meta.json for agent type info
|
||||
let meta = null;
|
||||
const metaPath = path.join(dir, file.replace(".jsonl", ".meta.json"));
|
||||
if (fs.existsSync(metaPath)) {
|
||||
if (exists(metaPath)) {
|
||||
try {
|
||||
meta = JSON.parse(
|
||||
require("../lib/run-as").readFileSafe(metaPath, "utf8", { max: 1 << 20 })
|
||||
|
||||
Reference in New Issue
Block a user