84e2a9f0ac
Server mode can now run each account as its own Linux user (ah-<name>) when `agenthub server install-system` has set S3 up. The dashboard reaches a member only through sudo -u / write-as / pane-launch, reads a member's files only through owner- and type-checked opens, and hooks are authenticated by peer uid. Local mode and server mode without S3 are unchanged. EXPERIMENTAL: tested with fake sudo and fake accounts only. It has not yet been verified on a real install with real member accounts, sudo or a real Codex login. Do not offer it to real users yet. - S3 core: provisioning, per-member tmux servers, the proxy key gateway, shared tools in /opt, dropped capabilities for children (P0–P5) - P4: plan and quota per member home - P6: ~/.claude.json seed; opt-in plugin baseline installed as the member; managed-settings spike script (not run) - P7: Codex account pool (`agenthub accounts add --tool codex`) - Roles merged with main's admin / analyst / developer: analysts write only their own rows, under S3 as well - Per-account prefs: one implementation (Chat UI + onboarding) - Security reviews F1–F49 (five rounds), each fix with a regression test: symlink/TOCTOU-safe member reads, no host writes in a member home, credentials and the data dir never served, owner and folder account must agree, pane tokens bound to the pane's uid, bounded sudo/tmux/git calls and member reads (no hang or crash from a member), async route rejections answer 500 instead of exiting - Docs: docs/SERVER-MODE.md (S3 model, accepted ceilings, operator runbook), docs/plans/server-mode/S3-PLAN.md, CLAUDE.md S3 rules Tests: server 2838/2841 (3 need 127.0.0.1:3000, held on this box); client 1162/1162; tsc clean; headers check passes. Co-Authored-By: Claude <noreply@anthropic.com>
235 lines
8.8 KiB
JavaScript
235 lines
8.8 KiB
JavaScript
/**
|
|
* @file Codex lane status mirror. Without AgentHub's Codex hooks installed
|
|
* (codex-hooks.js, opt-in and trusted by the user in Codex) nothing else tells
|
|
* the dashboard that a `codex` lane's agent is working; while a lane's hooks
|
|
* are current (an event for its session in the last 2 minutes) this mirror
|
|
* leaves the lane to them. Its on-disk signal is the rollout journal Codex
|
|
* appends live, one file per thread:
|
|
*
|
|
* $CODEX_HOME/sessions/<YYYY>/<MM>/<DD>/rollout-<ts>-<threadId>.jsonl
|
|
* line 1: {"type":"session_meta","payload":{"cwd":…,"session_id":…}}
|
|
*
|
|
* This module maps each journal to the `codex` lane owning its cwd and mirrors
|
|
* idle↔running from how recently the journal was written. It reads nothing but
|
|
* the first line (for the cwd) and never touches a lane's stage — codex lanes
|
|
* carry no pipeline. Fail-safe like workflow-ingest.js: a malformed journal is
|
|
* skipped, and a poll pass never throws.
|
|
*
|
|
* Codex 0.149 also mirrors threads into version-suffixed SQLite files
|
|
* (`state_5.sqlite`, `thread_history_1.sqlite`), but every thread row still
|
|
* points at a live rollout file, so reading the JSONL costs no coupling to a
|
|
* schema the next Codex release renames. `allRolloutFiles()` is the one
|
|
* function to re-point if that ever stops being true (codex-usage.js walks
|
|
* the same files for sessions and token usage).
|
|
* @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
|
|
*/
|
|
|
|
const fs = require("node:fs");
|
|
const path = require("node:path");
|
|
const os = require("node:os");
|
|
const { getCodexHome } = require("./codex-home");
|
|
|
|
const FUTURE_SLACK_MS = 1000;
|
|
const CODEX_ACTIVE_MS = 120_000; // a journal written within 2 min means the agent is working
|
|
const MAX_FILES = 40; // newest-first cap so a years-deep sessions/ tree can't stall a pass
|
|
const MAX_DEPTH = 4; // sessions/<YYYY>/<MM>/<DD>/<file>
|
|
|
|
/**
|
|
* Every rollout journal under `<home>/sessions/` ({path, mtime, size}),
|
|
* unsorted. `home` is CODEX_HOME unless a remote source's mirror names its own.
|
|
*/
|
|
function allRolloutFiles(home = getCodexHome()) {
|
|
const out = [];
|
|
const walk = (dir, depth) => {
|
|
let entries = [];
|
|
try {
|
|
entries = fs.readdirSync(dir, { withFileTypes: true });
|
|
} catch {
|
|
return; // absent or unreadable — Codex may simply not be installed
|
|
}
|
|
for (const entry of entries) {
|
|
const full = path.join(dir, entry.name);
|
|
if (entry.isDirectory()) {
|
|
if (depth < MAX_DEPTH) walk(full, depth + 1);
|
|
} else if (entry.isFile() && /^rollout-.*\.jsonl$/.test(entry.name)) {
|
|
try {
|
|
const stat = fs.statSync(full);
|
|
out.push({ path: full, mtime: stat.mtimeMs, size: stat.size });
|
|
} catch {
|
|
/* vanished mid-scan */
|
|
}
|
|
}
|
|
}
|
|
};
|
|
walk(path.join(home, "sessions"), 0);
|
|
return out;
|
|
}
|
|
|
|
/** The newest MAX_FILES rollout journals of each home, newest mtime first. */
|
|
function rolloutFiles() {
|
|
// This account's CODEX_HOME and every member's (S3) — capped PER home, so
|
|
// one member touching many journals cannot push everyone else's out.
|
|
const newest = (files) => files.sort((a, b) => b.mtime - a.mtime).slice(0, MAX_FILES);
|
|
const members = require("./run-as")
|
|
.memberHomes()
|
|
.map((h) => path.join(h, ".codex"));
|
|
return [allRolloutFiles(), ...members.map((h) => allRolloutFiles(h))]
|
|
.flatMap(newest)
|
|
.sort((a, b) => b.mtime - a.mtime);
|
|
}
|
|
|
|
const cwdCache = new Map(); // rollout path → thread cwd (written once, at thread creation)
|
|
|
|
/** The thread's working directory, from the session_meta on the file's first line. */
|
|
function rolloutCwd(file) {
|
|
if (cwdCache.has(file)) return cwdCache.get(file);
|
|
let cwd = null;
|
|
try {
|
|
const fd = require("./run-as").openSafe(file);
|
|
try {
|
|
const buf = Buffer.alloc(64 * 1024);
|
|
const read = fs.readSync(fd, buf, 0, buf.length, 0);
|
|
const head = buf.toString("utf8", 0, read).split("\n")[0];
|
|
cwd = JSON.parse(head).payload.cwd || null;
|
|
} finally {
|
|
fs.closeSync(fd);
|
|
}
|
|
} catch {
|
|
cwd = null;
|
|
}
|
|
if (typeof cwd !== "string" || !cwd) cwd = null;
|
|
cwdCache.set(file, cwd);
|
|
return cwd;
|
|
}
|
|
|
|
/** Test seam: forget every cached cwd. */
|
|
function __resetCache() {
|
|
cwdCache.clear();
|
|
}
|
|
|
|
// Keyed by file path, so in a process that runs for months it would otherwise
|
|
// hold one dead entry per journal Codex ever wrote. Pruned only once well past
|
|
// the per-pass scan size, so ordinary churn keeps its entries.
|
|
const MAX_TRACKED = MAX_FILES * 4;
|
|
|
|
function pruneTracking(seen) {
|
|
if (cwdCache.size <= MAX_TRACKED) return;
|
|
for (const key of cwdCache.keys()) if (!seen.has(key)) cwdCache.delete(key);
|
|
}
|
|
|
|
/**
|
|
* One poll pass: mirror each codex lane's idle↔running from its journals.
|
|
*
|
|
* @param {{broadcast?: (laneId: number) => void}} [options]
|
|
* @returns {number} How many lanes actually changed (and were broadcast).
|
|
*/
|
|
function ingestCodexOnce({ broadcast } = {}) {
|
|
const lanesLib = require("./lanes");
|
|
|
|
let codexLanes = [];
|
|
try {
|
|
codexLanes = lanesLib.listLanes().filter((l) => l.tool === "codex");
|
|
} catch {
|
|
return 0;
|
|
}
|
|
if (!codexLanes.length) return 0;
|
|
|
|
const touched = new Set();
|
|
// One verdict per lane — running when ANY of its journals is fresh. Judging
|
|
// file by file against the same status snapshot flipped a lane with an old
|
|
// journal beside the live one between running and idle on every pass.
|
|
const activeByLane = new Map();
|
|
const files = rolloutFiles();
|
|
pruneTracking(new Set(files.map((f) => f.path)));
|
|
for (const file of files) {
|
|
const cwd = rolloutCwd(file.path);
|
|
if (!cwd) continue;
|
|
// A journal speaks only for its own account's lanes (S3): its cwd is what
|
|
// the journal SAYS, and a member can write any cwd into their own file.
|
|
const lane = codexLanes
|
|
.filter((l) => cwd === l.cwd || cwd.startsWith(`${l.cwd}/`))
|
|
.filter((l) => require("./run-as").sameOwner(file.path, l.cwd))
|
|
.sort((a, b) => b.cwd.length - a.cwd.length)[0];
|
|
if (!lane) continue;
|
|
|
|
// An mtime in the FUTURE (clock stepped back, NTP correction, a restore that
|
|
// preserved timestamps) makes the raw difference negative, which reads as
|
|
// "written milliseconds ago". A file that claims to be from the future is
|
|
// not evidence of an agent working now, so treat it as idle. The second of
|
|
// slack is for the file's nanosecond mtime against Date.now()'s truncated
|
|
// millisecond: a journal written this very millisecond reads as future.
|
|
const age = Date.now() - file.mtime;
|
|
const active = age > -FUTURE_SLACK_MS && age < CODEX_ACTIVE_MS;
|
|
const seen = activeByLane.get(lane.id);
|
|
activeByLane.set(lane.id, { lane, active: active || (seen ? seen.active : false) });
|
|
}
|
|
|
|
// Codex's hooks (codex-hooks.js) report a turn's start and end as they
|
|
// happen; while they are current, a journal written a minute ago would call
|
|
// a lane that just stopped "running".
|
|
const { db } = require("../db");
|
|
const hookedSince = new Date(Date.now() - CODEX_ACTIVE_MS).toISOString();
|
|
const recentHook = db.prepare(
|
|
"SELECT 1 FROM events WHERE session_id = ? AND created_at > ? LIMIT 1"
|
|
);
|
|
|
|
for (const { lane, active } of activeByLane.values()) {
|
|
if (lane.session_id && recentHook.get(lane.session_id, hookedSince)) continue;
|
|
// Status mirror, under the same guard hook ingestion uses: only idle↔running,
|
|
// and only for a lane the dashboard did not launch — provisioning and failed
|
|
// are lifecycle states this path must never stomp on. `updateLane` filters
|
|
// through PATCHABLE, which allows `status` and forbids `tool`.
|
|
const next = active ? "running" : "idle";
|
|
if (
|
|
!lane.run_id &&
|
|
(lane.status === "idle" || lane.status === "running") &&
|
|
next !== lane.status
|
|
) {
|
|
try {
|
|
lanesLib.updateLane(lane.id, { status: next });
|
|
touched.add(lane.id);
|
|
} catch {
|
|
/* lane deleted mid-pass, or sqlite busy — a status mirror is never worth throwing for */
|
|
}
|
|
}
|
|
}
|
|
|
|
for (const id of touched) {
|
|
try {
|
|
if (broadcast) broadcast(id);
|
|
} catch {
|
|
/* a broadcast failure must not abort the pass */
|
|
}
|
|
}
|
|
return touched.size;
|
|
}
|
|
|
|
/**
|
|
* Unref'd interval so it never blocks shutdown; disable with
|
|
* DASHBOARD_CODEX_POLL_MS=0. Codex appends its journal continuously, so a 15s
|
|
* beat keeps a codex card's running/idle within one beat of live.
|
|
*/
|
|
function startCodexPoll(broadcast) {
|
|
const POLL_MS = process.env.DASHBOARD_CODEX_POLL_MS
|
|
? Number(process.env.DASHBOARD_CODEX_POLL_MS)
|
|
: 15_000;
|
|
if (!Number.isFinite(POLL_MS) || POLL_MS <= 0) return;
|
|
const timer = setInterval(() => {
|
|
try {
|
|
ingestCodexOnce({ broadcast });
|
|
} catch {
|
|
/* a poll pass never throws into the event loop */
|
|
}
|
|
}, POLL_MS);
|
|
if (timer.unref) timer.unref();
|
|
}
|
|
|
|
module.exports = {
|
|
allRolloutFiles,
|
|
rolloutCwd,
|
|
FUTURE_SLACK_MS,
|
|
ingestCodexOnce,
|
|
startCodexPoll,
|
|
__resetCache,
|
|
};
|