feat(lanes): add lane-agents install core (E3)

2026-08-05 12:37:40 +07:00
parent 692ba65b0f
commit 4134b3d307
2 changed files with 172 additions and 0 deletions
@@ -0,0 +1,108 @@
+/**
+ * @file Tests for server/lib/lane-agents.js: installing the ship-feature-lane
+ * agent templates into a lane's .claude/agents/ and git-excluding them. Uses
+ * REAL git fixtures (a plain clone AND a `git worktree add` lane) because the
+ * exclude-file location depends on git's own git-dir/git-common-dir split —
+ * the same distinction E2's merge-driver setup had to get right.
+ * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
+ */
+
+const { describe, it, before, after } = require("node:test");
+const assert = require("node:assert/strict");
+const fs = require("node:fs");
+const os = require("node:os");
+const path = require("node:path");
+const { execFileSync } = require("node:child_process");
+
+const ROOT = fs.mkdtempSync(path.join(os.tmpdir(), "ccam-agents-"));
+
+const laneAgents = require("../lib/lane-agents");
+
+const g = (cwd, ...args) => {
+  const env = { ...process.env };
+  delete env.GIT_DIR;
+  delete env.GIT_WORK_TREE;
+  delete env.GIT_INDEX_FILE;
+  delete env.GIT_COMMON_DIR;
+  delete env.GIT_OBJECT_DIRECTORY;
+  delete env.GIT_ALTERNATE_OBJECT_DIRECTORIES;
+  delete env.GIT_PREFIX;
+  delete env.GIT_NAMESPACE;
+  delete env.GIT_CONFIG_PARAMETERS;
+  env.GIT_TERMINAL_PROMPT = "0";
+  return execFileSync("git", args, { cwd, encoding: "utf8", env });
+};
+const gc = (cwd, ...args) => g(cwd, "-c", "user.email=t@h", "-c", "user.name=t", ...args);
+
+after(() => fs.rmSync(ROOT, { recursive: true, force: true }));
+
+describe("installAgents against a plain clone", () => {
+  const REPO = path.join(ROOT, "plain-repo");
+
+  before(() => {
+    fs.mkdirSync(REPO, { recursive: true });
+    g(REPO, "init", "-q", "-b", "main", REPO);
+    fs.writeFileSync(path.join(REPO, "README.md"), "hello\n");
+    gc(REPO, "add", "-A");
+    gc(REPO, "commit", "-qm", "init");
+  });
+
+  it("writes both templates and appends the git-exclude line", async () => {
+    const result = await laneAgents.installAgents({ cwd: REPO });
+    assert.deepEqual(result.installed.sort(), ["qc-local.md", "senior-gate-reviewer.md"]);
+    assert.ok(fs.existsSync(path.join(REPO, ".claude", "agents", "qc-local.md")));
+    assert.ok(fs.existsSync(path.join(REPO, ".claude", "agents", "senior-gate-reviewer.md")));
+
+    const exclude = fs.readFileSync(path.join(REPO, ".git", "info", "exclude"), "utf8");
+    assert.match(exclude, /^\.claude\/agents\/$/m);
+  });
+
+  it("is idempotent — a second call does not duplicate the exclude line", async () => {
+    await laneAgents.installAgents({ cwd: REPO });
+    const exclude = fs.readFileSync(path.join(REPO, ".git", "info", "exclude"), "utf8");
+    const matches = exclude.split("\n").filter((line) => line === ".claude/agents/");
+    assert.equal(matches.length, 1);
+  });
+
+  it("overwrites existing template files on reinstall (not a merge)", async () => {
+    const dest = path.join(REPO, ".claude", "agents", "qc-local.md");
+    fs.writeFileSync(dest, "stale content from a previous version\n");
+    await laneAgents.installAgents({ cwd: REPO });
+    const content = fs.readFileSync(dest, "utf8");
+    assert.doesNotMatch(content, /stale content/);
+  });
+});
+
+describe("installAgents against a real git-worktree lane", () => {
+  it("writes the exclude line to the SHARED common dir, not the worktree-private one", async () => {
+    const wt = require("../lib/worktree");
+    const SRC = path.join(ROOT, "wt-src");
+    fs.mkdirSync(SRC, { recursive: true });
+    g(SRC, "init", "-q", "-b", "main", SRC);
+    fs.writeFileSync(path.join(SRC, "README.md"), "hello\n");
+    gc(SRC, "add", "-A");
+    gc(SRC, "commit", "-qm", "init");
+
+    const wtDir = path.join(ROOT, "wt-lane");
+    await wt.addWorktree({ sourceRepo: SRC, dir: wtDir, branch: "feat/agents", base: "main" });
+
+    const result = await laneAgents.installAgents({ cwd: wtDir });
+    assert.deepEqual(result.installed.sort(), ["qc-local.md", "senior-gate-reviewer.md"]);
+    assert.ok(fs.existsSync(path.join(wtDir, ".claude", "agents", "qc-local.md")));
+
+    // <wtDir>/.git is a FILE for a worktree lane — info/exclude must NOT be
+    // written under it. It belongs in the source repo's own .git/info/,
+    // shared across every worktree.
+    assert.ok(fs.statSync(path.join(wtDir, ".git")).isFile());
+    const exclude = fs.readFileSync(path.join(SRC, ".git", "info", "exclude"), "utf8");
+    assert.match(exclude, /^\.claude\/agents\/$/m);
+  });
+});
+
+describe("installAgents against a non-git directory", () => {
+  it("throws ENOTGITREPO rather than crashing on a missing .git", async () => {
+    const plain = path.join(ROOT, "not-a-repo");
+    fs.mkdirSync(plain, { recursive: true });
+    await assert.rejects(() => laneAgents.installAgents({ cwd: plain }), { code: "ENOTGITREPO" });
+  });
+});
@@ -0,0 +1,64 @@
+/**
+ * @file Installs the ship-feature-lane pipeline's agent templates
+ * (qc-local, senior-gate-reviewer) into a lane's own .claude/agents/, so a
+ * driving session can launch them by subagent_type. Plain file I/O except
+ * for one git call — resolving where a worktree lane's shared info/exclude
+ * actually lives, the same git-dir/git-common-dir distinction E2's
+ * lane-sync.js had to get right for info/attributes.
+ * @author Nguyễn Ngọc Trí Vĩ <vinnt@smartgift.vn>
+ */
+
+const fs = require("node:fs");
+const path = require("node:path");
+const { git } = require("./worktree");
+
+const TEMPLATE_DIR = path.join(__dirname, "..", "data", "agent-templates", "ship-feature-lane");
+const TEMPLATE_FILES = ["qc-local.md", "senior-gate-reviewer.md"];
+const EXCLUDE_LINE = ".claude/agents/";
+
+/** The dir shared across every worktree of a repo — where info/exclude
+ *  lives (same as info/attributes; MERGE_HEAD/HEAD/the index are the only
+ *  per-worktree-private state, not this). */
+async function commonGitDir(cwd) {
+  const result = await git(cwd, ["rev-parse", "--git-common-dir"]);
+  const dir = result.stdout.trim();
+  return path.isAbsolute(dir) ? dir : path.join(cwd, dir);
+}
+
+/**
+ * Copy both agent templates into `<lane.cwd>/.claude/agents/` (overwriting
+ * any existing copy — this is a reinstall, not a merge) and idempotently
+ * git-exclude that directory in the shared common git dir.
+ *
+ * @param {{cwd: string}} lane
+ * @returns {Promise<{installed: string[]}>}
+ */
+async function installAgents(lane) {
+  if (!fs.existsSync(path.join(lane.cwd, ".git"))) {
+    throw Object.assign(new Error(`lane has no .git — not a git repository: ${lane.cwd}`), {
+      code: "ENOTGITREPO",
+    });
+  }
+
+  const dest = path.join(lane.cwd, ".claude", "agents");
+  fs.mkdirSync(dest, { recursive: true });
+  const installed = [];
+  for (const name of TEMPLATE_FILES) {
+    fs.copyFileSync(path.join(TEMPLATE_DIR, name), path.join(dest, name));
+    installed.push(name);
+  }
+
+  const infoDir = path.join(await commonGitDir(lane.cwd), "info");
+  fs.mkdirSync(infoDir, { recursive: true });
+  const excludePath = path.join(infoDir, "exclude");
+  const existing = fs.existsSync(excludePath) ? fs.readFileSync(excludePath, "utf8") : "";
+  const lines = existing.split("\n").filter(Boolean);
+  if (!lines.includes(EXCLUDE_LINE)) {
+    lines.push(EXCLUDE_LINE);
+    fs.writeFileSync(excludePath, lines.join("\n") + "\n");
+  }
+
+  return { installed };
+}
+
+module.exports = { installAgents };